[Bug 9385] New: patron add labels right aligned in chrome
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Bug ID: 9385 Summary: patron add labels right aligned in chrome Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/memberentry.pl?op=modify&destina tion=circ&borrowernumber=499&category_type=A OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com Created attachment 14571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14571&action=edit label to the right In Chrome when adding/editing a patron the labels are aligned to the right instead of the left like in Firefox. See attached -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15250&action=edit Bug 9385 - patron add labels right aligned in chrome The <legend> element has been given right alignment which seems to only be respected by WebKit-based browsers. Users of Chrome and Safari see a right-aligned legend while others see a left-aligned one. Given that the legend is often applied to fieldsets spanning much of the screen it seems wiser to have them left-aligned. This patch removes "text-align:right" from the CSS so that <legend> will inherit the default left alignment. To test, view any page with a legend element, for instance the patron add form. In Firefox, Chrome, Safari, IE, etc. the legend ("Patron identity," "Main address," etc.) should be left-aligned in the fieldset. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15250|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15251&action=edit Bug 9385 - patron add labels right aligned in chrome The <legend> element has been given right alignment which seems to only be respected by WebKit-based browsers. Users of Chrome and Safari see a right-aligned legend while others see a left-aligned one. Given that the legend is often applied to fieldsets spanning much of the screen it seems wiser to have them left-aligned. This patch removes "text-align:right" from the CSS so that <legend> will inherit the default left alignment. To test, view any page with a legend element, for instance the patron add form. In Firefox, Chrome, Safari, IE, etc. the legend ("Patron identity," "Main address," etc.) should be left-aligned in the fieldset. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. Tested in IE, Chrome, Firefox, Opera. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15251|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 15264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15264&action=edit [SIGNED-OFF] Bug 9385 - patron add labels right aligned in chrome The <legend> element has been given right alignment which seems to only be respected by WebKit-based browsers. Users of Chrome and Safari see a right-aligned legend while others see a left-aligned one. Given that the legend is often applied to fieldsets spanning much of the screen it seems wiser to have them left-aligned. This patch removes "text-align:right" from the CSS so that <legend> will inherit the default left alignment. To test, view any page with a legend element, for instance the patron add form. In Firefox, Chrome, Safari, IE, etc. the legend ("Patron identity," "Main address," etc.) should be left-aligned in the fieldset. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. Tested in IE, Chrome, Firefox, Opera. No errors. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch fixes the described issues in Chromium and does not introduced any change with Firefox. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15264|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15325&action=edit Bug 9385 - patron add labels right aligned in chrome The <legend> element has been given right alignment which seems to only be respected by WebKit-based browsers. Users of Chrome and Safari see a right-aligned legend while others see a left-aligned one. Given that the legend is often applied to fieldsets spanning much of the screen it seems wiser to have them left-aligned. This patch removes "text-align:right" from the CSS so that <legend> will inherit the default left alignment. To test, view any page with a legend element, for instance the patron add form. In Firefox, Chrome, Safari, IE, etc. the legend ("Patron identity," "Main address," etc.) should be left-aligned in the fieldset. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. Tested in IE, Chrome, Firefox, Opera. No errors. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9385 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org