[Bug 43339] New: automatic_item_modification_by_age_configuration is not a real system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Bug ID: 43339 Summary: automatic_item_modification_by_age_configuration is not a real system preference Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- automatic_item_modification_by_age_configuration is not a real system preference. It should not fail the unit test t/db_dependent/check_sysprefs.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41682 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 [Bug 41682] Syspref discrepancies between new and upgraded installs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41682 |41834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41682 [Bug 41682] Syspref discrepancies between new and upgraded installs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41834 [Bug 41834] Remove systempreferences's options, explanation and type DB values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 203780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203780&action=edit Bug 43339: automatic_item_modification_by_age_configuration is not a real system preference It should not fail the unit test t/db_dependent/check_sysprefs.t. Test plan : 1.0) Without patch 1.1) Run : prove t/db_dependent/check_sysprefs.t => 'All tests successful' 1.2) Go to Cataloging > Automatic item modifications by age 1.3) Create some entries and save 1.4) Run : prove t/db_dependent/check_sysprefs.t => # Failed test at t/db_dependent/check_sysprefs.t line 96. # got: '1' # expected: '0' # Too many sysprefs in DB: automatic_item_modification_by_age_configuration 2.0) Apply patch 2.1) Run : prove t/db_dependent/check_sysprefs.t => 'All tests successful' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203783&action=edit Bug 43339: automatic_item_modification_by_age_configuration is not a real system preference It should not fail the unit test t/db_dependent/check_sysprefs.t. Test plan : 1.0) Without patch 1.1) Run : prove t/db_dependent/check_sysprefs.t => 'All tests successful' 1.2) Go to Cataloging > Automatic item modifications by age 1.3) Create some entries and save 1.4) Run : prove t/db_dependent/check_sysprefs.t => # Failed test at t/db_dependent/check_sysprefs.t line 96. # got: '1' # expected: '0' # Too many sysprefs in DB: automatic_item_modification_by_age_configuration 2.0) Apply patch 2.1) Run : prove t/db_dependent/check_sysprefs.t => 'All tests successful' Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 203814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203814&action=edit Bug 43339: automatic_item_modification_by_age_configuration is not a real system preference It should not fail the unit test t/db_dependent/check_sysprefs.t. Test plan : 1.0) Without patch 1.1) Run : prove t/db_dependent/check_sysprefs.t => 'All tests successful' 1.2) Go to Cataloging > Automatic item modifications by age 1.3) Create some entries and save 1.4) Run : prove t/db_dependent/check_sysprefs.t => # Failed test at t/db_dependent/check_sysprefs.t line 96. # got: '1' # expected: '0' # Too many sysprefs in DB: automatic_item_modification_by_age_configuration 2.0) Apply patch 2.1) Run : prove t/db_dependent/check_sysprefs.t => 'All tests successful' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Have added my sign-off, in case Owen's can be counted as QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203814|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 203815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203815&action=edit Bug 43339: automatic_item_modification_by_age_configuration is not a real system preference It should not fail the unit test t/db_dependent/check_sysprefs.t. Test plan : 1.0) Without patch 1.1) Run : prove t/db_dependent/check_sysprefs.t => 'All tests successful' 1.2) Go to Cataloging > Automatic item modifications by age 1.3) Create some entries and save 1.4) Run : prove t/db_dependent/check_sysprefs.t => # Failed test at t/db_dependent/check_sysprefs.t line 96. # got: '1' # expected: '0' # Too many sysprefs in DB: automatic_item_modification_by_age_configuration 2.0) Apply patch 2.1) Run : prove t/db_dependent/check_sysprefs.t => 'All tests successful' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43339 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org