https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 --- Comment #2 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Created attachment 172229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172229&action=edit Bug 37730: Batch patron modification header scroll When scroling down <staff_url>/cgi-bin/koha/tools/modborrowers.pl, there is a point where the table header leaves the normal flow of the page to stick to the top of the screen instead. When this occurs, the header becomes fixed: if scrolling through the table horizontally, only the body will move. This is an issue as it means that in this situation, some column headers cannot be viewed and the data does not necessarily match the header under which it is found. This patch resolves this issue by allowing the header to scroll horizontally and ensuring that the width of the column headers still match that of the columns themselves. Test plan: A) Reproduce the bug as per Pedro's intructions: --- 1) Visit "batch patron modification": <staff_url>/cgi-bin/koha/tools/modborrowers.pl 2) Enter multiple cardnumbers, in k-t-d you may use these: 23529000104159 23529000120056 23529000714163 23529000651225 23529000445172 23529000105040 23529000224510 23529000591678 3) Press "Continue" 4) Scroll down the page enough that the table headers row becomes "detached" and sticks to the top of the page as you scroll down. 5) Scroll the table horizontally. Notice the headers are stuck even though the data columns have moved horizontally, causing the headers and data to not match. --- B) Apply the patch C) Go through steps 1-5 again. This time, notice that the header scrolls along with the table body and that the column headers and data always match. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy, Sandbox -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172229|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 172234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172234&action=edit Bug 37730: Batch patron modification header scroll When scroling down <staff_url>/cgi-bin/koha/tools/modborrowers.pl, there is a point where the table header leaves the normal flow of the page to stick to the top of the screen instead. When this occurs, the header becomes fixed: if scrolling through the table horizontally, only the body will move. This is an issue as it means that in this situation, some column headers cannot be viewed and the data does not necessarily match the header under which it is found. This patch resolves this issue by allowing the header to scroll horizontally and ensuring that the width of the column headers still match that of the columns themselves. Test plan: A) Reproduce the bug as per Pedro's intructions: Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the table for release notes| |the batch patron | |modification" tool (Tools > | |Patrons and circulation > | |Batch patron modification). | |When you scrolled down the | |page so that table header | |rows are "sticky", and then | |scrolled to the right, the | |table header columns were | |fixed instead of changing | |to match the column | |contents. --- Comment #5 from David Nind <david@davidnind.com> --- Something went weird when I attached the signed off bug - most of the test plan was missing. I've amended the commit message to include the test plan and attached again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172235|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172276&action=edit Bug 37730: Batch patron modification header scroll When scroling down <staff_url>/cgi-bin/koha/tools/modborrowers.pl, there is a point where the table header leaves the normal flow of the page to stick to the top of the screen instead. When this occurs, the header becomes fixed: if scrolling through the table horizontally, only the body will move. This is an issue as it means that in this situation, some column headers cannot be viewed and the data does not necessarily match the header under which it is found. This patch resolves this issue by allowing the header to scroll horizontally and ensuring that the width of the column headers still match that of the columns themselves. Test plan: A) Reproduce the bug as per Pedro's intructions: Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the table for |This fixes the table for release notes|the batch patron |the batch patron |modification" tool (Tools > |modification tool (Tools > |Patrons and circulation > |Patrons and circulation > |Batch patron modification). |Batch patron modification). |When you scrolled down the |When you scrolled down the |page so that table header |page so that table header |rows are "sticky", and then |rows are "sticky", and then |scrolled to the right, the |scrolled to the right, the |table header columns were |table header columns were |fixed instead of changing |fixed instead of changing |to match the column |to match the column |contents. |contents. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Tested on 23.11.x and it looks better, so there is a problem with DT v2. I don't think we should add those kind of DT options for the different table. It's an interesting behaviour and it should be on all the tables the same. However here I am afraid that it will cause problem. It adds different nodes to the DOM and the structure is different than before. I will try if it's possible to fix it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38870 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37730 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Needs documenting --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.