[Bug 36948] New: SIP issues in Debian 12
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Bug ID: 36948 Summary: SIP issues in Debian 12 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On my Koha testing docker I was finding that SIP kept dying, though I could find no reason in the logs. 22 20240523 11:24:28 kohadev-koha-sip: client (pid 1831) exited with 1 status, respawning 23 20240523 11:24:29 kohadev-koha-sip: client (pid 1877) exited with 1 status, respawning 24 20240523 11:24:31 kohadev-koha-sip: client (pid 1878) exited with 1 status, respawning 25 20240523 11:24:33 kohadev-koha-sip: client (pid 1879) exited with 1 status, respawning 26 20240523 11:24:34 kohadev-koha-sip: client (pid 1880) exited with 1 status, respawning 27 20240523 11:24:34 kohadev-koha-sip: terminating too quickly, waiting 30 seconds 28 20240523 11:25:04 kohadev-koha-sip: end of 30 second respawn attempt burst delay I edited tie SIP config: log_file='/var/log/koha/kohadev/sip.log' Then I could see: 3724 [2024/05/23 13:17:30] [15317] [WARN] [undef]@[undef]: >&_SERVER_LOG C4::SIP::Trapper::OPEN /kohadevbox/koha/C4/SIP/Trapper.pm (43) 3725 2024/05/23-13:17:30 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(15317) 3726 Resolved [*]:8023 to [::]:8023, IPv6 3727 Not including resolved host [0.0.0.0] IPv4 because it will be handled by [::] IPv6 3728 Binding to TCP port 6001 on host 127.0.0.1 with IPv4 3729 Binding to TCP port 8023 on host :: with IPv6 3730 2024/05/23-13:17:30 Can't connect to TCP port 8023 on :: [Invalid argument] 3731 at line 66 in file /usr/share/perl5/Net/Server/Proto/TCP.pm 3732 2024/05/23-13:17:30 Server closing! I removed the 8023 section from SIPconfig and it worked! Then I talked to Kyle and we found it could be resolved with: port="127.0.0.1:8023/tcp" To resolve the OPEN error: +sub OPEN { + return 1; +} + -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167112&action=edit Bug 36948: Resolve SIP issues in D12 My Koha testing docker SIP started dying repeatedly after launch. After investigation, I found it was a problem with logging and default ports. In D12 there is no syslog anymore, everythign uses journal. Four our purposes, lets log SIP issues to sip.log by default Attaching a patch to clear things up. To test: 1 - Open KTD/D12 2 - tail -f /var/log/koha/kohadev/*.log 3 - On another terminal 'restart_all' 4 - Wait a bit, notice SIP dying 5 - Apply patch 6 - Update SIPconfig: server-params: log_file='/var/log/koha/kohadev/sip.log' service with port 8023: port="127.0.0.1:8023/tcp" 7 - Restart all 8 - Confirm SIP no longer dies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |jonathan.druart@gmail.com, | |julian.maurice@biblibre.com | |, m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, mtj@kohaaloha.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- CC'ing all the big brains as I am unsure if this is the correct way to solve this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Do you need the (empty) OPEN method in Trapper actually ? You dont have a CLOSE either? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #3)
Do you need the (empty) OPEN method in Trapper actually ? You dont have a CLOSE either?
Without it I get: 3724 [2024/05/23 13:17:30] [15317] [WARN] [undef]@[undef]: >&_SERVER_LOG C4::SIP::Trapper::OPEN /kohadevbox/koha/C4/SIP/Trapper.pm (43) Server does run, but this removes that error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167112|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 167134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167134&action=edit Bug 36948: Resolve SIP issues in D12 My Koha testing docker SIP started dying repeatedly after launch. After investigation, I found it was a problem with logging and default ports. In D12 there is no syslog anymore, everythign uses journal. Four our purposes, lets log SIP issues to sip.log by default Attaching a patch to clear things up. To test: 1 - Open KTD/D12 2 - tail -f /var/log/koha/kohadev/*.log 3 - On another terminal 'restart_all' 4 - Wait a bit, notice SIP dying 5 - Apply patch 6 - Update SIPconfig: server-params: log_file='/var/log/koha/kohadev/sip.log' service with port 8023: port="127.0.0.1:8023/tcp" 7 - Restart all 8 - Confirm SIP no longer dies Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- My SIP is working OK on my Koha 23.11.x on Ubuntu 22.04 which is based off Debian 12. But I do see my SIP failing as described on Koha main on Debian 12. I think I noticed that recently, but it was in the "too hard basket" while I had other things to do. -- I see what Nick means about the log file and the Trapper... although I've added a different bit of code to Trapper for now... And I see the error... [2024/05/24 01:00:23] [1009] [WARN] [undef]@[undef]: C4::SIP::Trapper=ARRAY(0x55900576a4e8)>&_SERVER_LOG at /kohadevbox/koha/C4/SIP/Trapper.pm line 39. C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (34) 2024/05/24-01:00:23 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(1009) Resolved [*]:8023 to [::]:8023, IPv6 Not including resolved host [0.0.0.0] IPv4 because it will be handled by [::] IPv6 Binding to TCP port 6001 on host 127.0.0.1 with IPv4 Binding to TCP port 8023 on host :: with IPv6 2024/05/24-01:00:23 Can't connect to TCP port 8023 on :: [Invalid argument] at line 66 in file /usr/share/perl5/Net/Server/Proto/TCP.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Looks like Debian 12 uses "libnet-server-perl 2.013-2" while Ubuntu 22.04 uses "libnet-server-perl 2.009-2". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
Looks like Debian 12 uses "libnet-server-perl 2.013-2" while Ubuntu 22.04 uses "libnet-server-perl 2.009-2".
Note that Ubuntu 22.04 there is no problem binding to *:8023: LISTEN 0 4096 *:8023 *:* users:(("perl",pid=915,fd=18),("perl",pid=823,fd=18)) Interestingly, "epmd" is separately bound to 0.0.0.0 and [::]: LISTEN 0 4096 0.0.0.0:4369 0.0.0.0:* users:(("epmd",pid=151,fd=3)) LISTEN 0 4096 [::]:4369 [::]:* users:(("epmd",pid=151,fd=4)) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- According to https://docs.docker.com/config/daemon/ipv6/ Docker doesn't support IPv6 out of the box. Of course, I don't know how I'm seeing "[::]:4369" in the output of "ss" for epmd in that case, but whatever. I'm noticing the following: $ sysctl -a | grep ipv6 | grep "disable" net.ipv6.conf.all.disable_ipv6 = 1 $ nc -l ::1 8008 -v -n nc: Cannot assign requested address -- Compare that with a normal Ubuntu 22.04 VM # sysctl -a | grep ipv6 | grep "disable" net.ipv6.conf.all.disable_ipv6 = 0 # nc -l ::1 8008 -n -v Listening on ::1 8008 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Regarding the 4369 thing... Notice that I can't connect to it on IPv6: nc :: 4369 -v nc: connect to :: port 4369 (tcp) failed: Cannot assign requested address nc ::1 4369 -v nc: connect to ::1 port 4369 (tcp) failed: Cannot assign requested address -- Whereas on a normal Ubuntu server it's no problem: # nc :: 22 -v Connection to :: 22 port [tcp/ssh] succeeded! nc ::1 22 -v Connection to ::1 22 port [tcp/ssh] succeeded! -- So overall... I'm happy with Nick's change to 'port="127.0.0.1:8023/tcp"'. It's a reasonable default generally speaking, and people on systems with IPv6 can always choose to change it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Note I am raising an issue with Net::Server, since it should consult net.ipv6.conf.all.disable_ipv6 at the very least I reckon. Or fail more gracefully in its bindings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Note: There are lots of ways to specify only IPv4 or to turn off IPv6 with Net::Server it seems. We could set $ENV{'NO_IPV6'} or $ENV{'IPV'}=4. Or we could pass "IPv4" along in the port specification. With that said, I think I still stand by Nick's change. I think it's the simplest change to make here. That said, we might consider adding one of the environmental variables, as this same issue could pop up again in different ways. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from David Cook <dcook@prosentient.com.au> --- I'm not so sure about the logging change TBH, so I'm going to Failed QA this one. I think the only bug is the port specification, so I think this bug report should only deal with that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36954 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Btw, I'm trying to think of a different bug title, but I'm struggling, since this is a Docker-specific issue. An alternative to any patch here would be to add one of those environmental variables to koha-testing-docker... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens (kidclamp) from comment #4)
(In reply to Marcel de Rooy from comment #3)
Do you need the (empty) OPEN method in Trapper actually ? You dont have a CLOSE either?
Without it I get: 3724 [2024/05/23 13:17:30] [15317] [WARN] [undef]@[undef]: >&_SERVER_LOG C4::SIP::Trapper::OPEN /kohadevbox/koha/C4/SIP/Trapper.pm (43)
Server does run, but this removes that error.
Net::Server tries to redirect STDERR to STDOUT: "If a log_file is given or if setsid is set, STDIN and STDOUT will automatically be opened to /dev/null and STDERR will be opened to STDOUT. This will prevent any output from ending up at the terminal." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #13)
I'm not so sure about the logging change TBH, so I'm going to Failed QA this one.
I have experimented a bit with removing the log_file parameter to Net::Server. Since we are already catching STDERR with Trapper. But note that our logging in SIP still is a bit cumbersome (historical ballast). We use C4::SIP::Logger. Which has been set in SIPServer: set_logger( Koha::Logger->get( { interface => 'sip' } ) ); And again in process_request: $self->{logger} = set_logger( Koha::Logger->get( { interface => 'sip' } ) ); But we also do: tie *STDERR, "C4::SIP::Trapper"; To redirect warns to Trapper. Which also calls Koha::Logger. And Koha::Logger is yet another wrapper for Log::Log4perl. So removing the log_file should be fine. We are already catching it to that file. We do not need the OPEN method since removing the log_file makes Net::Server no longer touch STDERR. And in the PRINT method we need to adjust the caller_depth. I tested with caller_depth +3 / -3 to get the 'real' caller. And I chomped the message with %m{chomp} in log4perl.conf to remove unneeded newlines in the logfile. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #12)
Note: There are lots of ways to specify only IPv4 or to turn off IPv6 with Net::Server it seems.
We could set $ENV{'NO_IPV6'} or $ENV{'IPV'}=4.
Or we could pass "IPv4" along in the port specification.
With that said, I think I still stand by Nick's change. I think it's the simplest change to make here.
That said, we might consider adding one of the environmental variables, as this same issue could pop up again in different ways.
This seems to work best (included v4 in the port spec): <service port="127.0.0.1:6001/tcp/IPv4" transport="RAW" protocol="SIP/2.00" client_timeout="600" timeout="60" /> Log says: [2024/05/24 07:48:32] [282769] [WARN] 2024/05/24-07:48:32 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(282769) Net::Server::run /usr/share/perl5/Net/Server.pm (52) [2024/05/24 07:48:32] [282769] [WARN] 2024/05/24-07:48:32 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(282769) Net::Server::log /usr/share/perl5/Net/Server.pm (911) [2024/05/24 07:48:32] [282769] [WARN] Binding to TCP port 6001 on host 127.0.0.1 with IPv4 Net::Server::bind /usr/share/perl5/Net/Server.pm (316) [2024/05/24 07:48:32] [282769] [WARN] Binding to TCP port 6001 on host 127.0.0.1 with IPv4 Net::Server::log /usr/share/perl5/Net/Server.pm (911) [2024/05/24 07:48:32] [282769] [WARN] Setting gid to "1000 1000" Net::Server::post_bind /usr/share/perl5/Net/Server.pm (379) [2024/05/24 07:48:32] [282769] [WARN] Setting gid to "1000 1000" Net::Server::log /usr/share/perl5/Net/Server.pm (911) In some other variants I saw it trying IPv6 still.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not sure about the need for category => 'STDERR' btw -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #17)
This seems to work best (included v4 in the port spec):
Startup is fine, but additional requests are not ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #19)
(In reply to Marcel de Rooy from comment #17)
This seems to work best (included v4 in the port spec):
Startup is fine, but additional requests are not ?
$self->{service} = $config->find_service($sockaddr, $port, $proto); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #20)
(In reply to Marcel de Rooy from comment #19)
(In reply to Marcel de Rooy from comment #17)
This seems to work best (included v4 in the port spec):
Startup is fine, but additional requests are not ?
$self->{service} = $config->find_service($sockaddr, $port, $proto);
Can be fixed quickly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- setsid Specifies whether or not the server should fork after the bind method to release itself from the command line and then run the POSIX::setsid() command to truly daemonize. Defaults to undef. If a log_file is given or if setsid is set, STDIN and STDOUT will automatically be opened to /dev/null and STDERR will be opened to STDOUT. This will prevent any output from ending up at the terminal. The etc/SIPconfig.xml file does contain a setsid. Can we remove it ? Note that the debian one does not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167134|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167147&action=edit Bug 36948: Resolve SIP issues in D12 My Koha testing docker SIP started dying repeatedly after launch. After investigation, I found it was a problem with logging and default ports. In D12 there is no syslog anymore, everythign uses journal. Four our purposes, lets log SIP issues to sip.log by default Attaching a patch to clear things up. To test: 1 - Open KTD/D12 2 - tail -f /var/log/koha/kohadev/*.log 3 - On another terminal 'restart_all' 4 - Wait a bit, notice SIP dying 5 - Apply patch 6 - Update SIPconfig: server-params: log_file='/var/log/koha/kohadev/sip.log' service with port 8023: port="127.0.0.1:8023/tcp" 7 - Restart all 8 - Confirm SIP no longer dies Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167148&action=edit Bug 36948: (follow-up) Remove log_file param, adjust caller_depth We keep OPEN when people still use log_file or setsid. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167149&action=edit Bug 36948: (follow-up) Allow IPv[46] in port config Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167150&action=edit Bug 36948: (follow-up) Add chomp to sip log4perl config Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167148|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167151&action=edit Bug 36948: (follow-up) Remove log_file param, adjust caller_depth We keep OPEN when people still use log_file or setsid. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167149|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167152&action=edit Bug 36948: (follow-up) Allow IPv[46] in port config Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167150|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167153&action=edit Bug 36948: (follow-up) Add chomp to sip log4perl config Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #22)
The etc/SIPconfig.xml file does contain a setsid. Can we remove it ? Note that the debian one does not.
Resolved this by keeping the OPEN routine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP issues in Debian 12 |Adjust SIPconfig for | |log_file and IP version -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #14)
Btw, I'm trying to think of a different bug title, but I'm struggling, since this is a Docker-specific issue.
An alternative to any patch here would be to add one of those environmental variables to koha-testing-docker...
Proposing a new title here. Keeping both issues btw -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Cook from comment #13)
I'm not so sure about the logging change TBH, so I'm going to Failed QA this one.
I think the only bug is the port specification, so I think this bug report should only deal with that.
with syslog going away in debian is this still an issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- (In reply to Kyle M Hall from comment #32)
(In reply to David Cook from comment #13)
I'm not so sure about the logging change TBH, so I'm going to Failed QA this one.
I think the only bug is the port specification, so I think this bug report should only deal with that.
with syslog going away in debian is this still an issue?
I'm not sure I follow. I meant that the bug reported was the crashing due to being unable to create the TCP socket bindings, so this report should just focus on that. Logging can be handled as a separate report. I figure it would make backporting and overall management easier, but if people disagree I won't stand in the way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #33)
(In reply to Kyle M Hall from comment #32)
(In reply to David Cook from comment #13)
I'm not so sure about the logging change TBH, so I'm going to Failed QA this one.
I think the only bug is the port specification, so I think this bug report should only deal with that.
with syslog going away in debian is this still an issue?
I'm not sure I follow. I meant that the bug reported was the crashing due to being unable to create the TCP socket bindings, so this report should just focus on that.
Logging can be handled as a separate report.
I figure it would make backporting and overall management easier, but if people disagree I won't stand in the way.
Is that really needed? A few tiny patches to split again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> ---
I figure it would make backporting and overall management easier, but if people disagree I won't stand in the way.
Is that really needed? A few tiny patches to split again?
I would agree. If anyone feels strongly enough to FQA this please do so! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00, 24.05.02 released in| | --- Comment #37 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00, 24.05.02 |24.11.00,24.05.02,23.11.07 released in| | --- Comment #38 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #39 from wainuiwitikapark@catalyst.net.nz --- not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes issues with release notes| |logging and default ports | |in the SIP configuration | |for Debian 12, when using | |the koha-testing-docker | |(KTD) development | |environment - these issues | |were causing the SIP | |service to stop working. | |Changes include updating | |the SIPconfig.xml template | |to: | |- fix the logging issue | |(Debian 12 uses journal | |instead of syslog, use | |chomp for SIP log4perl | |configuration, log all SIP | |issues to sip.log by | |default) | |- fix the port | |issue (allows using IPv4 | |and IPv6 for the port | |settings, configures the | |default template to use | |IPv4) --- Comment #40 from David Nind <david@davidnind.com> --- I had a go at a release note - please update if I have got anything/everything wrong. My understanding from attempting to read the comments is that this only affects using KTD with Debian 12 (not production installation of Koha), but the changes accommodate the differences when using other operating system images such as Ubuntu 22.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36948 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #41 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org