[Bug 37733] New: Some glitches in Preservation module after bootstrap5 update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Bug ID: 37733 Summary: Some glitches in Preservation module after bootstrap5 update Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 35402 1. "Preservation" does not appear styled in the "More" menu https://snipboard.io/6CmOWD.jpg 2. "Add to waiting list" modal is not centered http://localhost:8081/cgi-bin/koha/preservation/waiting-list https://snipboard.io/mIBYkj.jpg 3. Confirmation box "Are you sure you want to remove this item" is not centered correctly https://snipboard.io/ZgJFGC.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170876&action=edit Bug 37733: Fix header menu style for preservation link This patch adds the missing "dropdown-item" class to the link in the header menu for the preservation module. To test, apply the patch and enable the preservation module (PreservationModule). Reload the page and click "More" in the header menu. The "Preservation" link should be styled like all the others. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- What about the other issues? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170948&action=edit Bug 37733: Try to fix modal in the Preservation module We certainly need more as ERM module also use modals. And the Dialog component seems to have more elements affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I guess we need to split this bug, but lacking time today. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #0)
1. "Preservation" does not appear styled in the "More" menu
https://snipboard.io/6CmOWD.jpg
2. "Add to waiting list" modal is not centered
http://localhost:8081/cgi-bin/koha/preservation/waiting-list
https://snipboard.io/mIBYkj.jpg
3. Confirmation box "Are you sure you want to remove this item" is not centered correctly
Moved to bug 37812. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some glitches in |Preservation link in the |Preservation module after |header menu is not styled |bootstrap5 update |correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170876|0 |1 is obsolete| | Attachment #170948|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170957&action=edit Bug 37733: Fix header menu style for preservation link This patch adds the missing "dropdown-item" class to the link in the header menu for the preservation module. To test, apply the patch and enable the preservation module (PreservationModule). Reload the page and click "More" in the header menu. The "Preservation" link should be styled like all the others. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37733 Bug 37733 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org