[Bug 37740] New: Saved reports GROUP tabs don't show the proper panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Bug ID: 37740 Summary: Saved reports GROUP tabs don't show the proper panel Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org TO recreate: 1. Have some reports and report groups. 2. GO to Reports > Used Saved 3. The 'All' tab properly shows reports. 4. All other tabs have no reports listed. It doesn't appear like the panels are being built. Looks to be caused by Bug 35402. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- I'm not sure what got lost. It seems like there was only a single panel being built 'reports_panel' ( [% WRAPPER tab_panels %] ). However, when building the nav-links all the groups are looped through ( [% FOREACH group IN groups_with_subgroups %] ). ( [% WRAPPER tabs_nav %] ) We cannot build many tabs and only a single panel. It creates bad HTML. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170838&action=edit Bug 37740: Fix saved SQL reports tab switching The tabs on the saved SQL report page are not really full tabs, they're just styled that way. There is only one tab "panel," and clicking each tab triggers a DataTable filter so that the tab only shows the relevant data. The problem with this setup is that when Bootstrap tries to "switch" tabs, it wants to hide the initial tab and then show the new one. There is no "new" one here. The attached patch solves this problem by adding a CSS rule to guided_reports_start.tt with higher specificity than our global CSS making the relevant tab pane visible at all times. To test, apply the patch and go to Reports -> Use saved. - If necessary, create multiple SQL reports and assign them to different report groups (Accounts, Acquisitions, Catalog, etc.). - Test that tab switching works: - The tab should be style as "active" after you click it. - The table of reports should be filtered to include only reports in the relevant report group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170838|0 |1 is obsolete| | --- Comment #3 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Created attachment 170871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170871&action=edit Bug 37740: Fix saved SQL reports tab switching The tabs on the saved SQL report page are not really full tabs, they're just styled that way. There is only one tab "panel," and clicking each tab triggers a DataTable filter so that the tab only shows the relevant data. The problem with this setup is that when Bootstrap tries to "switch" tabs, it wants to hide the initial tab and then show the new one. There is no "new" one here. The attached patch solves this problem by adding a CSS rule to guided_reports_start.tt with higher specificity than our global CSS making the relevant tab pane visible at all times. To test, apply the patch and go to Reports -> Use saved. - If necessary, create multiple SQL reports and assign them to different report groups (Accounts, Acquisitions, Catalog, etc.). - Test that tab switching works: - The tab should be style as "active" after you click it. - The table of reports should be filtered to include only reports in the relevant report group. Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloe.zermatten@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170871|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170879&action=edit Bug 37740: Fix saved SQL reports tab switching The tabs on the saved SQL report page are not really full tabs, they're just styled that way. There is only one tab "panel," and clicking each tab triggers a DataTable filter so that the tab only shows the relevant data. The problem with this setup is that when Bootstrap tries to "switch" tabs, it wants to hide the initial tab and then show the new one. There is no "new" one here. The attached patch solves this problem by adding a CSS rule to guided_reports_start.tt with higher specificity than our global CSS making the relevant tab pane visible at all times. To test, apply the patch and go to Reports -> Use saved. - If necessary, create multiple SQL reports and assign them to different report groups (Accounts, Acquisitions, Catalog, etc.). - Test that tab switching works: - The tab should be style as "active" after you click it. - The table of reports should be filtered to include only reports in the relevant report group. Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37740 Bug 37740 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org