https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 176249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176249&action=edit Bug 38847 - Renewing a child without guarantor whith ChildNeedsGuarantor results in an internal server error (edit) o Test plan: 1 - Create a child, make sure it has no guarantor 2 - Set ChildNeedsGuarantor to Yes 3 - Renew the child (on morember.pl or circulation.pl) -> you will have an internal server error 4 - Apply patch 5 - Go to moremember.pl, try and renew the patron -> you will be redirected to moremember with an error message 6 - Go to circulation.pl, try and renew the patron -> you will be redirected to circultation.pl with an error message 7 - Create a guarantor for the patron 8 - Repeat 5 & 6 and notice it is now renewed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #176249|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Comment on attachment 176249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176249 Bug 38847 - Renewing a child without guarantor whith ChildNeedsGuarantor results in an internal server error (edit) o I edited the commit message to be more consistent with the commit message guidelines - colon after the bug number in the title, description, improved the test plan, clarify that this is for when the patron's account is expired. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes an internal |This fixes an internal release notes|server error when renewing |server error when renewing |an expired |an expired child patron |child patron |without a guarantor, when |without a guarantor, when |the ChildNeedsGuarantor |the ChildNeedsGuarantor |system preference is set to |system preference is set to |"must have". It now |"must have". It now |displays a standard error |displays a standard error |message with "This patron |message with "This patron |could not be renewed: they |could not be renewed: they |need a guarantor." |need a guarantor." | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177135|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177589&action=edit Bug 38847: Fix error when renewing an expired child patron without a guarantor This fixes an internal server error when renewing an expired child patron without a guarantor, when the ChildNeedsGuarantor is set to "must have". Test plan: 1. Create or edit a child patron: - Don't add a guarantor. - Set the "Expiry date" to a date in the past. 2. Set the ChildNeedsGuarantor system preference to "must have". 3. Refresh or view the patron's check out or details page, and select the "Renew" link under the attention heading - this generates an internal server error message. 4. Apply patch. 5. Repeat step 3, you will now get a standard error message "This patron could not be renewed: they need a guarantor." 6. Add a guarantor for the patron. 7. Repeat step 3, and click "Renew" - the patron is now renewed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Made a tiny change: Changed: <p>They must have a guarantor defined</p> To: <p>They must have a guarantor</p> I feel "defined" is more for developers :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.