[Bug 38649] New: Searching for a patron from additem.pl triggers an issue slip to print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Bug ID: 38649 Summary: Searching for a patron from additem.pl triggers an issue slip to print Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 37407 fixed automatic checkout of items that were fast cataloged from the circulation module. To reproduce: 1. From anywhere on the additem.pl page where you are adding or editing an item 2. Click on Checkout in the menu bar and enter a patron's barcode 3. When circulation.pl loads it triggers a blank issue slip to be printed In addition to checking the referrer for the URL domain and path we should also check the query string of the referrer to make sure it was from a circulation fast add. It should include frameworkcode=FA&circborrowernumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37407 Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37407 [Bug 37407] Fast add / fast cataloging from patron checkout does not checkout item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 175269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175269&action=edit Bug 38649: Fix autocheckout for circulation Fast Add only In addition to checking the referrer for the URL domain and path we should also check the query string of the referrer to make sure it was from a circulation fast add. It should include frameworkcode=FA&circborrowernumber To test: 1. From anywhere on the additem.pl page where you are adding or editing an item 2. Click on Checkout in the menu bar and enter a patron's barcode 3. When circulation.pl loads it triggers a blank issue slip to be printed 4. Apply patch and repeat steps 1-3, no slip is triggered to print 5. Go to Circulation Checkout for a patron and enter a non existing barcode like 1337 6. Click '+ Add record using fast cataloging' 7. Fill in required fields and click 'Add item' 8. Confirm the item is auto checked out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175269|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 175275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175275&action=edit Bug 38649: Fix autocheckout for circulation Fast Add only In addition to checking the referrer for the URL domain and path we should also check the query string of the referrer to make sure it was from a circulation fast add. It should include frameworkcode=FA&circborrowernumber To test: 1. From anywhere on the additem.pl page where you are adding or editing an item 2. Click on Checkout in the menu bar and enter a patron's barcode 3. When circulation.pl loads it triggers a blank issue slip to be printed 4. Apply patch and repeat steps 1-3, no slip is triggered to print 5. Go to Circulation Checkout for a patron and enter a non existing barcode like 1337 6. Click '+ Add record using fast cataloging' 7. Fill in required fields and click 'Add item' 8. Confirm the item is auto checked out Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue when release notes| |searching for a patron | |using the check out menu | |item in the header, when | |you are on the add or edit | |item form for a record. It | |was triggering a blank | |issue slip for printing. | |This was caused by a change | |in Bug 37407 (Fast add/fast | |cataloging from patron | |checkout does not checkout | |item) that affected | |checking referrer URLs and | |query strings. CC| |david@davidnind.com Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | --- Comment #3 from David Nind <david@davidnind.com> --- Changed assignee 8-). I've attempted a release note, but not sure that I have got this right - I don't know how to describe it correctly for library staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175275|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175595&action=edit Bug 38649: Fix autocheckout for circulation Fast Add only In addition to checking the referrer for the URL domain and path we should also check the query string of the referrer to make sure it was from a circulation fast add. It should include frameworkcode=FA&circborrowernumber To test: 1. From anywhere on the additem.pl page where you are adding or editing an item 2. Click on Checkout in the menu bar and enter a patron's barcode 3. When circulation.pl loads it triggers a blank issue slip to be printed 4. Apply patch and repeat steps 1-3, no slip is triggered to print 5. Go to Circulation Checkout for a patron and enter a non existing barcode like 1337 6. Click '+ Add record using fast cataloging' 7. Fill in required fields and click 'Add item' 8. Confirm the item is auto checked out Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- It produces a JS error: Uncaught TypeError: document.referrer.split(...)[1] is undefined On the following page: http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- not backporting to 24.05.x unless requested - keyword of additional work needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #6)
It produces a JS error: Uncaught TypeError: document.referrer.split(...)[1] is undefined
On the following page: http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
Can you double check if you can still reproduce the issue? I didn't see an error on that page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Katrin Fischer from comment #8)
(In reply to Jonathan Druart from comment #6)
It produces a JS error: Uncaught TypeError: document.referrer.split(...)[1] is undefined
On the following page: http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
Can you double check if you can still reproduce the issue? I didn't see an error on that page
This was resolve with bug 39307 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Bug 38649 depends on bug 37407, which changed state. Bug 37407 Summary: Fast add / fast cataloging from patron checkout does not checkout item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37407 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org