[Bug 21915] New: Add a way to automatically reconcile balance for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Bug ID: 21915 Summary: Add a way to automatically reconcile balance for patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 18805 introduced a way to use existing credits to cancel outstanding debts, from the staff interface. Most users expressed they want existing credits to be applied to outstanding debt, in an automatic way. We could add a syspref controlling this behaviour, and a cli script for people wanting all the balances reconciled at once, or nightly through a cronjob. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |18805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 [Bug 18805] Add ability to use up account credits -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82762&action=edit Bug 21915: Add AccountAutoReconciliate syspref This syspref will be used to call the reconcile_balance routing as needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82763&action=edit Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call This patch makes _FixAccountForLostAndReturned reconcile the patron's account balance, when the AccountAutoReconcile syspref is set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass, peace \o/ - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82763|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82764&action=edit Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call This patch makes _FixAccountForLostAndReturned reconcile the patron's account balance, when the AccountAutoReconcile syspref is set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass, peace \o/ - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82762|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82765&action=edit Bug 21915: Add AccountAutoReconciliate syspref This syspref will be used to call the reconcile_balance routing as needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cbrannon@cdalibrary.org, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82781&action=edit Bug 21915: Call reconcile_balance on manual invoice creation This patch makes the manual invoice creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding credit - Create a manual invoice => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual invoice => SUCCESS: Reconcillation happened - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82782&action=edit Bug 21915: Call reconcile_balance on manual credit creation This patch makes the manual credit creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding debits - Create a manual credit => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual credit => SUCCESS: Reconcillation happened - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82784&action=edit Bug 21915: Add a cli script to reconcile balances This patch adds a CLI script, reconcile_balances.pl that takes care of calling the reconcile operation for all patrons that have outstanding credits. To test: - Have patrons with outstanding credits and debits - Run the script: $ kshell k$ perl misc/cronjobs/reconcile_balances.pl --verbose => SUCCESS: Notice patrons got their balances reconciled, and useful information is output. - Add new outstanding credits and debits to patrons you con easily identify - Run: k$ perl misc/cronjobs/reconcile_balances.pl => SUCCESS: Notice balances are reconciled, but no output - Run: k$ perl misc/cronjobs/reconcile_balances.pl --help => SUCCESS: Usage information is printed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82789&action=edit Bug 21915: Add AccountAutoReconcile syspref This syspref will be used to call the reconcile_balance routing as needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82790&action=edit Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call This patch makes _FixAccountForLostAndReturned reconcile the patron's account balance, when the AccountAutoReconcile syspref is set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass, peace \o/ - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82791&action=edit Bug 21915: Call reconcile_balance on manual invoice creation This patch makes the manual invoice creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding credit - Create a manual invoice => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual invoice => SUCCESS: Reconcillation happened - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82792&action=edit Bug 21915: Call reconcile_balance on manual credit creation This patch makes the manual credit creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding debits - Create a manual credit => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual credit => SUCCESS: Reconcillation happened - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82793&action=edit Bug 21915: Add a cli script to reconcile balances This patch adds a CLI script, reconcile_balances.pl that takes care of calling the reconcile operation for all patrons that have outstanding credits. To test: - Have patrons with outstanding credits and debits - Run the script: $ kshell k$ perl misc/cronjobs/reconcile_balances.pl --verbose => SUCCESS: Notice patrons got their balances reconciled, and useful information is output. - Add new outstanding credits and debits to patrons you con easily identify - Run: k$ perl misc/cronjobs/reconcile_balances.pl => SUCCESS: Notice balances are reconciled, but no output - Run: k$ perl misc/cronjobs/reconcile_balances.pl --help => SUCCESS: Usage information is printed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82789|0 |1 is obsolete| | Attachment #82790|0 |1 is obsolete| | Attachment #82791|0 |1 is obsolete| | Attachment #82792|0 |1 is obsolete| | Attachment #82793|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82803&action=edit Bug 21915: Add AccountAutoReconcile syspref This syspref will be used to call the reconcile_balance routing as needed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82804&action=edit Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call This patch makes _FixAccountForLostAndReturned reconcile the patron's account balance, when the AccountAutoReconcile syspref is set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass, peace \o/ - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82805&action=edit Bug 21915: Call reconcile_balance on manual invoice creation This patch makes the manual invoice creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding credit - Create a manual invoice => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual invoice => SUCCESS: Reconcillation happened - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82806&action=edit Bug 21915: Call reconcile_balance on manual credit creation This patch makes the manual credit creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding debits - Create a manual credit => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual credit => SUCCESS: Reconcillation happened - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82807&action=edit Bug 21915: Add a cli script to reconcile balances This patch adds a CLI script, reconcile_balances.pl that takes care of calling the reconcile operation for all patrons that have outstanding credits. To test: - Have patrons with outstanding credits and debits - Run the script: $ kshell k$ perl misc/cronjobs/reconcile_balances.pl --verbose => SUCCESS: Notice patrons got their balances reconciled, and useful information is output. - Add new outstanding credits and debits to patrons you con easily identify - Run: k$ perl misc/cronjobs/reconcile_balances.pl => SUCCESS: Notice balances are reconciled, but no output - Run: k$ perl misc/cronjobs/reconcile_balances.pl --help => SUCCESS: Usage information is printed. - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82863&action=edit Bug 21915: Add AccountAutoReconcile syspref This syspref will be used to call the reconcile_balance routing as needed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82864&action=edit Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call This patch makes _FixAccountForLostAndReturned reconcile the patron's account balance, when the AccountAutoReconcile syspref is set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass, peace \o/ - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82865&action=edit Bug 21915: Call reconcile_balance on manual invoice creation This patch makes the manual invoice creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding credit - Create a manual invoice => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual invoice => SUCCESS: Reconcillation happened - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82866&action=edit Bug 21915: Call reconcile_balance on manual credit creation This patch makes the manual credit creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding debits - Create a manual credit => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual credit => SUCCESS: Reconcillation happened - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82867&action=edit Bug 21915: Add a cli script to reconcile balances This patch adds a CLI script, reconcile_balances.pl that takes care of calling the reconcile operation for all patrons that have outstanding credits. A weird situation has been spotted in the wild, in which a debit ends up actually being a credit, because amount outstanding is tweaked in dropbox-mode returns. Until we figure what to do about that (probably a new account type, etc), we catch any exceptions and warn about the situation. To test: - Have patrons with outstanding credits and debits - Run the script: $ kshell k$ perl misc/cronjobs/reconcile_balances.pl --verbose => SUCCESS: Notice patrons got their balances reconciled, and useful information is output. - Add new outstanding credits and debits to patrons you con easily identify - Run: k$ perl misc/cronjobs/reconcile_balances.pl => SUCCESS: Notice balances are reconciled, but no output - Run: k$ perl misc/cronjobs/reconcile_balances.pl --help => SUCCESS: Usage information is printed. - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21969 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've added bug 21969 as dependency, because some pathological use cases considered debits as credits. Those cases are explained in bug 14591, and should be dealt with on a separate bug report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 [Bug 21969] Koha::Account->outstanding_* should look for debits/credits by checking 'amount' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82863|0 |1 is obsolete| | Attachment #82864|0 |1 is obsolete| | Attachment #82865|0 |1 is obsolete| | Attachment #82866|0 |1 is obsolete| | Attachment #82867|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83053&action=edit Bug 21915: Add AccountAutoReconcile syspref This syspref will be used to call the reconcile_balance routing as needed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82863|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82864|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82865|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82866|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82867|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82863|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83062&action=edit Bug 21915: Add AccountAutoReconcile syspref This syspref will be used to call the reconcile_balance routing as needed. Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82864|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83063&action=edit Bug 21915: Reconcile balance on _FixAccountForLostAndReturned call This patch makes _FixAccountForLostAndReturned reconcile the patron's account balance, when the AccountAutoReconcile syspref is set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass, peace \o/ - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82865|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83064&action=edit Bug 21915: Call reconcile_balance on manual invoice creation This patch makes the manual invoice creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding credit - Create a manual invoice => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual invoice => SUCCESS: Reconcillation happened - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82866|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83065&action=edit Bug 21915: Call reconcile_balance on manual credit creation This patch makes the manual credit creation step call Koha::Account::reconcile_balance when the AccountAutoReconcile syspref is set. To test: - Apply the patch - Have some outstanding debits - Create a manual credit => SUCCESS: Same behaviour as always - Set AccountAutoReconcile - Create a manual credit => SUCCESS: Reconcillation happened - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82867|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83066&action=edit Bug 21915: Add a cli script to reconcile balances This patch adds a CLI script, reconcile_balances.pl that takes care of calling the reconcile operation for all patrons that have outstanding credits. A weird situation has been spotted in the wild, in which a debit ends up actually being a credit, because amount outstanding is tweaked in dropbox-mode returns. Until we figure what to do about that (probably a new account type, etc), we catch any exceptions and warn about the situation. To test: - Have patrons with outstanding credits and debits - Run the script: $ kshell k$ perl misc/cronjobs/reconcile_balances.pl --verbose => SUCCESS: Notice patrons got their balances reconciled, and useful information is output. - Add new outstanding credits and debits to patrons you con easily identify - Run: k$ perl misc/cronjobs/reconcile_balances.pl => SUCCESS: Notice balances are reconciled, but no output - Run: k$ perl misc/cronjobs/reconcile_balances.pl --help => SUCCESS: Usage information is printed. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor rebase during QA was required... All tests pass, qa scripts pass and the code looks solid.. I could not find any regressions and I could not think of anywhere that we may have missed. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |In the past, if a patron release notes| |had any credit existing on | |their account (newly added, | |or pre-existing), if debts | |were present then the | |credit balance would always | |be immediately applied to | |the debt. This | |functionality was | |inadvertently removed | |during refactoring efforts. | | | |This patch adds code to | |restore the functionality | |and allows it to be | |optionally applied to the | |system via a new system | |preference, | |`AccountAutoReconcile`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 18580 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 [Bug 21896] Add Koha::Account::reconcile_balance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18805 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 [Bug 18805] Add ability to use up account credits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Bug 21915 depends on bug 21896, which changed state. Bug 21896 Summary: Add Koha::Account::reconcile_balance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21896 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Bug 21915 depends on bug 21969, which changed state. Bug 21969 Summary: Koha::Account->outstanding_* should look for debits/credits by checking 'amount' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21969 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- We should have a dependent bug to call reconcile balance for fines (when closed, not accruing) but I think is beyond scope here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #33)
We should have a dependent bug to call reconcile balance for fines (when closed, not accruing) but I think is beyond scope here
Feel free to file a bug and assign it to me to deal with that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|In the past, if a patron |In the past, if a patron release notes|had any credit existing on |had any credit existing on |their account (newly added, |their account (newly added, |or pre-existing), if debts |or pre-existing), if debts |were present then the |were present then the |credit balance would always |credit balance would always |be immediately applied to |be immediately applied to |the debt. This |the debt. This |functionality was |functionality was |inadvertently removed |inadvertently removed |during refactoring efforts. |during refactoring efforts | |which debuted in 16.11. |This patch adds code to | |restore the functionality |This patch adds code to |and allows it to be |restore the functionality |optionally applied to the |and allows it to be |system via a new system |optionally applied to the |preference, |system via a new system |`AccountAutoReconcile`. |preference, | |`AccountAutoReconcile`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 [Bug 15899] Remove the use of recordpayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|In the past, if a patron |In the past, if a patron release notes|had any credit existing on |had any credit existing on |their account (newly added, |their account (newly added, |or pre-existing), if debts |or pre-existing), if debts |were present then the |were present then the |credit balance would always |credit balance would always |be immediately applied to |be immediately applied to |the debt. This |the debt. This |functionality was |functionality was |inadvertently removed |inadvertently removed |during refactoring efforts |during refactoring efforts |which debuted in 16.11. |which debuted in 16.11. | | |This patch adds code to |This patch adds code to |restore the functionality |restore the functionality |and allows it to be |and allows it to be |optionally applied to the |optionally applied to the |system via a new system |system via a new system |preference, |preference, |`AccountAutoReconcile`. |`AccountAutoReconcile`. | | | |Note: The new preference | |defaults to the post 16.11 | |behaviour, if you wish to | |restore the 16.11 | |functionality then you will | |need to update the | |preference after the | |upgrade. Status|Pushed to Stable |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #36 from Jesse Maseto <jesse@bywatersolutions.com> --- Will not be in 18.05. Merge conflicts and doesn't apply cleanly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 [Bug 24266] Noisy error in reconcile_balances.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We need to build a tree of bugs to take notice of this system preference.. I keep finding cases where it's not being applied :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24290 [Bug 24290] `_FixOverduesOnReturn` does not respect `AccountAutoReconcile` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25146 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 [Bug 25146] Reconcile Balances Cron - should we remove? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25780 [Bug 25780] More options for reconcile_balances.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org