[Bug 24858] New: Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Bug ID: 24858 Summary: Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The wording of the two options in ExcludeHolidaysFromMaxPickUpDelay is reversed. This error was introduced in bug 22381. - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22381 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 [Bug 22381] Wording on Calendar-related system preferences not standardized -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 100667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100667&action=edit Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay TO TEST: - Apply patch - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100667|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 100669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100669&action=edit Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay TO TEST: - Apply patch - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100669|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100676&action=edit Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay TO TEST: - Apply patch - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #8 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Dependency not in 18.11.x, not backporting to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- reverted from 19.05.x, missing dependency that I overlooked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.05, |20.05.00, 19.11.05 released in|19.05.10 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Bug 24858 depends on bug 22381, which changed state. Bug 22381 Summary: Wording on Calendar-related system preferences not standardized https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25779 [Bug 25779] ExcludeHolidaysFromMaxPickUpDelay has opposite effect -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org