https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 91438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91438&action=edit Bug 23292: Use TransferSlip when transfering item which is on hold Combining hold and transfer slips might get confusing for patrons. Those represent quite different things. Hold slip could be used on self-service pickup for patrons and transfer slip has information for librarians. There can also be data protection issue if same slip is used in both cases. Test plan: - Apply the patch - Create hold for a record, define pickup branch different than your current branch. - Check in an item from your branch. - Click 'Print slip, transfer, and confirm' - See that the slip is TRANSFERSLIP - Change your branch same as hold's pickup branch - Check in the item again. - Click 'Print slip and confirm' - See that the slip is now HOLD_SLIP Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Johanna, I cannot cleanly apply this patch to master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 --- Comment #5 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Changing from HoldSlip to TransferSlip would be a step back for us, as we differentiate between holds and ordinary transfers - which enables us to prioritise how we unpack our stock. I think the problem described can be resolved with Template Toolkit - you can create an IF this THEN this ELSE this condition in the HoldSlip syntax. Here's an example of the syntax (which you can then modify with HTML to lay it out correctly): [% USE Branches %] [% loggedinbranchname = Branches.GetName( Branches.GetLoggedInBranchcode() ) %] [% IF loggedinbranchname == branch.branchname%] [% hold.expirationdate | $KohaDates %] [% borrower.surname %] [% USE String %] [% patronsname = borrower.firstname %] [% patronsname.substr (0, 1) %] [% USE String %] [% patronscard = borrower.cardnumber %] *******[% patronscard.substr (7, 3) %] [% branch.branchname %] [% biblio.title %] [% biblio.author %] [% item.barcode %] [% branch.branchname %] [% today | $KohaDates %] [% ELSE %] [% branch.branchcode %]* [% branch.branchname %] [% biblio.title %] [% biblio.author %] [% item.barcode %] [% today | $KohaDates %] [% END %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andreas Hedström Mace from comment #7)

I still see Johannas approach as the more valid one, especially concerning issues of data privacy. For Sallys use case, I would suggest changing the approach: adding holds information to the transfer slips using the IF statement in the TT syntax, rather than keeping todays behaviour.

I agree with you, but while we think this is better, others might not. It will also create problems with updates and conflict with our principle of not interrupting workflows on update. - notices need to be changed and possibly translated - we can't automatically do that on update, so it would need a big warning sign That's why I have been asking for making this optional. We could keep the existing behaviour and switch it for new installations. Also - everyone who wants to, can switch as soon as things are configured. For you suggestion we'd also need to make sure that TRANSFERSLIP has access to the same tables/objects as the current HOLDSLIP. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 --- Comment #10 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Andreas Hedström Mace from comment #7)

I still see Johannas approach as the more valid one, especially concerning issues of data privacy. For Sallys use case, I would suggest changing the approach: adding holds information to the transfer slips using the IF statement in the TT syntax, rather than keeping todays behaviour.

Thanks Katrin - making it optional would be a good solution. Andreas - as long as our workflow can remain the same (it is vital that staff packing and unpacking items in transit can differentiate on the printed slip between low and high priority transfers - i.e. ordinary returns vs items on hold), I don't mind how we approach this. ...but I can't see how to implement your suggestion of using TransferSlip instead of HoldSlip? The two notices don't share the same object variables - hold and borrower aren't available in TransferSlip, so how would we identify something as being on hold? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 --- Comment #12 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Ok, I will make this optional and looking those other things mentioned. -- You are receiving this mail because: You are watching all bug changes.