https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108282|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108284&action=edit Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108284|0 |1 is obsolete| | --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108413&action=edit Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. ------------------------ Tested offline circulation and working find Check all and Uncheck all option. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm I tried uploading the file as decribed... but: Can't use an undefined value as an ARRAY reference at /home/vagrant/kohaclone/offline_circ/enqueue_koc.pl line 148 Not sure if that's only me? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108418&action=edit Bug 26212: Remove the use of jquery.checkboxes plugin from pending offline circulations This patch removes the use of the jquery.checkboxes plugin from the pending offline circulations page, replacing it with in-page JS. Unrelated: The JS-based creation of the "select all" and "clear all" controls has been replaced with HTML links. Labels are added to the results table to make checkbox selection easier. To test, apply the patch and go to Circulation. - Upload an offline circulation file (.koc) with multiple transactions. If you don't want to generate this file using the desktop application or Firefox add-on you can create a text file like this (tab separated): Version=1.0 Generator=koct-firefox GeneratorVersion=0.1 2020-08-14 13:24:21 issue 0109132 33000000093476 - Go to Pending offline circulation actions. You should see the list of transactions you uploaded. - Test that the "Check all" and "Uncheck all" controls work correctly. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108413|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.