[Bug 26214] New: Remove the use of jquery.checkboxes plugin on late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Bug ID: 26214 Summary: Remove the use of jquery.checkboxes plugin on late orders page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the late orders page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108287&action=edit Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108287|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108288&action=edit Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108288|0 |1 is obsolete| | --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108409&action=edit Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108409|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108421&action=edit Bug 26214: Remove the use of jquery.checkboxes plugin on late orders page This patch replaces the use of the jquery.checkboxes plugin on late orders page in acquisitions. Unrelated changes: The "Check all" and "Uncheck all" links are moved out of the table header so that it matches similar interfaces. Sorting is now disabled on the checkboxes column and the table is sorted by default on the "Order line" column. To test, apply the patch and go to Acquisitions -> Late orders. - On the initial view, there should be no "Check all" or "Uncheck all" links. - Select a vendor in the left-hand sidebar form. - When the filtered table is redisplayed the "Check all" and "Uncheck all" links should now be visible. - Test that the links work correctly. - Confirm that the checkboxes column cannot be sorted and that the table is sorted by default by order line number. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26214 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org