[Bug 42612] New: "Import this batch into the catalog" button has useless class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 Bug ID: 42612 Summary: "Import this batch into the catalog" button has useless class Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The "Import this batch into the catalog" button has a class of "button" but that doesn't do anything. It should be updated to use BS5 like "btn btn-default" or even "btn btn-primary". Right now it blurs into the background. It's not good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 199171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199171&action=edit Bug 42612: Change button colours in manage-marc-import.pl This patches changes the button colours in manage-marc-import.pl so that "Import this batch into the catalog" is more prominent, and "Apply different matching rules" is less prominent. Test plan: 0. Apply the patch 1. Go to a bib record like http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 2. Click "Save" and choose "MARCXML" 3. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 4. Click "Upload file" 5. Choose "MARCXML" for the "Format:" 6. Change "Check for embedded item record data" to "No" 7. Click "Stage for import" 8. Wait for the staging to complete. This will be show when the status bar hits "100% Finished" and a "View batch" link appears. 9. Click "View batch" 10. Note that "Import this batch into the catalog" is a prominent yellow button with black text 11. Note that "Apply different matching rules" is a less prominent dark grey button with white text -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199171|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199175&action=edit Bug 42612: Change button colours in manage-marc-import.pl This patches changes the button colours in manage-marc-import.pl so that "Import this batch into the catalog" is more prominent, and "Apply different matching rules" is less prominent. Test plan: 0. Apply the patch 1. Go to a bib record like http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 2. Click "Save" and choose "MARCXML" 3. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 4. Click "Upload file" 5. Choose "MARCXML" for the "Format:" 6. Change "Check for embedded item record data" to "No" 7. Click "Stage for import" 8. Wait for the staging to complete. This will be show when the status bar hits "100% Finished" and a "View batch" link appears. 9. Click "View batch" 10. Note that "Import this batch into the catalog" is a prominent yellow button with black text 11. Note that "Apply different matching rules" is a less prominent dark grey button with white text Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | Status|Signed Off |Passed QA --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- This works as described and it makes sense to style the submit button as the primary button. Nice work. Passing QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 199989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199989&action=edit Bug 42612: Change button colours in manage-marc-import.pl This patches changes the button colours in manage-marc-import.pl so that "Import this batch into the catalog" is more prominent, and "Apply different matching rules" is less prominent. Test plan: 0. Apply the patch 1. Go to a bib record like http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 2. Click "Save" and choose "MARCXML" 3. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 4. Click "Upload file" 5. Choose "MARCXML" for the "Format:" 6. Change "Check for embedded item record data" to "No" 7. Click "Stage for import" 8. Wait for the staging to complete. This will be show when the status bar hits "100% Finished" and a "View batch" link appears. 9. Click "View batch" 10. Note that "Import this batch into the catalog" is a prominent yellow button with black text 11. Note that "Apply different matching rules" is a less prominent dark grey button with white text Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42612 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org