[Bug 7057] New: C4::Reserves::CheckReserves uses GetMemberDetails unnecessarily
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7057 Bug #: 7057 Summary: C4::Reserves::CheckReserves uses GetMemberDetails unnecessarily Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org CheckReserves, which is a workhorse subroutine, calls GetMemberDetails possibly MANY times during it's execution (for each reserve on a biblio). All it uses from this call is branchcode. This is massively inefficient at large scales. Replacing this with GetMember would be much, much more efficient. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7057 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-18 21:58:11 UTC --- Created attachment 5967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5967 Proposed patch Replaces CheckReserves call to GetMemberDetails with a call to GetMember. Much more efficient, since only branchcode is needed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7057 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7057 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7058 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7057 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5967|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-10-19 19:42:18 UTC --- Created attachment 5993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5993 [SIGNED-OFF] Bug 7057: CheckReserves uses GetMemberDetails unnecessarily Replaces call to GetMemberDetails with a call to GetMember. Much more efficient, and since only branchcode is used, no required data is lost. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7057 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7057 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 22:17:35 UTC --- Also marking as Passed QA, for RM's discretion to integrate -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7057 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed Severity|enhancement |minor --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-20 01:06:33 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org