[Bug 7059] New: All usage of GetMemberDetails on reserve/request.pl is unnecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7059 Bug #: 7059 Summary: All usage of GetMemberDetails on reserve/request.pl is unnecessary Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org Blocks: 7058 Only borrower-table fields are used in any of the 4 calls to GetMemberDetails on reserve/request.pl. Replacing with GetMember() will be more efficient without any data loss -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7059 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-18 22:34:24 UTC --- Created attachment 5968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5968 Proposed Patch Changes all calls in reserve/request.pl from GetMemberDetails to GetMember, since the extra data pulled in is not worth the required CPU cycles. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7059 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7059 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5968|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-10-19 19:45:51 UTC --- Created attachment 5995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5995 [SIGNED-OFF] Bug 7059: Remove GetMemberDetails from reserve/request.pl Replaces all four usages of GetMemberDetails with GetMember, since none of the hashref fields used were anything other than those in borrower table, which GetMember returns. To Test: 1. Apply patch 2. Go to reserve/request.pl; the page should load without error 3. Search for a cardnumber: the page should load without error Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7059 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7059 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 22:17:52 UTC --- Passed QA, RM please verify -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7059 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed Severity|enhancement |minor --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-20 01:08:46 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org