[Bug 19929] New: Add Koha Objects for class_source and class_sort_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Bug ID: 19929 Summary: Add Koha Objects for class_source and class_sort_rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70337&action=edit Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassificationSorters.t prove -v t/db_dependent/Koha/ClassificationSources.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- The full word "Classification" makes the file name to DB file in the head without reading and without consulting schema harder. ClassSortRule and ClassSortRules would be nicer than ClassificationSort and ClassificationSorters, I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 70337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70337 Bug 19929 - Add Koha objects for class sources and sorters Review of attachment 70337: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19929&attachment=70337) ----------------------------------------------------------------- ::: Koha/ClassificationSorters.pm @@ +20,5 @@
+use Carp; + +use Koha::Database; + +use Koha::ClassificationSorters;
It uses itself? Don't think this is correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 [Bug 20357] Pod Coverage checking for no public subs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20357 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 [Bug 20357] Pod Coverage checking for no public subs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70337|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72948&action=edit Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72948|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72949&action=edit Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72949|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72959&action=edit Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t NOTE: No POD was added, but I don't believe it is mandatory. PERL13 says it is only encouraged, not required. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Working here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72959|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72965&action=edit Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72966&action=edit Bug 19929: (QA follow-up) Fix POD Make qa tools happy. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org