[Bug 19856] New: Improve styling of reports sidebar to match tools sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Bug ID: 19856 Summary: Improve styling of reports sidebar to match tools sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Use styling from tools sidebar for reports sidebar as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664 [Bug 19664] Reports sidebar menu should match list of reports on reports home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 --- Comment #1 from jwayway@hotmail.com --- Created attachment 70543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70543&action=edit Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jwayway@hotmail.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70543|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70554&action=edit Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- With this patch, it only worsk for guided reports. You should also change the file reports-menu.inc, to get this working on any of reports with sidebar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70554|0 |1 is obsolete| | --- Comment #4 from jwayway@hotmail.com --- Created attachment 70642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70642&action=edit Bug 19856: Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com --- Comment #5 from Charles Farmer <charles.farmer@inlibro.com> --- I don't know if it was an innocuous mistake, but the first patch modified guided-reports-view.inc, and now the only available patch on this bug changes reports-menu.inc instead.
From what I read, Josef suggested _adding_ another patch, not replacing it altogether.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by claude <claude.brayer@cea.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72674&action=edit Bug 19856: Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now. Signed-off-by: claude <claude.brayer@cea.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70554|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70554|0 |1 is obsolete| | Attachment #72674|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73074&action=edit Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73075&action=edit Bug 19856: Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now. Signed-off-by: claude <claude.brayer@cea.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I unobsoleted the first patch, both have been signed off separately, so I didn't squash them. Together they create a complete fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |FIXED --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org