[Bug 31750] New: Need more padding in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Bug ID: 31750 Summary: Need more padding in cataloguing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The cataloguing form lacks some padding to match the top bar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141753&action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- IMHO this just needs to not have rounded corners ( border-radius ) on the tab-content element. The padding looks nice as is and looks good when you scroll down and the toolbar stays fixed to the top of the screen. Although, that is just my opinion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tihnk a little bit of padding would not hurt, but need to keep the floating toolbar in mind. I'd also like to have the "Section 4" heading not stick to the section border. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142083&action=edit Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142084&action=edit Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142083|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 142095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142095&action=edit Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142084|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 142096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142096&action=edit Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142095|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142316&action=edit Bug 31750: Need more padding in cataloguing This patch makes some minor tweaks to the CSS controlling the appearance of the toolbar shown in the basic cataloging editor. To test, apply the patch and go to Cataloging -> New record. - Confirm that the page looks correct, with the toolbar the same width as the main content of the page. - Confirm that the toolbar looks correct when you scroll and the toolbar "floats" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142096|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142317&action=edit Bug 31750: (follow-up) Stylelint fixes This patch makes no changes which affect the style of the page. All changes are corrections to formatting. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Solid improvements here.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It may be my eyes... but isn't the 'Cancel' link mis-aligned slightly.. apearing slightly above the content of the buttons in the toolbar? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nah.. it's my eyes.. inspecting it suggests it's all the same padding etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750 Bug 31750 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org