[Bug 31753] New: Dialog boxes inside of modals don't seem wide enough
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Bug ID: 31753 Summary: Dialog boxes inside of modals don't seem wide enough Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 30952 Created attachment 141757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141757&action=edit Screenshot of problem The dialog boxes inside of modals don't quite look right. They seem to lack the proper width. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 31836 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 31857 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142145&action=edit Bug 31753: Dialog boxes inside of modals don't seem wide enough This patch makes some tweaks to the style of Bootstrap modals in the staff interface, including making a correction to the style of .dialog <div>s within modals. The patch makes a correction to the modal markup generated by the guided reports template for SQL previews so that the modal footer displays correctly. The patch also removes CSS which makes links inside headings the same color as the heading text. The effect of this was to make links invisible in the headings of hold confirmation modals. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test the hold confirmation modal in check-in: - Place a hold on an available title. - Check in an item from that record and confirm that the modal looks correct. The "Check in message" box should take up the whole width of the modal, and the links in the modal header should be the standard green. - Test the SQL preview modal in reports: - Go to Reports -> Use saved. - Click the actions menu associated with one of your saved reports and choose "Preview SQL." The modal should look correct. - Other modals which might be tested: MARC previews from the bibliographic detail page, the cataloging search page, the Z39.50 search page, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142145|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 142202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142202&action=edit Bug 31753: Dialog boxes inside of modals don't seem wide enough This patch makes some tweaks to the style of Bootstrap modals in the staff interface, including making a correction to the style of .dialog <div>s within modals. The patch makes a correction to the modal markup generated by the guided reports template for SQL previews so that the modal footer displays correctly. The patch also removes CSS which makes links inside headings the same color as the heading text. The effect of this was to make links invisible in the headings of hold confirmation modals. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test the hold confirmation modal in check-in: - Place a hold on an available title. - Check in an item from that record and confirm that the modal looks correct. The "Check in message" box should take up the whole width of the modal, and the links in the modal header should be the standard green. - Test the SQL preview modal in reports: - Go to Reports -> Use saved. - Click the actions menu associated with one of your saved reports and choose "Preview SQL." The modal should look correct. - Other modals which might be tested: MARC previews from the bibliographic detail page, the cataloging search page, the Z39.50 search page, etc. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I think I somewhat preferred the lighter green for the headers/footers for the modal windows... 8-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hate to say it, but I think I agree with David.. I thought I'd prefer the friendlier green for the modal headers/footers but actually I find the contrast between the linked green and the background of the header/footer not as nice... wonder if there's a slight middle ground. I'm not a big color pallet guru though.. I'd love to see our greens a little more standardized.. I prefer our bugzilla/koha-community.org/git.koha-community.org green to the green we use for the new search header bar for example.... though that doesn't really relate to this directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142202|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142326&action=edit Bug 31753: Dialog boxes inside of modals don't seem wide enough This patch makes some tweaks to the style of Bootstrap modals in the staff interface, including making a correction to the style of .dialog <div>s within modals. The patch makes a correction to the modal markup generated by the guided reports template for SQL previews so that the modal footer displays correctly. The patch also removes CSS which makes links inside headings the same color as the heading text. The effect of this was to make links invisible in the headings of hold confirmation modals. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Test the hold confirmation modal in check-in: - Place a hold on an available title. - Check in an item from that record and confirm that the modal looks correct. The "Check in message" box should take up the whole width of the modal, and the links in the modal header should be the standard green. - Test the SQL preview modal in reports: - Go to Reports -> Use saved. - Click the actions menu associated with one of your saved reports and choose "Preview SQL." The modal should look correct. - Other modals which might be tested: MARC previews from the bibliographic detail page, the cataloging search page, the Z39.50 search page, etc. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142327&action=edit Bug 31753: (follow-up) lighten headers more OK.. colors are hard!.. This patch increases the 'lighten' parameter a little and hopefully improves the headers and footers of modals slighty back to being less 'bright' green. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. colors shouldn't hold this up... so Passing QA. I've added a follow-up with my attempt at a minor "improvement" to the final color however.. Attaching screen shot of 'before', 'first patch', 'follow-up' side by side for comparison now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142328&action=edit Side by side comparisons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like 'follow-up' :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31753 Bug 31753 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org