[Bug 25266] New: Not all vendors are listed in the filters on the late order claims page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Bug ID: 25266 Summary: Not all vendors are listed in the filters on the late order claims page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org As the title says, for some reason the list of vendors available in the late order claims page is not fully populated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.oconnordesmond@staff | |.ittralee.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103596&action=edit Bug 25266: Display vendor with late orders in the dropdown list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hum, there is something weird going on here. On test is failing but I don't understand why! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the behaviour was: - Show the vendors from the 'results' in the pull down - When filtered on a vendor, show the 'check all' link - Then you could proceed to claim all for that vendor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It appears to work in 18.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103596|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104254&action=edit Bug 25266: Build the vendor list from the order list This patch is removing the use of GetBooksellersWithLateOrders and use the late order list to generate the vendors. Test plan: Create several vendors, several orders, close the baskets Also create vendors that do not have orders (or basket not closed) Go to the late orders page and confirm that the list of vendors is correctly filled, select one, you can see the "select all" link in the header of the table QA: that would be good to test this with production data and compare execution time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104255&action=edit Bug 25266: Remove C4::Bookseller This was the only occurrence of GetBooksellersWithLateOrders and it was the only subroutine of C4::Bookseller -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I went a completely different direction and removed the C4 subroutine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not sure it's the correctly fix, as the vendor list will not have all the vendors with late orders, but the vendors with late orders that match the existing filters (date/delay). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104255|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104257&action=edit Bug 25266: Remove C4::Bookseller This was the only occurrence of GetBooksellersWithLateOrders and it was the only subroutine of C4::Bookseller -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is something odd with this filter on 18.11 already. Without any filters I have late orders from 2 vendors showing, but only one of them shows in the filter list... so 18.11 might not be a good reference point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like I should know why this happens, but the tests fail rather spectactularly for me: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/Bookseller.t Cannot detect source of 't/Bookseller.t'! at /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 261. TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x55d019f812b8), TAP::Parser::Source=HASH(0x55d019f813a8)) called at /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 211 ... Also: Template process failed: undef error - The method Koha::Acquisition::Orders->size is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, second problem fixed by a restart all - looks much better on first glance, but will need a bit more testing. Could you check on the tests meanwhile? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #11)
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/Bookseller.t Cannot detect source of 't/Bookseller.t'! at
The test file (and the whole C4::Bookseller module) has been deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had a feeling it was too late yesterday to continue on this one, I will try again later! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In 17.11 the list is not 'all vendors', but it also seems to not be only vendors with late orders... I wonder if it's vendors with open baskets/orders. There is a lot of data in the db I checked, but samples seem to point that way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The last change made to this subroutine is commit b76eac9ca2c32a5db51b9b8ca32a2cf4fa6397b5 Bug 14535: Update the supplier filter too which is in 3.22, so I would not expect recent behaviour changes. The way it works, reading the code is: get the vendor which have orders not fully received yet (datereceived is null or quantityreceived < quantity) and the basket is closed. If delay is passed (>=0), then the devery time is taken into account and the date the basket has been closed is compared (now + delivery time >= close date). I don't think it makes sense to have 2 ways (especially if different) to get the "lates". If the order list is correctly generated, it makes sense to build the vendor list from it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree, it acts as a filter on the list, only offering what is IN the list makes a lot of sense. Especially since whe have some special libraries with a lot of vendors. Keeping the list sensibly short. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Template process failed: undef error - SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: Argument passed to the 'IN' operator can not be undefined at /home/vagrant/kohaclone/Koha/Objects.pm line 372 at /home/vagrant/kohaclone/C4/Templates.pm line 122 :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105321&action=edit Bug 25266: Fix error when no later order If no late order we got: "Argument passed to the 'IN' operator can not be undefined" It highlights a context error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104254|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105329&action=edit Bug 25266: Build the vendor list from the order list This patch is removing the use of GetBooksellersWithLateOrders and use the late order list to generate the vendors. Test plan: Create several vendors, several orders, close the baskets Also create vendors that do not have orders (or basket not closed) Go to the late orders page and confirm that the list of vendors is correctly filled, select one, you can see the "select all" link in the header of the table QA: that would be good to test this with production data and compare execution time. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104257|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105330&action=edit Bug 25266: Remove C4::Bookseller This was the only occurrence of GetBooksellersWithLateOrders and it was the only subroutine of C4::Bookseller Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105321|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105331&action=edit Bug 25266: Fix error when no later order If no late order we got: "Argument passed to the 'IN' operator can not be undefined" It highlights a context error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Works like a charm now, thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Status|Signed Off |Failed QA --- Comment #24 from Alex Arnaud <alex.arnaud@biblibre.com> --- Seems that @parameters variable is now useless in acqui/lateorders.pl: 126 my @parameters = ( $delay ); 127 push @parameters, $estimateddeliverydatefrom_dt 128 ? $estimateddeliverydatefrom_dt->ymd() 129 : undef; 130 131 push @parameters, $estimateddeliverydateto_dt 132 ? $estimateddeliverydateto_dt->ymd() 133 : undef; Also, you remove the file t/db_dependent/Bookseller.t. That file contains a lot of test that are not related to C4::Bookseller and GetBooksellersWithLateOrders (AddBookseller, DelBookseller, get bookseller etc...). Are you sure these tests exist elsewhere ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105592&action=edit Bug 25266: Remove uneeded var -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #24)
Seems that @parameters variable is now useless in acqui/lateorders.pl:
126 my @parameters = ( $delay ); 127 push @parameters, $estimateddeliverydatefrom_dt 128 ? $estimateddeliverydatefrom_dt->ymd() 129 : undef; 130 131 push @parameters, $estimateddeliverydateto_dt 132 ? $estimateddeliverydateto_dt->ymd() 133 : undef;
Indeed, fixed!
Also, you remove the file t/db_dependent/Bookseller.t. That file contains a lot of test that are not related to C4::Bookseller and GetBooksellersWithLateOrders (AddBookseller, DelBookseller, get bookseller etc...).
Are you sure these tests exist elsewhere ?
Those CRUD subroutines have been moved to Koha::Acquisition::Booksellers. The whole test file was there to test GetBooksellersWithLateOrders, and a left over of the previous subroutines. There is some tests in t/db_dependent/Koha/Acquisition/Booksellers.t, that's enough to test Koha::Acquisition::Booksellers (most of CRUD methods rely on highly tested Koha::Object[s] anyway). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105329|0 |1 is obsolete| | --- Comment #27 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 105621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105621&action=edit Bug 25266: Build the vendor list from the order list This patch is removing the use of GetBooksellersWithLateOrders and use the late order list to generate the vendors. Test plan: Create several vendors, several orders, close the baskets Also create vendors that do not have orders (or basket not closed) Go to the late orders page and confirm that the list of vendors is correctly filled, select one, you can see the "select all" link in the header of the table QA: that would be good to test this with production data and compare execution time. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105330|0 |1 is obsolete| | --- Comment #28 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 105622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105622&action=edit Bug 25266: Remove C4::Bookseller This was the only occurrence of GetBooksellersWithLateOrders and it was the only subroutine of C4::Bookseller Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105331|0 |1 is obsolete| | --- Comment #29 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 105623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105623&action=edit Bug 25266: Fix error when no later order If no late order we got: "Argument passed to the 'IN' operator can not be undefined" It highlights a context error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105592|0 |1 is obsolete| | --- Comment #30 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 105624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105624&action=edit Bug 25266: Remove uneeded var Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | --- Comment #32 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #33 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Does not apply cleanly on 19.11.x, please rebase if required on 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27102 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch@interleaf.ie --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 27102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org