https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #24)
Seems that @parameters variable is now useless in acqui/lateorders.pl:
126 my @parameters = ( $delay ); 127 push @parameters, $estimateddeliverydatefrom_dt 128 ? $estimateddeliverydatefrom_dt->ymd() 129 : undef; 130 131 push @parameters, $estimateddeliverydateto_dt 132 ? $estimateddeliverydateto_dt->ymd() 133 : undef;
Indeed, fixed!
Also, you remove the file t/db_dependent/Bookseller.t. That file contains a lot of test that are not related to C4::Bookseller and GetBooksellersWithLateOrders (AddBookseller, DelBookseller, get bookseller etc...).
Are you sure these tests exist elsewhere ?
Those CRUD subroutines have been moved to Koha::Acquisition::Booksellers. The whole test file was there to test GetBooksellersWithLateOrders, and a left over of the previous subroutines. There is some tests in t/db_dependent/Koha/Acquisition/Booksellers.t, that's enough to test Koha::Acquisition::Booksellers (most of CRUD methods rely on highly tested Koha::Object[s] anyway). -- You are receiving this mail because: You are watching all bug changes.