[Bug 8085] New: reserve slip should be hold slip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Priority: P5 - low Change sponsored?: --- Bug ID: 8085 Assignee: oleonard@myacpl.org Summary: reserve slip should be hold slip Severity: minor Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha We use the word Hold(s) throughout Koha, but the Notices & Slips tool lists the Holds Slip as Reserve Slip. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Notices Assignee|oleonard@myacpl.org |henridamien@koha-fr.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- The text comes from the database (letters.name), so this isn't a template bug. We'll have to revise the default data and update existing installations to correct the name. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- I'm not talking about RESERVESLIP - the code - I'm talking about the 'descriptive text' which also says Reserve. I know we can't change the DB easily. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- letters.name (the identifier in the Notices interface) = "Reserve Slip" and letters.title (the message subject) = "Reserve Slip." So two instances in the database need to be modified. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45075&action=edit Bug 9184: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|reserve slip should be hold |Rename 'Reserve slip' to |slip |'Hold slip' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45075|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45119&action=edit [SIGNED-OFF] Bug 9184: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. http://bugs.koha-community.org/show_bug.cgi?id=8085 Checked the working in system preferences and re-loaded notices from the updated English sample notices SQL. Changes look correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Don't you think we could update existing installations too? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I thought about it, but then opted for "no surprise". If you are used to edit the Reserve Slip it might be irritating to find it renamed... but I can certainly write a follow-up if you think. I'd check for "Reserve slip" in the description, because of possible translations then. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45352&action=edit Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have added another patch to update existing installations - please test and comment if you think if this change is useful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45352|0 |1 is obsolete| | --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45492&action=edit Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Job done on a Koha English version. It won't hurt other langages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45119|0 |1 is obsolete| | Attachment #45492|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45503&action=edit Bug 8085: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. Checked the working in system preferences and re-loaded notices from the updated English sample notices SQL. Changes look correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45504&action=edit Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Job done on a Koha English version. It won't hurt other langages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15443 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15443 [Bug 15443] Re-code RESERVESLIP as HOLD_SLIP -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org