[Bug 6810] New: Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Bug #: 6810 Summary: Send membership expiry reminder notices Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: savitra.sirohi@osslabs.biz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com A new crontab based perl script to send membership expiry reminders. A system preference controls the number of days in advance of membership expiry that the notices will be sent on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |amit.gupta@osslabs.biz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #1 from Amit Gupta <amit.gupta@osslabs.biz> 2011-09-09 07:41:56 UTC --- Created attachment 5375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5375 Membership expiry notice -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Rel_3_8 --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:16 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:51 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-20 20:55:18 UTC --- Hi Amit and Savitra, the way we handle system preferences has changed in 3.6. Only one change to a central systempreferences file is needed now. Can you please rework your patch and resubmit? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5375|0 |1 is obsolete| | --- Comment #5 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 9751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9751&action=edit Bug_6810 Send membership expiry reminder notices. A new crontab based perl script to send membership expiry reminders. A system preference controls the number of days in advance of membership expiry that the notices will be sent on. To Test: 1) Create a new Patron and set membership expiry date 14 days from the date of registration. 2) Check your systemprefence ( MemExpDayNotice to 14 days) 3) Manual testing Run ( perl membership_expiry.pl -h) It would give you various option: This script prepares for membership expiry reminders to be sent to patrons. It queues them in the message queue, which is processed by the process_message_queue.pl cronjob. See the comments in the script for directions on changing the script. This script has the following parameters : -c Confirm and remove this help & warning -n send No mail. Instead, all mail messages are printed on screen. Usefull for testing purposes. -v verbose Do you wish to continue? (y/n) 4) Choose option for ex: perl membership_expiry.pl -c 5) Go to your koha database and check message_queue table you see some results. 6) Run (perl process_message_queue.pl) it will send email to those patron whose membership after 14 days from today. 7) Cron testing: (10 1 * * * $KOHA_CRON_PATH/membership_expiry.pl -c) 8) Set your 15 * * * * $KOHA_CRON_PATH/process_message_queue.pl 9) After running membership_expiry.pl, (process_message_queue.pl will send emails to those patron whose membership after 14 days from today). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P4 Version|master |rel_3_10 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Irma Birchall <irma@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma@calyx.net.au Version|rel_3_10 |rel_3_8 --- Comment #6 from Irma Birchall <irma@calyx.net.au> --- Can't be tested in a sandbox as it needs command line access. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- It works as described. Few remarks: - A detailed description of the script operation and goals would help the documentation manager to do her job. - You should say that MEMEXP notification is used to prepare the email. - You should say that MemExpDaysNotice syspref specify the number of days before borrower registration expiration date the notification is sent. This is said in the syspref, but I'm not sure it's proper English. No being myself a native English speaker, I can't say if 'Send a membership expiry notice that a patron is about to expire after n days' is really the proper wording. - You should say that the script MUST be run once a day since the script send email for borrower whom registration expires exactly in x days. - I can imagine that libraries will want to send this notification once a week, or Monday and Thursday. I tend to think that a better approach is to work with interval of days, given to the script as arguments, so without syspref. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |amitddng135@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master Assignee|kohapatch@gmail.com |amitddng135@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9751|0 |1 is obsolete| | --- Comment #8 from Amit <amitddng135@gmail.com> --- Created attachment 21870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21870&action=edit Send membership expiry reminder notices. A new crontab based perl script to send membership expiry reminders. A system preference controls the number of days in advance of membership expiry that the notices will be sent on. To Test: 1) Create a new Patron and set membership expiry date 14 days from the date of registration. 2) Check your systemprefence ( MemExpDayNotice to 14 days default value) 3) Manual testing Run ( perl membership_expiry.pl -h) It would give you various option: This script prepares for membership expiry reminders to be sent to patrons. It queues them in the message queue, which is processed by the process_message_queue.pl cronjob. See the comments in the script for directions on changing the script. This script has the following parameters : -c Confirm and remove this help & warning -n send No mail. Instead, all mail messages are printed on screen. Usefull for testing purposes. -v verbose Do you wish to continue? (y/n) 4) Choose option for ex: perl membership_expiry.pl -c 5) Go to your koha database and check message_queue table you see some results. 6) Run (perl process_message_queue.pl) it will send email to those patron whose membership after 14 days from today. 7) Cron testing: (10 1 * * * $KOHA_CRON_PATH/membership_expiry.pl -c) 8) Set your 15 * * * * $KOHA_CRON_PATH/process_message_queue.pl 9) After running membership_expiry.pl, (process_message_queue.pl will send emails to those patron whose membership after 14 days from today). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #9 from Amit <amitddng135@gmail.com> --- Created attachment 21871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21871&action=edit Added new systempreference: Membership -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21871|0 |1 is obsolete| | --- Comment #10 from Amit <amitddng135@gmail.com> --- Created attachment 21872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21872&action=edit Added new systempreference: MembershipExpiryNotice Added new systempreference: MembershipExpiryNotice -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-28 last check this| | --- Comment #11 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 6810 Add new systempreference and sample notice (Membership Expiry notice) Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Patch failed at 0001 Bug 6810 Add new systempreference and sample notice (Membership Expiry notice) The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21872|0 |1 is obsolete| | --- Comment #12 from Amit <amitddng135@gmail.com> --- Created attachment 22459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22459&action=edit Added new systempreference: Membership Added new systempreference: Membership -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 nicolas <nicolas.bravais@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.bravais@gmail.com --- Comment #13 from nicolas <nicolas.bravais@gmail.com> --- The SysPref is present in the database (we looked for MembershipExpiryDaysNotice in PHPMyAdmin), but not in the Administration interface... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21870|0 |1 is patch| | Attachment #21870|application/mbox |text/plain mime type| | CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Looks OK at a glance, but the updatedatabase.pl is for Koha 3.13, so you'll want to update that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Based at least on comment 13 I think this should be marked as "Failed QA." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to nicolas from comment #13)
The SysPref is present in the database (we looked for MembershipExpiryDaysNotice in PHPMyAdmin), but not in the Administration interface...
Are you sure? Again, I haven't applied the actual patch, but it looks like it should be in the Patrons tab in the Global System Preferences. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 11548 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yhager@yhager.com --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12496 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #16)
(In reply to nicolas from comment #13)
The SysPref is present in the database (we looked for MembershipExpiryDaysNotice in PHPMyAdmin), but not in the Administration interface...
Are you sure? Again, I haven't applied the actual patch, but it looks like it should be in the Patrons tab in the Global System Preferences.
It is. Setting this back to "Needs signoff." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Owen Leonard <oleonard@myacpl.org> ---
5) Go to your koha database and check message_queue table you see some results.
I confirm that the correct message has been added to the queue, but it doesn't contain an email address in the to_address column. Checking membership_expiry.pl it looks like it doesn't pass a "to_address" at all: C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $recent->{'borrowernumber'}, from_address => $from_address, message_transport_type => 'email', } ); -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #20)
5) Go to your koha database and check message_queue table you see some results.
I confirm that the correct message has been added to the queue, but it doesn't contain an email address in the to_address column. Checking membership_expiry.pl it looks like it doesn't pass a "to_address" at all:
C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $recent->{'borrowernumber'}, from_address => $from_address, message_transport_type => 'email', } );
If I recall correctly, queued messages don't need a "to_address". When the message is being sent via process_message_queue.pl, it will lookup the email address using the borrowernumber and the "AutoEmailPrimaryAddress" system preference. Relevant subs are C4::Letters::SendQueuedMessages (in process_message_queue.pl), and C4::Members::GetNoticeEmailAddress (within the C4::Letters function calls). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- If you process the message queue, you'll notice that the to_address in the database is updated after the email is sent. C4::Letters::_send_message_by_email() and C4::Letters::_update_message_to_address() take care of that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21870|0 |1 is obsolete| | --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32683&action=edit [SIGNED-OFF] Bug-6810: Send membership expiry reminder notices. A new crontab based perl script to send membership expiry reminders. A system preference controls the number of days in advance of membership expiry that the notices will be sent on. To Test: 1) Create a new Patron and set membership expiry date 14 days from the date of registration. 2) Check your systemprefence ( MemExpDayNotice to 14 days default value) 3) Manual testing Run ( perl membership_expiry.pl -h) It would give you various option: This script prepares for membership expiry reminders to be sent to patrons. It queues them in the message queue, which is processed by the process_message_queue.pl cronjob. See the comments in the script for directions on changing the script. This script has the following parameters : -c Confirm and remove this help & warning -n send No mail. Instead, all mail messages are printed on screen. Useful for testing purposes. -v verbose Do you wish to continue? (y/n) 4) Choose option for ex: perl membership_expiry.pl -c 5) Go to your koha database and check message_queue table you see some results. 6) Run (perl process_message_queue.pl) it will send email to those patron whose membership after 14 days from today. 7) Cron testing: (10 1 * * * $KOHA_CRON_PATH/membership_expiry.pl -c) 8) Set your 15 * * * * $KOHA_CRON_PATH/process_message_queue.pl 9) After running membership_expiry.pl, (process_message_queue.pl will send emails to those patron whose membership after 14 days from today). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22459|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32684&action=edit [SIGNED-OFF] Bug 6810 Add new systempreference and sample notice (Membership Expiry notice) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested both patches according to the test plan and found no problems. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32684|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32689&action=edit Bug 6810 [Revised] Add new systempreference and sample notice (Membership Expiry notice) This updated version of the database update patch revises the description of the system preference and the content of the notice to use the phrase "account expiration" or "card expiration," both of which are currently used in Koha templates. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32689|0 |1 is obsolete| | --- Comment #26 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32692&action=edit Bug 6810 [Revised] Add new systempreference and sample notice (Membership Expiry notice) This updated version of the database update patch revises the description of the system preference and the content of the notice to use the phrase "account expiration" or "card expiration," both of which are currently used in Koha templates. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Amit, this is getting really close, but there are 2 things that should be fixed: - Can you please add the new sample notice to the non-English web-installers as well? The code is harcoded and that way it's easier for people to set up the new feature. Copying the English text is ok. - Can you please provide unit tests for the new routine GetUpcomingMembershipExpires? I'd like to see the cronjob being mentioned in the system preference, but that's not a blocker :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #28 from Amit <amitddng135@gmail.com> --- Hi Katrin, Thanks for your input will recreate with test cases and sample notices. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kmkale@anantcorp.com --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 6173 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33954&action=edit Bug 6810 [Sample notices follow-up] Send membership expiry reminder notices This patch adds the new sample notice (in English) to the non-English web installers so that it is available to users of non-English templates. This patch also corrects the SQL of the sample notice updates to reflect changes in the structure of the notices table. To test, apply the patch and test installation of Koha with a blank database. The installation process should correctly add sample notices, including the new MEMEXP notice. Test again using a different set of translations to confirm that non-English sample notices are working as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> ---
- Can you please add the new sample notice to the non-English web-installers as well?
I have added a patch for this because my library would really like to have this feature and I'd like to see progress on it.
- Can you please provide unit tests for the new routine GetUpcomingMembershipExpires?
Still waiting for this, so even if my new patch gets a signoff the bug should be set back to "Failed QA." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #32 from Amit <amitddng135@gmail.com> --- Hi Owen, I have written some test cases will share by this monday. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #33 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Amit from comment #32)
Hi Owen,
I have written some test cases will share by this monday. Up, have you these tests ?
-- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13889 --- Comment #34 from Marc Véron <veron@veron.ch> --- The cron script would need a follow-up to for logging to the system log table, see Bug 13889 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch set needs tests and a small follow up for the new cronjobs log. Setting status to failed QA. I think this would be a useful feature, please rescue it! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #36 from Amit <amitddng135@gmail.com> --- Hi Kartin, Will resend with test cases. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #37 from M. Tompsett <mtompset@hotmail.com> --- Patch does not apply. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #38 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 32683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32683 [SIGNED-OFF] Bug-6810: Send membership expiry reminder notices. Review of attachment 32683: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6810&attachment=32683) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +611,5 @@
+ Add_Delta_Days( @dateexpiry,0) + ), + 'iso' + )->output(); + }
There is no better way to format $values->{'dateexpiry'} from SQL to whatever the system preference format string is?! This is ugly. There has got to be a better way. ::: C4/Members.pm @@ +1561,5 @@
+ SELECT borrowers.*, categories.description, + branches.branchname, branches.branchemail FROM borrowers + LEFT JOIN branches on borrowers.branchcode = branches.branchcode + LEFT JOIN categories on borrowers.categorycode = categories.categorycode + WHERE dateexpiry = DATE_ADD(CURDATE(),INTERVAL $days DAY);
Do the date math in Perl to avoid MySQLisms. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #39 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 32692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32692 Bug 6810 [Revised] Add new systempreference and sample notice (Membership Expiry notice) Review of attachment 32692: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6810&attachment=32692) ----------------------------------------------------------------- ::: installer/data/mysql/sysprefs.sql @@ +455,4 @@
('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), ('yuipath','local','local|http://yui.yahooapis.com/2.5.1/build','Insert the path to YUI libraries, choose local if you use koha offline','Choice'), ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'); \ No newline at end of file
This change is not necessary. ::: installer/data/mysql/updatedatabase.pl @@ +8845,4 @@
SetVersion ($DBversion); }
+$DBversion = "3.17.00.XXX";
Might want to convert this updatedatabase.pl to an atomic update. http://wiki.koha-community.org/wiki/Database_updates Or at least change the number to 21 instead of 17. :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|amitddng135@gmail.com |alex.arnaud@biblibre.com CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32692|0 |1 is obsolete| | Attachment #33954|0 |1 is obsolete| | --- Comment #40 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40090&action=edit Bug 6810 - Add new systempreference (MembershipExpiryDaysNotice) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #41 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40091&action=edit Bug 6810 - Add sample notices -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #42 from Alex Arnaud <alex.arnaud@biblibre.com> --- Rebased the patches and replaced those which add sample notices and those which add syspref (using now atomic update). For the next step i will fix M. Tompsett QA comments and try to add test. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Alex++ :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #44 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40100&action=edit [follow-up] Bug 6810 - Fix QA failures - Use KohaDates to convert dateexpiry - remove MYSQL specifics methods for date handling in GetUpcomingMembershipExpires - make the script membership_expiry.pl write in Koha system logs - add tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40090|0 |1 is obsolete| | --- Comment #45 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40120&action=edit Bug 6810 - Add new systempreference (MembershipExpiryDaysNotice) Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40091|0 |1 is obsolete| | --- Comment #46 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40121&action=edit Bug 6810 - Add sample notices Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40100|0 |1 is obsolete| | --- Comment #47 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40122&action=edit Bug 6810 - Fix QA failures - Use KohaDates to convert dateexpiry - remove MYSQL specifics methods for date handling in GetUpcomingMembershipExpires - make the script membership_expiry.pl write in Koha system logs - add tests Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 40122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40122 Bug 6810 - Fix QA failures Review of attachment 40122: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6810&attachment=40122) ----------------------------------------------------------------- The tests file is db dependent. ::: C4/Letters.pm @@ +35,4 @@
use Encode; use Carp; use Koha::Email; +use Koha::Template::Plugin::KohaDates;
No, you should not use Koha::Template::Plugin outside templates. Use Koha::DateUtils. ::: t/Members.t @@ +40,5 @@
+ ); + +}); + +t::lib::Mocks::mock_preference('MembershipExpiryDaysNotice', 15);
Please add tests with MembershipExpiryDaysNotice equals 0 or undef. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|alex.arnaud@biblibre.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #49 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40179&action=edit [Followup-up] Bug 6810 - Fix QA failures: - use Koha::DateUtils instead of Koha::Template::Plugin::KohaDates, - Add test with syspref MembershipExpiryDaysNotice equals 0 and undef, - fix (new) test failure (when MembershipExpiryDaysNotice is undef). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40179|0 |1 is obsolete| | --- Comment #50 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 40180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40180&action=edit Bug 6810 - Fix QA failures: - use Koha::DateUtils instead of Koha::Template::Plugin::KohaDates, - Add test with syspref MembershipExpiryDaysNotice equals 0 and undef, - fix (new) test failure (when MembershipExpiryDaysNotice is undef). Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #51 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- A syspref again :( We could give the period as argument of script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A command line option is a disavantage for package installations with multiple instances, but also for small libraries. If it's a pref, any librarian can change it, but if it's a command line option, only an IT person can. I am in favour of prefs in general. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #53 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #52)
A command line option is a disavantage for package installations with multiple instances, but also for small libraries. If it's a pref, any librarian can change it, but if it's a command line option, only an IT person can. I am in favour of prefs in general.
If it's a small library, the librarian is the IT person. That being said, there is nothing stopping it from being both. That gives the geeky IT people the ability to not change any settings in the system, and it gives the library people the ability to actually do it themselves (and totally mess up the geeky IT people's work). We have had code in Koha where a command line was overridden by environment variables. We could easily use the same kind of logic and have system preferences override/augment command-line options. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not a fan of the override idea. I think either/or. I think otherwise it's just confusing things unnecessarily. This is a new feature, so we don't need to retain old behaviour. I also disagree about the IT person being the same thing as the librarian for small library - it might also be a volunteer who set up the system and is no longer available or it might just be a hosted solution. The range is wide. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #55 from Mirko Tietgen <mirko@abunchofthings.net> --- I agree with Katrin. I don't think the assumption that the librarian is an/the IT person is necessarily correct for small libraries. And this setting is nothing that IT would decide, but a librarian, so it should be available to them, even though the amount of sysprefs is getting more and more overwhelming. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #56 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Mirko Tietgen from comment #55)
I agree with Katrin. I don't think the assumption that the librarian is an/the IT person is necessarily correct for small libraries.
Depends largely on the geography concerned. For instance in most Indian libraries, the Librarian *is* the de-facto IT person. whatever they have the skills for its or not is a moot point. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #57 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #54)
I am not a fan of the override idea. I think either/or. I think otherwise it's just confusing things unnecessarily. This is a new feature, so we don't need to retain old behaviour.
Okay. I was just throwing out a brainstorm idea.
I also disagree about the IT person being the same thing as the librarian for small library - it might also be a volunteer who set up the system and is no longer available
-- thus left the IT responsibilities on the librarian.
or it might just be a hosted solution.
*laugh* No, because it's a small library with no budget. This is why I said the librarian is the IT person. Doesn't mean they know how to do it, but they are responsible for it. Mirko wrote:
though the amount of sysprefs is getting more and more overwhelming.
AMEN! Though, the advantage is they have a chance of being better documented than config file parameters. ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- 1/ + my $dateexpiry = DateTime->now()->add(days => $days)->ymd(); You should use Koha::DateUtils->dt_from_string; to take the tz into account. 2/ The letter.code field is a varchar(20), I am sure you can find something more meaningful than "MEMEXP". 3/ The file installer/data/mysql/sysprefs.sql should be kept ordered. Don't put your line at the end of the file. 4/ The cronjob: a. No need to warn, prefer say b. use Modern::Perl; c. a cronjob should not be interactive. d. use Pod2usage for the usage (see other scripts). 5/ The letter: Are you sure that only information from the borrowers table is useful? It would be good to have info from the branches table, as a minimum. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|alex.arnaud@biblibre.com |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #59 from Amit <amitddng135@gmail.com> --- Created attachment 40641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40641&action=edit Bug 6810 - Fix QA failures Bug 6810 - Fix QA failures - remove DateTime->now() - use Koha::DateUtils->dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #60 from Amit <amitddng135@gmail.com> --- Created attachment 40642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40642&action=edit Bug 6810 - Fix QA failures MembershipExpiryDaysNotice system preferences arragned alphabetical order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #61 from Amit <amitddng135@gmail.com> --- Created attachment 40643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40643&action=edit Bug 6810 - Fix QA failures Change letter code from MEMEXP to MEMBERSHIP_EXPIRY add <<branches.branchname>> in letter -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40641|0 |1 is obsolete| | Attachment #40642|0 |1 is obsolete| | Attachment #40643|0 |1 is obsolete| | --- Comment #62 from Amit <amitddng135@gmail.com> --- Created attachment 40644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40644&action=edit Bug 6810 - Fix QA failures - remove DateTime->now() - use Koha::DateUtils->dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #63 from Amit <amitddng135@gmail.com> --- Created attachment 40645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40645&action=edit Bug 6810 - Fix QA failures MembershipExpiryDaysNotice system preferences arragned alphabetical order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #64 from Amit <amitddng135@gmail.com> --- Created attachment 40646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40646&action=edit Bug 6810 - Fix QA failures Change letter code from MEMEXP to MEMBERSHIP_EXPIRY add branches table <<branches.branchname>> in letter -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40121|0 |1 is obsolete| | Attachment #40646|0 |1 is obsolete| | --- Comment #65 from Amit <amitddng135@gmail.com> --- Created attachment 40649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40649&action=edit Bug-6810-Add-sample-notices Add Sample notices -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32683|0 |1 is obsolete| | --- Comment #66 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40665&action=edit [SIGNED-OFF] Bug-6810: Send membership expiry reminder notices. A new crontab based perl script to send membership expiry reminders. A system preference controls the number of days in advance of membership expiry that the notices will be sent on. To Test: 1) Create a new Patron and set membership expiry date 14 days from the date of registration. 2) Check your systemprefence ( MemExpDayNotice to 14 days default value) 3) Manual testing Run ( perl membership_expiry.pl -h) It would give you various option: This script prepares for membership expiry reminders to be sent to patrons. It queues them in the message queue, which is processed by the process_message_queue.pl cronjob. See the comments in the script for directions on changing the script. This script has the following parameters : -c Confirm and remove this help & warning -n send No mail. Instead, all mail messages are printed on screen. Useful for testing purposes. -v verbose Do you wish to continue? (y/n) 4) Choose option for ex: perl membership_expiry.pl -c 5) Go to your koha database and check message_queue table you see some results. 6) Run (perl process_message_queue.pl) it will send email to those patron whose membership after 14 days from today. 7) Cron testing: (10 1 * * * $KOHA_CRON_PATH/membership_expiry.pl -c) 8) Set your 15 * * * * $KOHA_CRON_PATH/process_message_queue.pl 9) After running membership_expiry.pl, (process_message_queue.pl will send emails to those patron whose membership after 14 days from today). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40120|0 |1 is obsolete| | Attachment #40122|0 |1 is obsolete| | Attachment #40180|0 |1 is obsolete| | --- Comment #67 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40666&action=edit Bug 6810: [SIGNED-OFF] Squashed Alex Arnaud's patches The following three patches were already signed off by Indranil and authored by Alex, so I squashed them for simplicity. -- Mark Tompsett Bug 6810 - Add new systempreference (MembershipExpiryDaysNotice) Bug 6810 - Fix QA failures - Use KohaDates to convert dateexpiry - remove MYSQL specifics methods for date handling in GetUpcomingMembershipExpires - make the script membership_expiry.pl write in Koha system logs - add tests Bug 6810 - Fix QA failures: - use Koha::DateUtils instead of Koha::Template::Plugin::KohaDates, - Add test with syspref MembershipExpiryDaysNotice equals 0 and undef, - fix (new) test failure (when MembershipExpiryDaysNotice is undef). Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40644|0 |1 is obsolete| | Attachment #40645|0 |1 is obsolete| | Attachment #40649|0 |1 is obsolete| | --- Comment #68 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40667&action=edit Bug 6810: Squashed Amit Gupta's patches Amit added these fixes which were not signed off yet, so I squashed them for simplicity. -- Mark Tompsett Bug 6810 - Fix QA failures - remove DateTime->now() - use Koha::DateUtils->dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY Bug 6810 - Fix QA failures - MembershipExpiryDaysNotice system preferences arragned alphabetical order. Bug 6810 - Add sample notices -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mirko@abunchofthings.net | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #69 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 40667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40667 Bug 6810: Squashed Amit Gupta's patches Review of attachment 40667: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6810&attachment=40667) ----------------------------------------------------------------- ::: C4/Members.pm @@ +42,4 @@
use Koha::AuthUtils qw(hash_password); use Koha::Database; use Module::Load; +use DateTime::Duration;
Why make it more complex here... @@ +1491,4 @@
sub GetUpcomingMembershipExpires { my $dbh = C4::Context->dbh; + my $days = DateTime::Duration->new(days => C4::Context->preference("MembershipExpiryDaysNotice") || 0);
and here... @@ +1491,5 @@
sub GetUpcomingMembershipExpires { my $dbh = C4::Context->dbh; + my $days = DateTime::Duration->new(days => C4::Context->preference("MembershipExpiryDaysNotice") || 0); + my $dateexpiry = output_pref({ dt => (dt_from_string() + $days), dateformat => 'iso', dateonly => 1 });
-- Why not keep the ->add(days => $days): my $dateexpiry = output_pref({ dt => (dt_from_string()->add( days => $days)), dateformat => 'iso', dateonly => 1 }); -- dt_from_string passes back a DateTime object, just like DateTime->now(). -- Though, this gives me an idea to improve one of my patches. DOH! @@ -1489,5 @@
sub GetUpcomingMembershipExpires { my $dbh = C4::Context->dbh; - my $days = C4::Context->preference("MembershipExpiryDaysNotice") || 0; - my $dateexpiry = DateTime->now()->add(days => $days)->ymd();
... if the ->add(days => $days) part was working here? ::: installer/data/mysql/de-DE/mandatory/sample_notices.sql @@ +136,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) +VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Benachrichtigung bei Zugang', 'Bestelltes Medium ist eingetroffen', 'Liebe/r <<borrowers.firstname>> <<borrowers.surname>>,\n\nDie Bestellung <<aqorders.ordernumber>> (<<biblio.title>>) ist eingetroffen und wird bearbeitet.\n\nIhr Bibliotheksteam', 'email'); + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
Why did you exclude the message_transport_type? Plus, if you added is_html to the INSERT above this one (and added the appropriate default value of 0 in the VALUES list), you could have used commas, instead of a whole new INSERT. ::: installer/data/mysql/en/mandatory/sample_notices.sql @@ +155,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on receiving', 'Order received', 'Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\n The order <<aqorders.ordernumber>> (<<biblio.title>>) has been received.\n\nYour library.', 'email') + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above. ::: installer/data/mysql/es-ES/mandatory/sample_notices.sql @@ +150,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) +VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on receiving', 'Order received', 'Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\n The order <<aqorders.ordernumber>> (<<biblio.title>>) has been received.\n\nYour library.', 'email'); + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above. ::: installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql @@ +151,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) +VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on receiving', 'Order received', 'Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\n The order <<aqorders.ordernumber>> (<<biblio.title>>) has been received.\n\nYour library.', 'email'); + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above. ::: installer/data/mysql/it-IT/necessari/notices.sql @@ +148,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) +VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on receiving', 'Order received', 'Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\n The order <<aqorders.ordernumber>> (<<biblio.title>>) has been received.\n\nYour library.', 'email'); + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above. ::: installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql @@ +170,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) +VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on receiving', 'Order received', 'Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\n The order <<aqorders.ordernumber>> (<<biblio.title>>) has been received.\n\nYour library.', 'email'); + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above. ::: installer/data/mysql/pl-PL/mandatory/sample_notices.sql @@ +148,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) +VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on receiving', 'Order received', 'Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\n The order <<aqorders.ordernumber>> (<<biblio.title>>) has been received.\n\nYour library.', 'email'); + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above. ::: installer/data/mysql/ru-RU/mandatory/sample_notices.sql @@ +150,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) +VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on receiving', 'Order received', 'Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\n The order <<aqorders.ordernumber>> (<<biblio.title>>) has been received.\n\nYour library.', 'email'); + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above. ::: installer/data/mysql/uk-UA/mandatory/sample_notices.sql @@ +149,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content, message_transport_type) +VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on receiving', 'Order received', 'Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\n The order <<aqorders.ordernumber>> (<<biblio.title>>) has been received.\n\nYour library.', 'email'); + +INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above. ::: misc/cronjobs/membership_expiry.pl @@ +30,5 @@
+0 1 * * * membership_expiry.pl -c + +=head1 DESCRIPTION + +This script send memberships expires reminder notices to be sent to
This script sends membership expiry reminder notices to patrons. @@ +31,5 @@
+ +=head1 DESCRIPTION + +This script send memberships expires reminder notices to be sent to +patrons. It queues them in the message queue, which is processed by
It queues them in the message queue, which is processed by -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40666|0 |1 is obsolete| | Attachment #40667|0 |1 is obsolete| | --- Comment #70 from Amit <amitddng135@gmail.com> --- Created attachment 40685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40685&action=edit Bug 6810 - Add new systempreference (MembershipExpiryDaysNotice) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #71 from Amit <amitddng135@gmail.com> --- Created attachment 40686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40686&action=edit Bug 6810 - Fix QA failures -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #72 from Amit <amitddng135@gmail.com> --- Created attachment 40687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40687&action=edit Bug 6810 - Fix QA failures -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #73 from Amit <amitddng135@gmail.com> --- Created attachment 40688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40688&action=edit Bug 6810 - Fix QA failures - remove DateTime->now() - use Koha::DateUtils->dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY - review comments implemented -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #74 from Amit <amitddng135@gmail.com> --- Created attachment 40689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40689&action=edit Bug 6810 - Fix QA failures MembershipExpiryDaysNotice system preferences arragned alphabetical order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #75 from Amit <amitddng135@gmail.com> --- Created attachment 40690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40690&action=edit Bug-6810-Add-sample-notices Review comments implemented -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset@hotmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40685|0 |1 is obsolete| | Attachment #40686|0 |1 is obsolete| | Attachment #40687|0 |1 is obsolete| | Attachment #40688|0 |1 is obsolete| | Attachment #40689|0 |1 is obsolete| | Attachment #40690|0 |1 is obsolete| | --- Comment #76 from Amit <amitddng135@gmail.com> --- Created attachment 40700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40700&action=edit Bug 6810: [SIGNED-OFF] Squashed Alex Arnaud's patches The following three patches already signed off by Indranil and authored by Alex, so I squashed them for simplicity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #77 from Amit <amitddng135@gmail.com> --- Created attachment 40701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40701&action=edit Bug 6810: Squashed Fixes QA failures Bug 6810 - Fix QA failures -- Squashed three patches for simplicity -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #78 from Jonathan Druart <jonathan.druart@biblibre.com> --- FAIL C4/Members.pm OK critic FAIL forbidden patterns forbidden pattern: trailing space char (line 1493) OK pod OK spelling OK valid FAIL misc/cronjobs/membership_expiry.pl OK critic FAIL forbidden patterns forbidden pattern: trailing space char (line 172) forbidden pattern: trailing space char (line 226) forbidden pattern: trailing space char (line 121) forbidden pattern: trailing space char (line 36) forbidden pattern: trailing space char (line 156) forbidden pattern: trailing space char (line 176) forbidden pattern: trailing space char (line 115) FAIL pod *** ERROR: Apparent command =cut not preceded by blank line in file misc/cronjobs/membership_expiry.pl FAIL spelling Usefull ==> Useful OK valid Please run the qa script before submitting patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40701|0 |1 is obsolete| | --- Comment #79 from Amit <amitddng135@gmail.com> --- Created attachment 40766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40766&action=edit Bug 6810: Squashed Fixes QA failures QA script result: Processing files before patches |========================>| 5 / 5 (100.00%) Processing files after patches |========================>| 5 / 5 (100.00%) OK C4/Members.pm OK critic OK forbidden patterns OK pod OK spelling OK valid OK misc/cronjobs/membership_expiry.pl OK critic OK forbidden patterns OK pod OK spelling 0 OK valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #80 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 41916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41916&action=edit Bug 6810 - Fix QA failures - remove DateTime->now() - use Koha::DateUtils->dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY - review comments implemented - fix qa script comments Bug 6810 - Fix QA failures - MembershipExpiryDaysNotice system preferences arragned alphabetical order. Bug 6810 - Add sample notices - review comments implemented - default value of is_html field in letter table is 0 Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #81 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this one -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14834 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #82 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42609&action=edit Bug-6810: Send membership expiry reminder notices. A new crontab based perl script to send membership expiry reminders. A system preference controls the number of days in advance of membership expiry that the notices will be sent on. To Test: 1) Create a new Patron and set membership expiry date 14 days from the date of registration. 2) Check your systemprefence ( MemExpDayNotice to 14 days default value) 3) Manual testing Run ( perl membership_expiry.pl -h) It would give you various option: This script prepares for membership expiry reminders to be sent to patrons. It queues them in the message queue, which is processed by the process_message_queue.pl cronjob. See the comments in the script for directions on changing the script. This script has the following parameters : -c Confirm and remove this help & warning -n send No mail. Instead, all mail messages are printed on screen. Useful for testing purposes. -v verbose Do you wish to continue? (y/n) 4) Choose option for ex: perl membership_expiry.pl -c 5) Go to your koha database and check message_queue table you see some results. 6) Run (perl process_message_queue.pl) it will send email to those patron whose membership after 14 days from today. 7) Cron testing: (10 1 * * * $KOHA_CRON_PATH/membership_expiry.pl -c) 8) Set your 15 * * * * $KOHA_CRON_PATH/process_message_queue.pl 9) After running membership_expiry.pl, (process_message_queue.pl will send emails to those patron whose membership after 14 days from today). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #83 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42610&action=edit Bug 6810 - Add new systempreference (MembershipExpiryDaysNotice) Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Bug 6810 - Fix QA failures - Use KohaDates to convert dateexpiry - remove MYSQL specifics methods for date handling in GetUpcomingMembershipExpires - make the script membership_expiry.pl write in Koha system logs - add tests Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Bug 6810 - Fix QA failures: - use Koha::DateUtils instead of Koha::Template::Plugin::KohaDates, - Add test with syspref MembershipExpiryDaysNotice equals 0 and undef, - fix (new) test failure (when MembershipExpiryDaysNotice is undef). Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41916|0 |1 is obsolete| | --- Comment #84 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42611&action=edit Bug 6810 - Fix QA failures - remove DateTime->now() - use Koha::DateUtils->dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY - review comments implemented - fix qa script comments Bug 6810 - Fix QA failures - MembershipExpiryDaysNotice system preferences arragned alphabetical order. Bug 6810 - Add sample notices - review comments implemented - default value of is_html field in letter table is 0 Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #85 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42612&action=edit Bug 6810: [QA Follow-up] Move test file to db_dependent Note that this was already mentioned by Jonathan on comment48. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #86 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42613&action=edit Bug 6810: [QA Follow-up] Some minor tidying up of cron script Moved some POD lines and removed some duplicated POD lines. Corrected some indentation. Did some minor spelling changes, rewording. Removed the C4::Dates module. No longer needed. Removed a label in front of the for statement. Removed the Do you wish to continue-code. Should not be in a cron job. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40700|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #87 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Nice feature, has been pending for quite some time. As you see, I added two minor follow-ups. One moved the test file and the other is merely cosmetic (moving spaces around and so :) Note that the notice text might still need some attention: === Dear Test02, Your library card will expire soon, on: 30/09/2015 00:00 Thank you, Librarian === A report that has been pushed (yes today), can eliminate the hours and minutes for you. See bug 13622; it adds the possibility of a filter dateonly. I would prefer to see the lines combined: Your card will expire on 30/09/2015. Librarian should probably be Your library (see other notices). No blocker, but maybe a quick qa follow-up or opening a new report can still improve this. (Final word for the RM :) Another point: With reference to comment7 it would be handy to have an option to include expires within a range of days. You could run it weekly or rerun it etc. I have opened a followup report under bug 14834. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #88 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And for the record: We should still add this new cron job to the example file and somewhere commented in a cron file for the packages.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14840 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14834 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 [Bug 14834] Add a range parameter (in days) to membership_expiry cronjob -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #89 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42700&action=edit Bug 6810: [QA Follow-up] Exit cronjob if pref not set As per suggestion of Robin on report 14840, it would be better to always run the cronjob and only do something when the pref is set. This patch adds a test in the cronjob and clears the former default of 14 days. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Removed the pref and ran the dbrev again: Fine. Run the cronjob with -c -v -n: Prints exit warning. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14840 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14840 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 [Bug 14840] Added new cron script send membership expiry reminder notices in crontab.example file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #90 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Amit, Alex and Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 42609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42609 Bug-6810: Send membership expiry reminder notices. Review of attachment 42609: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6810&attachment=42609) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +800,5 @@
+ if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){ + my @dateexpiry = split /-/, $values->{'dateexpiry'}; + + $values->{'dateexpiry'} = C4::Dates->new(
This was not really kind of Marc. He is trying to remove the C4::Dates usage. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #92 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #91)
Comment on attachment 42609 [details] [review] Bug-6810: Send membership expiry reminder notices.
Review of attachment 42609 [details] [review]: -----------------------------------------------------------------
::: C4/Letters.pm @@ +800,5 @@
+ if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){ + my @dateexpiry = split /-/, $values->{'dateexpiry'}; + + $values->{'dateexpiry'} = C4::Dates->new(
This was not really kind of Marc. He is trying to remove the C4::Dates usage.
Ooops, sorry, removed by next patch!! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15429 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429 [Bug 15429] sub _parseletter should not change referenced values -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org