[Bug 37211] New: All notes in the patron Transactions table should be editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Bug ID: 37211 Summary: All notes in the patron Transactions table should be editable Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 23674 will add the ability to have a note on the transaction table in a patron account. This enhancement will make each of those notes editable after they have been submitted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 [Bug 23674] Allowing notes on all entries in patron Transactions table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #1 from Sam Lau <samalau@gmail.com> --- Created attachment 168211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168211&action=edit Bug 37211: Make notes in patron transactions table editable This patch adds an edit button to each notes field in an accountline entry. This feature is controlled by a new staff permision under the 'updatecharges' permision called 'edit_notes'. To test: 1) Apply patch, updatedatabase, restart_all 2) In the staff interface, give your logged in user superlibrarian permissions. 3) Visit a patron's accounting tab. Create a manual invoice for some amount and enter a note. 4) Create another manual invoice, this time do not enter a note. 5) Click on the transactions tab to view the table. 6) See that the notes column now has edit buttons. 7) Attempt to edit the note that is not blank. 8) A modal should pop up prompting you to edit your note. The previous note should be in the text box. 9) Edit this note and press confirm. 10) Ensure the note was updated and the updated column was filled with the correct time. 11) Now attempt to edit the blank note. 12) Again, you should see a modal but no prefilled message. Update this note and ensure correct changes. 13) Go back to the permissions for your logged in user and remove the 'edit_notes' subpermission under the 'updatecharges' permissions. 14) Go back to the patron's accounting tab. This time, there should not be any edit buttons in the notes column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 168212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168212&action=edit Bug 37211: Add new subpermission in updatecharge 'edit_notes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |roman.dolny@jezuici.pl --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Applying: Bug 37211: Make notes in patron transactions table editable error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt). error: could not build fake ancestor Patch failed at 0001 Bug 37211: Make notes in patron transactions table editable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168211|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 170002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170002&action=edit Bug 37211: Make notes in patron transactions table editable This patch adds an edit button to each notes field in an accountline entry. This feature is controlled by a new staff permision under the 'updatecharges' permision called 'edit_notes'. To test: 1) Apply patch, updatedatabase, restart_all 2) In the staff interface, give your logged in user superlibrarian permissions. 3) Visit a patron's accounting tab. Create a manual invoice for some amount and enter a note. 4) Create another manual invoice, this time do not enter a note. 5) Click on the transactions tab to view the table. 6) See that the notes column now has edit buttons. 7) Attempt to edit the note that is not blank. 8) A modal should pop up prompting you to edit your note. The previous note should be in the text box. 9) Edit this note and press confirm. 10) Ensure the note was updated and the updated column was filled with the correct time. 11) Now attempt to edit the blank note. 12) Again, you should see a modal but no prefilled message. Update this note and ensure correct changes. 13) Go back to the permissions for your logged in user and remove the 'edit_notes' subpermission under the 'updatecharges' permissions. 14) Go back to the patron's accounting tab. This time, there should not be any edit buttons in the notes column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168212|0 |1 is obsolete| | --- Comment #5 from Sam Lau <samalau@gmail.com> --- Created attachment 170003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170003&action=edit Bug 37211: Add new subpermission in updatecharge 'edit_notes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cubingguy714@gmail.com --- Comment #6 from Eric Garcia <cubingguy714@gmail.com> --- Applying: Bug 37211: Add new subpermission in updatecharge 'edit_notes' error: sha1 information is lacking or useless (installer/data/mysql/mandatory/userpermissions.sql). error: could not build fake ancestor Patch failed at 0001 Bug 37211: Add new subpermission in updatecharge 'edit_notes' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #7 from Sam Lau <samalau@gmail.com> --- (In reply to Eric Garcia from comment #6)
Applying: Bug 37211: Add new subpermission in updatecharge 'edit_notes' error: sha1 information is lacking or useless (installer/data/mysql/mandatory/userpermissions.sql). error: could not build fake ancestor Patch failed at 0001 Bug 37211: Add new subpermission in updatecharge 'edit_notes'
I'm not getting this... maybe try a 'git pull'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170002|0 |1 is obsolete| | Attachment #170003|0 |1 is obsolete| | --- Comment #8 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 170218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170218&action=edit Bug 37211: Make notes in patron transactions table editable This patch adds an edit button to each notes field in an accountline entry. This feature is controlled by a new staff permision under the 'updatecharges' permision called 'edit_notes'. To test: 1) Apply patch, updatedatabase, restart_all 2) In the staff interface, give your logged in user superlibrarian permissions. 3) Visit a patron's accounting tab. Create a manual invoice for some amount and enter a note. 4) Create another manual invoice, this time do not enter a note. 5) Click on the transactions tab to view the table. 6) See that the notes column now has edit buttons. 7) Attempt to edit the note that is not blank. 8) A modal should pop up prompting you to edit your note. The previous note should be in the text box. 9) Edit this note and press confirm. 10) Ensure the note was updated and the updated column was filled with the correct time. 11) Now attempt to edit the blank note. 12) Again, you should see a modal but no prefilled message. Update this note and ensure correct changes. 13) Go back to the permissions for your logged in user and remove the 'edit_notes' subpermission under the 'updatecharges' permissions. 14) Go back to the patron's accounting tab. This time, there should not be any edit buttons in the notes column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #9 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 170219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170219&action=edit Bug 37211: Add new subpermission in updatecharge 'edit_notes' Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38843 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Comment on attachment 170218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170218 Bug 37211: Make notes in patron transactions table editable Review of attachment 170218: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37211&attachment=170218) ----------------------------------------------------------------- ::: members/boraccount.pl @@ +235,5 @@
+ sub { + # Update the note and date in the account line + $payment->set( + { + date => \'NOW()',
I'm not sure we should be updating the date here... we have a timestamp field in the accountlines table that already updates on any change to the accountline.. the date field is meant for recording when the accountline was created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177244&action=edit Bug 37211: (QA follow-up) Don't reset creation date on update We shouldn't be resetting an accountlines creation date when we update the associated note. We have 'timestamp' for updates already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177245&action=edit Bug 37211: (QA follow-up) Update database update to be idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170218|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177248&action=edit Bug 37211: Make notes in patron transactions table editable This patch adds an edit button to each notes field in an accountline entry. This feature is controlled by a new staff permision under the 'updatecharges' permision called 'edit_notes'. To test: 1) Apply patch, updatedatabase, restart_all 2) In the staff interface, give your logged in user superlibrarian permissions. 3) Visit a patron's accounting tab. Create a manual invoice for some amount and enter a note. 4) Create another manual invoice, this time do not enter a note. 5) Click on the transactions tab to view the table. 6) See that the notes column now has edit buttons. 7) Attempt to edit the note that is not blank. 8) A modal should pop up prompting you to edit your note. The previous note should be in the text box. 9) Edit this note and press confirm. 10) Ensure the note was updated and the updated column was filled with the correct time. 11) Now attempt to edit the blank note. 12) Again, you should see a modal but no prefilled message. Update this note and ensure correct changes. 13) Go back to the permissions for your logged in user and remove the 'edit_notes' subpermission under the 'updatecharges' permissions. 14) Go back to the patron's accounting tab. This time, there should not be any edit buttons in the notes column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170219|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177249&action=edit Bug 37211: Add new subpermission in updatecharge 'edit_notes' Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177244|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177250&action=edit Bug 37211: (QA follow-up) Don't reset creation date on update We shouldn't be resetting an accountlines creation date when we update the associated note. We have 'timestamp' for updates already. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177245|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177251&action=edit Bug 37211: (QA follow-up) Update database update to be idempotent Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 177252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177252&action=edit Bug 37211: (QA follow-up) Update for bootstrap5 and remove copy/paste There were some unneeded data elements being passed around and we also needed to update from data- to data-bs- in places to get the modals working again. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I did some required follow-ups here to get it over the line. Last comment is that I'm not sure about the styling/placement of the edit button... but I'm sure someone clever will come along and help clean that up so I'm not going to block the feature here. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #19 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 177261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177261&action=edit Bug 37211: (QA follow-up) Make note edit button styles less intrusive, align To override the padding on .btn-xs I had to inline style="padding: 0;", it would be nice to have inline-btn variants (that come without padding or margin) for datatables because this is probably a common problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|samalau@gmail.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177250|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177248|0 |1 is obsolete| | --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179178&action=edit Bug 37211: Make notes in patron transactions table editable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177249|0 |1 is obsolete| | --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179179&action=edit Bug 37211: Add new subpermission in updatecharge 'edit_notes' Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177251|0 |1 is obsolete| | --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179180&action=edit Bug 37211: (QA follow-up) Update database update to be idempotent Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177252|0 |1 is obsolete| | --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179181&action=edit Bug 37211: (QA follow-up) Update for bootstrap5 and remove copy/paste -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177261|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- rebased patches for current main. Paul, I like your follow-up except for one problem with flex. I will attach an example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179182&action=edit problem with buttons when using flex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, these patches are from last week, but I get an untidy warning: 0) QA script FAIL installer/data/mysql/atomicupdate/bug_37211.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/bug_37211.pl` FAIL koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc` Please check your setup! I have seen some of those and would like to get to the bottom of this. it's time consuming to squash into the right patches also. There are also some other small issues: 1) We are missing the permission in the installer file for new installations. (blocker) 2) The permission name is very general with "edit_notes". I think it might pay off to be a bit more specific for people looking at these in reports etc. to give an example. edit_accountlines_notes? (suggestion) 3) The input field for changing/editing the note is quite small. Can we make that a big more generous please? If you need to "scroll" within a longer text field for editing, this leads to errors and grup easily. (kind of blocker) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179963&action=edit Bug 37211: Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179967&action=edit Bug 37211: Update permission name to edit_accountline_notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
There are also some other small issues:
1) We are missing the permission in the installer file for new installations. (blocker)
Is there somewhere besides installer/data/mysql/mandatory/userpermissions.sql that I am missing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
3) The input field for changing/editing the note is quite small. Can we make that a big more generous please? If you need to "scroll" within a longer text field for editing, this leads to errors and grup easily. (kind of blocker)
Should we use textarea here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179972&action=edit Bug 37211: Use HTML textarea for the notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179972|0 |1 is obsolete| | --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179977&action=edit Bug 37211: Use HTML textarea for the notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39491 [Bug 39491] All accountline notes should be HTML textarea -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|All notes in the patron |All notes in the patron |Transactions table should |account transactions table |be editable |should be editable Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, we have a failing test, can you please check? t_Koha_Auth_Permissions_t.superlibrarian tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180923&action=edit Bug 37211: (follow-up) Correct Auth/Permissions.t test to account for new permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |t --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #34)
Hi Lucas,
we have a failing test, can you please check?
t_Koha_Auth_Permissions_t.superlibrarian tests
I added a follow-up patch here that should fix the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Keywords|additional_work_needed | --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up pushed to main! (just forgot to note here) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds the release notes| |ability to edit notes in | |the patron transactions | |table. Staff can now edit | |notes on lines for | |discounts, paying | |individual fines, writing | |off individual fines, | |issuing a payouts, voiding | |payments, issuing refunds, | |and cancelling charges. | |There is a new | |subpermission in | |updatecharge to | |'edit_notes'. CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #38 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40723 [Bug 40723] Edits to accountlines notes should be recored in action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41761 [Bug 41761] Updating accountlines note sets accountlines.date to current date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37211 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #39 from Aude Charillon <aude.charillon@openfifth.co.uk> --- *** Bug 42820 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org