[Bug 32938] New: Acquisitions EDI - ORDRSP messages are loaded as invoices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Bug ID: 32938 Summary: Acquisitions EDI - ORDRSP messages are loaded as invoices Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucy.vaux-harvey@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Created attachment 146468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146468&action=edit View of ORDRSP message at edifactmsgs.pl Currently ORDRSP messages (messages from a vendor providing details such as Out of Print, Unable to supply) are loaded into Koha and diaplay as for an INVOICE message. On /cgi-bin/koha/acqui/edifactmsgs.pl in the Details column the message will have the label 'Invoices' and this is hyperlinked to the invoices page (/cgi-bin/koha/acqui/invoices.pl) - see screenshot. This link always results in a failure as there isn't an invoice to match against. Is it possible in the case of ORDRSP to either leave the Details column empty or remove the hyperlink? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucy, can you tell if this is still valid for current versions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #2 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- Hi Katrin, yes this is still valid. I have tested on 22.11.10 and the link to the invoices page is present as in the original screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |22.11 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Lucy, I have updated the version accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #4 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- Many thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Version|22.11 |24.11 --- Comment #5 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Still an issue in 24.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I presume this should just be linked to a Basket rather than an Invoice? And with bug 40334 we should perhaps just give the option to display the ordersp message raw and maybe display what it did. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #7 from Aude Charillon <aude.charillon@openfifth.co.uk> --- (In reply to Martin Renvoize (ashimema) from comment #6)
I presume this should just be linked to a Basket rather than an Invoice?
If there is one handy basket, yes? I don't know whether there is ever a case the ORDRSP covers orders across more than one basket? If so then just having nothing would be better than the current incorrect mention of an Invoice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 [Bug 40383] Modernise the EDIFACT Message display modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185101&action=edit Bug 32938: Fix ORDRSP message linking to point to baskets instead of invoices ORDRSP (Order Response) messages are responses to ORDERS messages and should link to the related basket, not to invoices. This follows the standard EDI workflow: 1. ORDERS message sent to vendor 2. ORDRSP message received from vendor (order response/confirmation) 3. INVOICE message received later when items shipped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 185102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185102&action=edit Bug 32938: Add ORDRSP message display to basket page This patch extends the EDIFACT message display functionality on the basket page to include ORDRSP (Order Response) messages alongside existing QUOTE and ORDERS messages. Features added: - ORDRSP message collection and filtering - Smart button display logic: * Single button for one message type * Dropdown for multiple message types (now includes ORDRSP) - ORDRSP-specific UI elements: * Reply icon (fa-reply) indicating response nature * "View order response" labeling * Integration with existing modal and highlighting system The ORDRSP messages correctly link to baskets since they are vendor responses to the original order, following the standard EDI workflow: ORDERS → ORDRSP → INVOICE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39215 [Bug 39215] EDIFACT quote files should skip orders that cannot be processed rather than failing to complete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185101|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189579&action=edit Bug 32938: Fix ORDRSP message linking to point to baskets instead of invoices ORDRSP (Order Response) messages are responses to ORDERS messages and should link to the related basket, not to invoices. This follows the standard EDI workflow: 1. ORDERS message sent to vendor 2. ORDRSP message received from vendor (order response/confirmation) 3. INVOICE message received later when items shipped Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185102|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189580&action=edit Bug 32938: Add ORDRSP message display to basket page This patch extends the EDIFACT message display functionality on the basket page to include ORDRSP (Order Response) messages alongside existing QUOTE and ORDERS messages. Features added: - ORDRSP message collection and filtering - Smart button display logic: * Single button for one message type * Dropdown for multiple message types (now includes ORDRSP) - ORDRSP-specific UI elements: * Reply icon (fa-reply) indicating response nature * "View order response" labeling * Integration with existing modal and highlighting system The ORDRSP messages correctly link to baskets since they are vendor responses to the original order, following the standard EDI workflow: ORDERS → ORDRSP → INVOICE Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |OpenFifth list of Sponsors| |<https://openfifth.co.uk/> Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192531&action=edit Bug 32938: Fix ORDRSP message linking to point to baskets instead of invoices ORDRSP (Order Response) messages are responses to ORDERS messages and should link to the related basket, not to invoices. This follows the standard EDI workflow: 1. ORDERS message sent to vendor 2. ORDRSP message received from vendor (order response/confirmation) 3. INVOICE message received later when items shipped Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192532&action=edit Bug 32938: Add ORDRSP message display to basket page This patch extends the EDIFACT message display functionality on the basket page to include ORDRSP (Order Response) messages alongside existing QUOTE and ORDERS messages. Features added: - ORDRSP message collection and filtering - Smart button display logic: * Single button for one message type * Dropdown for multiple message types (now includes ORDRSP) - ORDRSP-specific UI elements: * Reply icon (fa-reply) indicating response nature * "View order response" labeling * Integration with existing modal and highlighting system The ORDRSP messages correctly link to baskets since they are vendor responses to the original order, following the standard EDI workflow: ORDERS → ORDRSP → INVOICE Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #14 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- My test queries fails because the query itself executes in less than the max execution time I specified, but the steaming of results ends up killing the process ( 88,750,3681 results ). Therefore my own test query is invalid in the context of this functionality! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #15 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Patches for bug 40383 no longer apply to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192531|0 |1 is obsolete| | Attachment #192532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196041&action=edit Bug 32938: Fix ORDRSP message linking to point to baskets instead of invoices ORDRSP (Order Response) messages are responses to ORDERS messages and should link to the related basket, not to invoices. This follows the standard EDI workflow: 1. ORDERS message sent to vendor 2. ORDRSP message received from vendor (order response/confirmation) 3. INVOICE message received later when items shipped Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196042&action=edit Bug 32938: Add ORDRSP message display to basket page This patch extends the EDIFACT message display functionality on the basket page to include ORDRSP (Order Response) messages alongside existing QUOTE and ORDERS messages. Features added: - ORDRSP message collection and filtering - Smart button display logic: * Single button for one message type * Dropdown for multiple message types (now includes ORDRSP) - ORDRSP-specific UI elements: * Reply icon (fa-reply) indicating response nature * "View order response" labeling * Integration with existing modal and highlighting system The ORDRSP messages correctly link to baskets since they are vendor responses to the original order, following the standard EDI workflow: ORDERS → ORDRSP → INVOICE Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |m.de.rooy@rijksmuseum.nl Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196041|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199416&action=edit Bug 32938: Fix ORDRSP message linking to point to baskets instead of invoices ORDRSP (Order Response) messages are responses to ORDERS messages and should link to the related basket, not to invoices. This follows the standard EDI workflow: 1. ORDERS message sent to vendor 2. ORDRSP message received from vendor (order response/confirmation) 3. INVOICE message received later when items shipped Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199417&action=edit Bug 32938: Add ORDRSP message display to basket page This patch extends the EDIFACT message display functionality on the basket page to include ORDRSP (Order Response) messages alongside existing QUOTE and ORDERS messages. Features added: - ORDRSP message collection and filtering - Smart button display logic: * Single button for one message type * Dropdown for multiple message types (now includes ORDRSP) - ORDRSP-specific UI elements: * Reply icon (fa-reply) indicating response nature * "View order response" labeling * Integration with existing modal and highlighting system The ORDRSP messages correctly link to baskets since they are vendor responses to the original order, following the standard EDI workflow: ORDERS → ORDRSP → INVOICE Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Logical changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #21 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #23 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Caused by 40383 which was released in 26.05.00. Not backporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org