[Bug 9169] New: Wrap authorities relator code in <span> to allow for CSS customization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Bug ID: 9169 Summary: Wrap authorities relator code in <span> to allow for CSS customization Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Some libraries would like to be able to hide relator codes when displaying authorities in the OPAC and staff client. Adding a <span> with class "relatorcode" would allow this text to be hidden via CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrap authorities relator |Wrap relator code in <span> |code in <span> to allow for |to allow for CSS |CSS customization |customization --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Sorry, bibliographic records, not authorities. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13778&action=edit Bug 9169 - Wrap relator code in <span> to allow for CSS customization This patch adds <span class="relatorcode"> around the display of relator codes in the OPAC and the staff client, and adds a space before the bracket (" [relatorcode]") for readability. To test, add custom CSS to OPACUserCSS and IntranetUserCSS and view a record which includes relator code data. Suggested: .relatorcode { background-color: rgb(230, 240, 242); border-radius: 3px 3px 3px 3px; color: rgb(51, 51, 51); display: inline-block; font-size: 75%; font-weight: normal; margin-left: 0.4em; padding: 0.1em 0.4em; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13778|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13943&action=edit [SIGNED-OFF] Bug 9169 - Wrap relator code in <span> to allow for CSS customization This patch adds <span class="relatorcode"> around the display of relator codes in the OPAC and the staff client, and adds a space before the bracket (" [relatorcode]") for readability. To test, add custom CSS to OPACUserCSS and IntranetUserCSS and view a record which includes relator code data. Suggested: .relatorcode { background-color: rgb(230, 240, 242); border-radius: 3px 3px 3px 3px; color: rgb(51, 51, 51); display: inline-block; font-size: 75%; font-weight: normal; margin-left: 0.4em; padding: 0.1em 0.4em; } Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |magnus@enger.priv.no, | |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * tiny patch, touches XSLT only, no side effect risk * passes koha-qa.pl passed QA (QUESTION TO MAGNUS : don't you need the same patch for NORMARC ?) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14241&action=edit Bug 9169 - Wrap relator code in <span> to allow for CSS customization This patch adds <span class="relatorcode"> around the display of relator codes in the OPAC and the staff client, and adds a space before the bracket (" [relatorcode]") for readability. To test, add custom CSS to OPACUserCSS and IntranetUserCSS and view a record which includes relator code data. Suggested: .relatorcode { background-color: rgb(230, 240, 242); border-radius: 3px 3px 3px 3px; color: rgb(51, 51, 51); display: inline-block; font-size: 75%; font-weight: normal; margin-left: 0.4em; padding: 0.1em 0.4em; } Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.9 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 --- Comment #9 from Magnus Enger <magnus@enger.priv.no> --- (In reply to comment #4)
(QUESTION TO MAGNUS : don't you need the same patch for NORMARC ?)
No, it does not look like NORMARC uses relator codes. But thanks for thinking about us! :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I think a followup would be usefull for Unimarc. I will make a new bug for it. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10173 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org