[Bug 7470] New: Babeltheque - new proposal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Bug #: 7470 Summary: Babeltheque - new proposal Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: claire.hernandez@biblibre.com QAContact: koha.sekjal@gmail.com We did a new implementation of babeltheque in koha, more complete and better intergrated (for the moment in community version, babeltheque is not configurable and hardcoded in opac-bottom.inc). 3 features in this one: - adds social network information in search results - adds babeltheque data in opac-detail - adds social network links in opac-detail too (google+, twitter, mail and co.) This dev is in production in 2 of our customes (co-funder). French article with screenshots: http://docmiop.wordpress.com/2012/01/18/quand-babeltheque-enrichit-koha/ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #1 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2012-01-25 16:28:55 UTC --- (MT8241) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master AssignedTo|oleonard@myacpl.org |claire.hernandez@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m AssignedTo|claire.hernandez@biblibre.c |jonathan.druart@biblibre.co |om |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 7984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7984&action=edit Output for update_social_data.pl This file is the result for the script update_social_data.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 7985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7985&action=edit Bug 7470 Babeltheque integration 3 features: - adds social network information in search results - adds babeltheque data in opac-detail - adds social network links in opac-detail too (google+, twitter, mail and co.) This development requires an Babeltheque account. It can be tested at http://catalogue.test4.biblibre.com (sandbox #4) Launch a search ("harry potter" is a good example). The "Bonus" icon marks notices where babeltheque informations exists, and a line contains what kind of informations (i.e. "<stars> 4.33 / 5 (on 1341 rates) 56 Internet user critics 3 Video extracts 20 Quotations") On the detail page, you find several sections: - 2 links on the right ("post a critic" and "post an extract") - Social networks links (Facebook, twitter, linkedin, delicious, google+, mail) (following is returned by Babeltheque) - Rates (contains rates for this notice) - Number of critics/extracts/..; - Tags - "You will like too" - "Vidéos" (movies in relation to the current notice) 3 new system preferences: - Babeltheque_url_js : get an url for babeltheque javascript script - Babeltheque_url_update : get an url for Babeltheque update - SocialNetworks : Boolean, enable or disable social networks links in opac detail In the Babeltheque, the admin can change each label, css style (this one is available in opac.css, lines are commented). Could you please test this patch does not introduce any regression. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 7986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7986&action=edit Output for get_report_social_data.pl This file is the result for the script get_report_social_data.pl (facultative) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7985|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8257&action=edit Bug 7470 Babeltheque integration Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 MathildeF <mathilde.formery@ville-nimes.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathilde.formery@ville-nime | |s.fr --- Comment #6 from MathildeF <mathilde.formery@ville-nimes.fr> --- ** Affichage : Pb affichage dans Firefox < 3.6 : - les boutons "Internet user critics" et "Extracts" ne s'affichent pas correctement - le bloc "exemplaire - note - commentaire" ne se présente pas en onglet sous Firefox (test sur 3.5, 3.6 et 11.0) : le popup des vidéos est excentré à droite et ne se recadre pas à la taille de la fenetre / de l'écran ** Reseaux sociaux - le lien dans facebook vers la notice n'est pas correctement créé (ex : http://www.facebook.com/cgi-bin/koha/opac-detail.pl?biblionumber=1553) - la fenetre de partage G+ se ferme (parfois) immédiatemment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #7 from MathildeF <mathilde.formery@ville-nimes.fr> --- Firefox <3.6: - Buttons "Internet user Critics" and "Extracts" are not displayed correctly - The block "copy - note - comment" does not show in tab Firefox (tested on 3.5, 3.6 and 11.0):the videos are right justified and does not reframes the size of the window / screen - The link in facebook is not created correctly (http://www.facebook.com/cgi-bin/koha/opac-detail.pl?biblionumber=1553 and not "http://mykoha.tld/cgi-bin/koha/opac-detail.pl?biblionumber=1553) - the window Goole+ closes (sometimes) immediately -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8257|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8336&action=edit Bug 7470 Babeltheque integration Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #7)
Firefox <3.6: - Buttons "Internet user Critics" and "Extracts" are not displayed correctly - The block "copy - note - comment" does not show in tab
It's a bug in koha. A js error occured: "$(".close") is null" It's not come from this feature. Maybe, if you used FF3.5, you can upgrade your browser :-)
Firefox (tested on 3.5, 3.6 and 11.0):the videos are right justified and does not reframes the size of the window / screen
It's caused by a css specific in sandboxes. I remove the contain of the system preference "opacstylesheet" and the display is good.
- The link in facebook is not created correctly (http://www.facebook.com/cgi-bin/koha/opac-detail.pl?biblionumber=1553 and not "http://mykoha.tld/cgi-bin/koha/opac-detail.pl?biblionumber=1553)
The system preference "OPACBaseURL" must be filled with the good value
- the window Goole+ closes (sometimes) immediately
Whow, it seems the guilty is the Google+ API, I have not the control on this behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 MathildeF <mathilde.formery@ville-nimes.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: (In reply to comment #9)
(In reply to comment #7)
Firefox <3.6: - Buttons "Internet user Critics" and "Extracts" are not displayed correctly - The block "copy - note - comment" does not show in tab It's a bug in koha. A js error occured: "$(".close") is null" It's not come from this feature. Maybe, if you used FF3.5, you can upgrade your browser :-)
Firefox (tested on 3.5, 3.6 and 11.0):the videos are right justified and does not reframes the size of the window / screen
It's caused by a css specific in sandboxes. I remove the contain of the system preference "opacstylesheet" and the display is good. OK, then it does not prevent from passing QA (note: it's not specific to sandbox, but to sandbox database you're choosen:
Does the problem exist in OPAC ? Does it mean the block doesn't appear at all or the display is crapy ? (that may make a difference for deciding to "pass QA" or not: having a crapy display on old browsers is acceptable. Having no display isn't) the sandbox koha code is purely koha-community)
- The link in facebook is not created correctly (http://www.facebook.com/cgi-bin/koha/opac-detail.pl?biblionumber=1553 and not "http://mykoha.tld/cgi-bin/koha/opac-detail.pl?biblionumber=1553) The system preference "OPACBaseURL" must be filled with the good value OK,
- the window Goole+ closes (sometimes) immediately Whow, it seems the guilty is the Google+ API, I have not the control on this behaviour. could you give more details ?
Other QA comments: * C4/SocialData.pm is not perlcritic compliant: Bareword file handle opened at line 72, column 5. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 72, column 5. See page 207 of PBP. (Severity: 5) * patch does not apply anymore, please rebase when fixing the previous comment (will be a trivial rebase) * opac.css classes= I don't understand why you've BABELTHEQUE classes in opac.css & commented. Please add some explanations otherwise, I think I haven't more QA comments to do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Frederic, you're the author of the 1st version of babeltheque, feel free to have a look to this new version ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Babeltheque - new proposal |Babeltheque improvement and | |social networks links | |(like, +1,...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8336|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8476&action=edit Bug 7470 Babeltheque integration (In reply to comment #10)
QA comments: Does the problem exist in OPAC ? Does it mean the block doesn't appear at all or the display is crapy ? (that may make a difference for deciding to "pass QA" or not: having a crapy display on old browsers is acceptable. Having no display isn't)
It just breaks the display on the opac detail page. It's a bug in master. But FF3.5 is out of date.
- the window Goole+ closes (sometimes) immediately Whow, it seems the guilty is the Google+ API, I have not the control on this behaviour. could you give more details ? No :-/ It's a random behavior and it appears on others sites with the google+ "plugin"
Other QA comments: * C4/SocialData.pm is not perlcritic compliant: Bareword file handle opened at line 72, column 5. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 72, column 5. See page 207 of PBP. (Severity: 5) Ok done with this patch.
* patch does not apply anymore, please rebase when fixing the previous comment (will be a trivial rebase)
Done
* opac.css classes= I don't understand why you've BABELTHEQUE classes in opac.css & commented. Please add some explanations If fact, the css code must be filled into the Babeltheque account configuration. I put it into the koha css for information.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comments: Larger patch. Looks good in general. Controlled by several prefs. So does not hurt anyone who does not use it. Only miss comments from current Babeltheque users. Resolved Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Trailing whitespace at apply. Double dbrev in updatedatabase: please combine into one. Paul could do that at pushing time.. As it appears, the backquotes are not liked by PostgreSQL. Not a blocker until now? Lots of these in updatedatabase.. opac-detail: May need some further design work (followup). Not my specialty. OK update_data: say "$i data insered or updated"; Where does this output go to? Note spelling error too ;) get_report: This seems quite a job. Just curiosity: but how often would you like to do that in a cron job? update_social_data.pl: /tmp is probably ok for rights, but could be an issue. bunzip2 will not be in /bin for every linux distro. opac-detail.tt: https://apis.google.com/js/plusone.js: Do you need to include this js if you do not use this feature? Probably not. <a href="mailto:ADRESSE?subject=TO READ : [% title %]>: Does not look great. In conclusion: May need some followups. But have no objection to push it further. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8630&action=edit Bug 7470: Followup: include g+ api if syspref SocielNetwork is on -- You are receiving this mail because: You are watching all bug changes.
QA Comments: Larger patch. Looks good in general. Controlled by several prefs. So does not hurt anyone who does not use it. Only miss comments from current Babeltheque users.
Resolved Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Trailing whitespace at apply.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #13) trivial conflict, resolved.
Double dbrev in updatedatabase: please combine into one. Paul could do that at pushing time.. I prefer to have 2 dbrevs: the babeltheque stuff is specific to babelio customers, probably only french libraries The other (social networks) is related to having links to "like", "+1",... that are a different feature. So having 2 DBrevs will enforce the visibility of the 2nd feature. As it appears, the backquotes are not liked by PostgreSQL. Not a blocker until now? Lots of these in updatedatabase.. good point. I've removed them in the commit
update_data: say "$i data insered or updated"; Where does this output go to? Note spelling error too ;) The update_data script is called by a cronjob, that's the result of the cron (with the generated file), so no need to worry here I've fixed the typo in the commit.
get_report: This seems quite a job. Just curiosity: but how often would you like to do that in a cron job? for our customers, it will be once a week. We have 2 medium size catalogue (300 000 items) running it for now. Maybe for AixMarseille (1 million !) that will even be less frequent.
update_social_data.pl: /tmp is probably ok for rights, but could be an issue. bunzip2 will not be in /bin for every linux distro. I think you're right. Jonathan, I think having the patch in the cron PATH is something we can request. Thus, just calling bunzip2 should be OK. You could also try to guess the patch by testing some common ones. There's something like that in rebuild_zebra.pl, to find zebraidx
opac-detail.tt: https://apis.google.com/js/plusone.js: Do you need to include this js if you do not use this feature? Probably not. <a href="mailto:ADRESSE?subject=TO READ : [% title %]>: Does not look great.
you're right Marcel. Jonathan, could you provide a follow-up
In conclusion: May need some followups. But have no objection to push it further.
So I push it now ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed, with a little change: the SocialNetworks syspref has been set to 0 => the rule, when including a switchable improvement is to have it as it was before the improvement. So, in this case, switched OFF Another suggestion : The syspref would be better in the tab Enhanced content > All, instead of Searching (just realised that after pushing) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- switching back to "assigned" to address the small issues that have been raised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8476|0 |1 is obsolete| | --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 8476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8476 Bug 7470 Babeltheque integration this patch has been pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8630|0 |1 is obsolete| | --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 8630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8630 Bug 7470: Followup: include g+ api if syspref SocielNetwork is on this patch has been pushed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I noticed the new syspref on update and wonder if we could perhaps rename it? The feature and release are not fully out of the door yet... Currently it is: Babeltheque_url_js Defined the url for the Babeltheque javascript file (eg. http://www.babeltheque.com/bw_XX.js) I know we don't have much of a standard for naming system prefernces, but at least we had no underscores so far :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, it is possible that I am being silly here... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #22 from Nicole C. Engard <nengard@gmail.com> --- - adds social network information in search results I don't see this. I see the social share buttons on the detail page, but not on the search results with XSLT and Marc21. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- This feature is mostly broken for me and I think it should be reverted. All URLs being used for sharing appear to be broken. Clicking the Facebook share button brings me to a page on Facebook where I'm sharing this link: http://www.facebook.com/cgi-bin/koha/opac-detail.pl?biblionumber=453 On my Ubuntu machine the Twitter link brings me to a "share" page in which the body of the tweet is the correct URL, but on Windows I get a blank "share" box. We should be passing the title as well as the URL to Twitter. Clicking the LinkedIn share button passes the correct title but not a full URL ("/cgi-bin/koha/opac-detail.pl?biblionumber=453"). The Delicious link passes the title but not a full URL. The mailto: link seems to have extraneous markup and, again, does not pass a full URL. This is not ready. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- The social networks stuff could be easily disentangled from the Babeltheque stuff. That would be a good option if the Babeltheque stuff is working well (which of course I can't test). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- @Nicole: oups, it's only on the detail page. There is no link on the search page. @Owen: Have you filled correctly your syspref OPACBaseURL ? It sound like the problem reported by Mathilde, please see my Comment 9. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8707&action=edit Bug 7470: Move the SocialNetworks syspref to the "Enhanced Content" tab This patch moves the system preference "SocialNetworks" from the "Searching" tab to "Enhanced Content" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Okay, you're right: I didn't have the OPACBaseURL preference filled. This improves the behavior all around. I'm still getting inconsistent results with Twitter--sometimes nothing comes up in the share box. I wonder if anyone else sees the same thing? I still think it would be good to pass the title of the item to Twitter along with the URL. Delicious is working fine now that I have OPACBaseURL filled. I still have problems with the mailto link though. The "To:" field is pre-populated with the word "ADRESSE"--can it be left blank? The subject looks like this: TO READ : Zero day :> And the title like this: Zero day :> localhost:88/cgi-bin/koha/opac-detail.pl?biblionumber=751 The ">" is not in the title. Seems to be coming from the link. So, some small follow-ups required but it is working properly for the most part. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8716&action=edit Bug 7470: Followup: Changes twitter and mailto links - Delete useless '>' character - Change the subject for mailto - Set url and text params for the twitter link (Appearly, OPACBaseURL must begin with http:// to make twitter happy) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7897 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- QA question about the follow-up: shouldn't the [% title %] be [% title|html %] ? Without |html, a title with a & would break the link validity, isn't it ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8716|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8955&action=edit Bug 7470: Followup: Changes twitter and mailto links Yes Paul, you are right (but here we want the url filter, not html) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9271&action=edit Bug 7470: Followup Move Babeltheque css into a specific fil -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #31)
Bug 7470: Followup Move Babeltheque css into a specific fil
There's still no reference to the CSS file in the OPAC. Shouldn't it be conditionally included in opac-detail.tt if Babeltheque is enabled? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #32)
There's still no reference to the CSS file in the OPAC. Shouldn't it be conditionally included in opac-detail.tt if Babeltheque is enabled?
Hi Owen, It is just an example. The good way to use these css properties is to declare them into the Babeltheque configuration. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9271|0 |1 is obsolete| | --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9643&action=edit [SIGNED-OFF] Bug 7470: Followup Move Babeltheque css into a specific file Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #28)
- Change the subject for mailto
This is a good improvement.
- Set url and text params for the twitter link (Appearly, OPACBaseURL must begin with http:// to make twitter happy)
In my test the link doesn't get passed to Twitter whether or not OPACBaseURL begins with "http://". That requirement is problematic since the preference instructs the user *not* to include "http://": "The OPAC is located at http:// [ input ]" I like the option to use a standard URL for the Twitter share option because it means the user doesn't need to have JavaScript turned on. But if we can't get it to work consistently I think my patch for Bug 7932 might be a better choice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8955|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9674&action=edit Bug 7470: Followup: Changes mailto links -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9674|0 |1 is obsolete| | --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 10904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10904&action=edit [SIGNED-OFF] Bug 7470: Followup: Changes mailto links Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * the 1st patch remove css declarations that are useless when you don't use babeltheque, it's good. I just have added a follow-up with some doc to avoid removal of this babeltheque.css file ! * the 2nd patch is tiny Passed QA (patches pushed on master branch, they don't apply correctly on new/bug_7470) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10129 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org