[Bug 12285] New: Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Bug ID: 12285 Summary: Allow easy printing of patron's fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com There should be an easy way to print a slip of patron's fines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@pttk.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@pttk.fi> --- Created attachment 28327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28327&action=edit Add a printing option to the staff client patron details page to print a slip of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. --- Yes, the C4/Members.pm is missing docs. I'm just getting this out in case it's of any use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- I tested. After applying the patch the menu item appeared as expected, but the slip did not display properly. Ic checked FINESLIP in Home › Tools › Notices & Slips. It had missing angle brackets (<) at two places. After fixing it the slip printed as expected. The HTML in FINESLIP inserted by the patch was: <<borrowers.firstname>> <<borrowers.surname>><br> <<borrowers.cardnumber>><br> Fines: <<total.fines>> <ul> <fines> <li><<fines.date_due>>, 1001<fines.amount>><br> Bar code: <<items.barcode>><br> <<fines.description>> </fines> </ul> Total: 1001<total.amount>> If I look at the patch, the strange 1001's appear at the places where, in both SQL statemens, we have $<<fines.amount>> and $<<total.amount>> Could it be that the $ signes are superfluous? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard@gmail.com --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Changing status so Marc's concerns are addressed in a new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 29144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29144&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29692&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 29692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29692 Bug 12285: Allow easy printing of patron's fines. Review of attachment 29692: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12285&attachment=29692) ----------------------------------------------------------------- Hi Pasi, I have added my comments using Splinter review, hope everything is clear. Again, I really like the idea of this and hope you can provide a follow-up. Addition to Splinter comments: Please include the new notice template in the translated sample_notices.sql as well. Leaving them in English is fine. ::: C4/Members.pm @@ +2406,5 @@
); }
+ +sub GetBorrowerFines {
I am not sure this one is needed - why not use GetMemberAccountRecords? If we are to keep this one, please point out why it's more useful and add unit tests and documentation (POD). @@ +2422,5 @@
+ my $data = $sth->fetchall_arrayref({}); + return $data; +} + +sub FineSlip {
Needs unit tests. ::: installer/data/mysql/en/mandatory/sample_notices.sql @@ +143,5 @@
Your library.' ); + +INSERT INTO letter (module, code, branchcode, name, is_html, title, content, message_transport_type) +VALUES ( 'circulation', 'FINESLIP', '', 'Patron fines -slip', '1', 'Fines', '<<borrowers.firstname>> <<borrowers.surname>><br>
I think 'Fines and fees slip' would maybe be better. @@ +149,5 @@
+Fines: <<total.fines>> +<ul> +<fines> +<li><<fines.date_due>>, <<fines.amount>><br> +Bar code: <<items.barcode>><br>
Small typo - barcode, please fix. ::: installer/data/mysql/updatedatabase.pl @@ +8573,5 @@
+$DBversion = "3.17.00.XXX"; +if ( CheckVersion($DBversion) ) { + $dbh->do(" +INSERT INTO letter (module, code, branchcode, name, is_html, title, content, message_transport_type) +VALUES ( 'circulation', 'FINESLIP', '', 'Patron fines -slip', '1', 'Fines', '<<borrowers.firstname>> <<borrowers.surname>><br>
Please fix the name here too. @@ +8579,5 @@
+Fines: <<total.fines>> +<ul> +<fines> +<li><<fines.date_due>>, <<fines.amount>><br> +Bar code: <<items.barcode>><br>
Small typo, please fix. ::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc @@ +129,4 @@
[% IF ( CAN_user_borrowers ) %]<li><a id="printsummary" href="#">Print summary</a></li>[% END %] <li><a id="printslip" href="#">Print slip</a></li> <li><a id="printquickslip" href="#">Print quick slip</a></li> + <li><a id="printfineslip" href="#">Print fines</a></li>
Maybe print fines and fees? Just a suggestion, not blocker. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=1232 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org