http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 29692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29692 Bug 12285: Allow easy printing of patron's fines. Review of attachment 29692: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12285&attachment=29692) ----------------------------------------------------------------- Hi Pasi, I have added my comments using Splinter review, hope everything is clear. Again, I really like the idea of this and hope you can provide a follow-up. Addition to Splinter comments: Please include the new notice template in the translated sample_notices.sql as well. Leaving them in English is fine. ::: C4/Members.pm @@ +2406,5 @@
); }
+ +sub GetBorrowerFines {
I am not sure this one is needed - why not use GetMemberAccountRecords? If we are to keep this one, please point out why it's more useful and add unit tests and documentation (POD). @@ +2422,5 @@
+ my $data = $sth->fetchall_arrayref({}); + return $data; +} + +sub FineSlip {
Needs unit tests. ::: installer/data/mysql/en/mandatory/sample_notices.sql @@ +143,5 @@
Your library.' ); + +INSERT INTO letter (module, code, branchcode, name, is_html, title, content, message_transport_type) +VALUES ( 'circulation', 'FINESLIP', '', 'Patron fines -slip', '1', 'Fines', '<<borrowers.firstname>> <<borrowers.surname>><br>
I think 'Fines and fees slip' would maybe be better. @@ +149,5 @@
+Fines: <<total.fines>> +<ul> +<fines> +<li><<fines.date_due>>, <<fines.amount>><br> +Bar code: <<items.barcode>><br>
Small typo - barcode, please fix. ::: installer/data/mysql/updatedatabase.pl @@ +8573,5 @@
+$DBversion = "3.17.00.XXX"; +if ( CheckVersion($DBversion) ) { + $dbh->do(" +INSERT INTO letter (module, code, branchcode, name, is_html, title, content, message_transport_type) +VALUES ( 'circulation', 'FINESLIP', '', 'Patron fines -slip', '1', 'Fines', '<<borrowers.firstname>> <<borrowers.surname>><br>
Please fix the name here too. @@ +8579,5 @@
+Fines: <<total.fines>> +<ul> +<fines> +<li><<fines.date_due>>, <<fines.amount>><br> +Bar code: <<items.barcode>><br>
Small typo, please fix. ::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc @@ +129,4 @@
[% IF ( CAN_user_borrowers ) %]<li><a id="printsummary" href="#">Print summary</a></li>[% END %] <li><a id="printslip" href="#">Print slip</a></li> <li><a id="printquickslip" href="#">Print quick slip</a></li> + <li><a id="printfineslip" href="#">Print fines</a></li>
Maybe print fines and fees? Just a suggestion, not blocker. -- You are receiving this mail because: You are watching all bug changes.