[Bug 6663] New: would be nice to put ranges of dates in the calendar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Bug #: 6663 Summary: would be nice to put ranges of dates in the calendar Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Would be nice if in the calendar I could say we're closed the 1st-3rd. Right now that's not an option with repeatable holidays or unique holidays. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Change sponsored?|--- |Sponsored AssignedTo|gmcharlt@gmail.com |christophe.croullebois@bibl | |ibre.com --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 12:22:25 UTC --- Christophe made something for this. It's still to be tested though, maybe christophe you could format your patch, attach it here, and Nicole will test it (and propose better wordings as you did, because I saw some words that seemed odd ... even to me...) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-08-03 15:12:02 UTC --- (In reply to comment #1)
Christophe made something for this. It's still to be tested though, maybe christophe you could format your patch, attach it here, and Nicole will test it (and propose better wordings as you did, because I saw some words that seemed odd ... even to me...)
Ok Paul, I'll do that. But some stuff in holidays.tmpl need to be rewrited in holidays.tt, this WE I think... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-12-02 15:29:59 UTC --- Created attachment 6537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6537 Allow to select a range between 2 dates for holiday 2 new choices : Holidays on a range Holidays repeated yearly on a range you just have to type in the "To Date : " field the end of the range. The syspref "dateformat" changes of course the order of input boxes. It's a basic feature, I think it could be improve... With "delete on a range"... First step, but usefull I hope -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-12-02 15:58:26 UTC --- Could we use the datepicker widget for the "To Date" instead of the three separate inputs? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-12-02 16:23:13 UTC --- Owen, it would be better of course... My patch is very basic, so, no in this state. But I'll try to code that. Thx for comment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-03 20:30:17 UTC --- Entering unique and repeating date ranges works for me, but I agree with Owen that a date picker would be more consistent and easier to manage. I noticed that the 'today' button on the calendar is broken. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6537|0 |1 is obsolete| | --- Comment #7 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-12-04 21:07:51 UTC --- Created attachment 6569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6569 Add a datepicker for "to date" in a range selection I hope this one is better. I have tryed to keep the code light. Thx for testing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6569|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2011-12-05 20:41:59 UTC --- Created attachment 6586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6586 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #9 from Owen Leonard <oleonard@myacpl.org> 2011-12-05 20:45:55 UTC --- This looks good. A couple of possible future improvements: - Prevent the user from choosing a date which falls before the "From Date" - Only show the "To Date" if one of the "range" options is selected -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 --- Comment #10 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-12-06 08:38:36 UTC --- It's right Owen, I have thought about a hidding of "To Date:" when the "range" options is not selected. But not about a check on the "to date" integrity. The best would be with a "grey-zone" calandar, but I am not sure with this one if I am able to do that, anyway at least a warning message would be usefull. So, thx Owen, Katrin, I'll try to code the suggestions of Owen. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-13 14:13:24 UTC --- QA comment : * code OK * works fine * perlcritic OK * prove xt/author/translatable-templates.t OK passed QA Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #12 from delaye <stephane.delaye@biblibre.com> --- *** Bug 7681 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7964 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Bug 6663 depends on bug 7964, which changed state. Bug 7964 Summary: Perl error when adding a range of holidays without To: date http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7964 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6663 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This was incorporated into 3.6.x prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org