[Bug 7245] New: Errors in MySQL tables population with mandatory data for italian installation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Bug #: 7245 Summary: Errors in MySQL tables population with mandatory data for italian installation Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: fabio.tian@gmail.com QAContact: ian.walls@bywatersolutions.com Created attachment 6337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6337 screenshot of errors in web installer While installing italian and UNIMARC version of Koha via web installer, two errors occur: ERROR 1136 (21S01) and ERROR 1064 (42000). Some tables can't be populated with mandatory data. Errors are related to files sample_itemtypes.sql and unimarc_framework.sql (/usr/share/koha/intranet/cgi-bin/installer/data/mysql/it-IT/ and subdirectories). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #1 from Fabio Tiana <fabio.tian@gmail.com> 2011-11-18 15:51:01 UTC --- Created attachment 6338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6338 correct sample_itemtypes.sql -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #2 from Fabio Tiana <fabio.tian@gmail.com> 2011-11-18 15:52:59 UTC --- Created attachment 6339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6339 correct unimarc_framework.sql -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-11-18 15:55:26 UTC --- Thanks. Can you submit those corrected files as patches? Do you know how to do that? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #4 from Fabio Tiana <fabio.tian@gmail.com> 2011-11-18 16:02:21 UTC --- You're welcome! Correct sql files are now attached, please check/test. Errors were related to sample_itemtypes.sql and unimarc_framework.sql. sample_itemtypes.sql INSERTs took one more field than expected by itemtypes table. I deleted the fifth value (originally set to 0 for each query), so now the fields are 6 insted of 7 (that is wrong). As to unimarc_framework.sql, the first two INSERT were performed as expected. The errors in the comments' syntax started from row 18, preventing the tables from being populated. Fabio -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Fabio Tiana <fabio.tian@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-11-20 12:16:46 UTC --- Created attachment 6348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6348 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tajoli@cilea.it -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #6 from Zeno Tajoli <tajoli@cilea.it> 2011-11-20 15:49:19 UTC --- Tested patch. It is all. I sign-off the patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #7 from Zeno Tajoli <tajoli@cilea.it> 2011-11-20 19:55:12 UTC --- Created attachment 6349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6349 sign-off of the patch This the sign-off of the patch. I have tested it and I don't find problems -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-12 16:56:22 UTC --- QA comment: I hesitate to mark failed QA but... there is a big mistake in the sql files: they are using short SQL statements: +INSERT INTO `itemtypes` VALUES ('BK', 'Libro',5,0,'bridge/book.gif',''); and not +INSERT INTO `itemtypes` (field1, field2, field3, field4, field5,...) VALUES ('BK', 'Libro',5,0,'bridge/book.gif',''); it means that the next modification in itemtypes will result in this bug being reopened, because it will fail again. Could you please fix the SQL and add the field names ? marking failed QA, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> 2011-12-13 06:56:14 UTC --- (In reply to comment #8)
QA comment: I hesitate to mark failed QA but... there is a big mistake in the sql files: they are using short SQL statements: +INSERT INTO `itemtypes` VALUES ('BK', 'Libro',5,0,'bridge/book.gif',''); and not
+INSERT INTO `itemtypes` (field1, field2, field3, field4, field5,...) VALUES ('BK', 'Libro',5,0,'bridge/book.gif','');
it means that the next modification in itemtypes will result in this bug being reopened, because it will fail again.
Could you please fix the SQL and add the field names ?
marking failed QA,
You're right. it-IT/necessari/sample_itemtypes.sql contains incorrect SQL statements. But those statements are not introduced but this patch. There are already there in HEAD. IMO this issue should be covered by a separated bugzilla entry, and the attached patch should be applied since it fixes a real and current issue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6338|0 |1 is obsolete| | Attachment #6339|0 |1 is obsolete| | Attachment #6348|0 |1 is obsolete| | Attachment #6349|0 |1 is obsolete| | --- Comment #10 from Zeno Tajoli <tajoli@cilea.it> 2011-12-13 12:58:43 UTC --- Created attachment 6744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6744 patch with fileds (as asked RM) The patch with fields in sql insert -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-13 13:44:16 UTC --- QA comment: no comment now, small patch. I've tested, it works fine. Patch pushed, please test. PS : welcome Fabio, you're 165th ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-13 17:27:42 UTC --- Just for the record: (In reply to comment #9)
You're right. it-IT/necessari/sample_itemtypes.sql contains incorrect SQL statements. But those statements are not introduced but this patch. There are already there in HEAD. IMO this issue should be covered by a separated bugzilla entry, and the attached patch should be applied since it fixes a real and current issue.
Frederic was right, and I would have pushed the incomplete patch today if the proper patch had not been submitted. I'll write something on the wiki about how we (QA team) / I (RM) accept a patch or no. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7392 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Blocks|7392 | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Was changed by accident, setting back to original status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7245 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch was incorporated into the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org