[Bug 18655] New: Unimarc field 210c fails on importing fields with a simple quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Bug ID: 18655 Summary: Unimarc field 210c fails on importing fields with a simple quote Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When you search for an editor with a simple quote in the name, the escaping fails and nothing happens. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #1 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63644&action=edit Bug 18655: correct the escaping of ' and move code toward jquery part -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |minor CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |baptiste.wojtkowski@biblibr | |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 63652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63652&action=edit Bug 18655: Followup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63644|0 |1 is obsolete| | Attachment #63652|0 |1 is obsolete| | --- Comment #3 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63653&action=edit Bug 18655: Correct the "chose" link - Link 'chose' is now a button. - It doesn't call directly javascript anymore (use of listener). - field to load stored in html on the page (less escaping needed). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |sonia.bouis@univ-lyon3.fr --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe someone familiar with the plugin could test? It sounds like a search within the plugin which contains ' should fail without the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.pouchol@biblibre.com --- Comment #5 from Simon Pouchol <simon.pouchol@biblibre.com> --- Hi Baptiste, I was looking to test this patch, could you provide a Test Plan ? I can't seem to able to reproduce the bug within the unimarc plugin 210c, with or without the patch I can search for an authority with a ' in the name. The choose button doesn't seem appear for me at all (can't find it hidden in dev tools either). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|baptiste.wojtkowski@biblibr |fridolin.somers@biblibre.co |e.com |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Simon Pouchol from comment #5)
Hi Baptiste, I was looking to test this patch, could you provide a Test Plan ? I can't seem to able to reproduce the bug within the unimarc plugin 210c, with or without the patch I can search for an authority with a ' in the name. The choose button doesn't seem appear for me at all (can't find it hidden in dev tools either).
I continue Baptiste's job. You need an existing authority with a ' in its name, like "L'histoire". When trying to choose this authority it fails. Btw I think that writing JS inside HTML tags is now prohibited. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Charles Farmer <charles.farmer@inlibro.com> --- Patch doesn't apply anymore, because of what looks like an added MACRO jsinclude BLOCK:
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Javascript has been moved to the bottom of all the tt in intranet - that's probably causing the conflict. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 76168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76168&action=edit Bug 18655: Correct the choose link in unimarc_field_210c value builder - Link 'choose' is now a button. - It doesn't call directly javascript anymore (use of listener). - field to load stored in html on the page (less escaping needed). Test plan : 1) Use UNIMARC catalog 2) Define unimarc_field_210c value builder on 210$c 3) Define an autority type EDITORS with heading on 200$b 4) Create an autority of this type with a single quote in heading, ie : l'avenir 5) Index this new autority 6) Edit a biblio record and launch 210$c value builder 7) Search for new autority 8) Click on 'Choose' => Heading should be pasted in 210$c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63653|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76168|0 |1 is obsolete| | --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 78710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78710&action=edit Bug 18655: Correct the choose link in unimarc_field_210c value builder - Link 'choose' is now a button. - It doesn't call directly javascript anymore (use of listener). - field to load stored in html on the page (less escaping needed). Test plan : 1) Use UNIMARC catalog 2) Define unimarc_field_210c value builder on 210$c 3) Define an autority type EDITORS with heading on 200$b 4) Create an autority of this type with a single quote in heading, ie : l'avenir 5) Index this new autority 6) Edit a biblio record and launch 210$c value builder 7) Search for new autority 8) Click on 'Choose' => Heading should be pasted in 210$c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78710|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 78865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78865&action=edit Bug 18655: Correct the choose link in unimarc_field_210c value builder - Link 'choose' is now a button. - It doesn't call directly javascript anymore (use of listener). - field to load stored in html on the page (less escaping needed). Test plan : 1) Use UNIMARC catalog 2) Define unimarc_field_210c value builder on 210$c 3) Define an autority type EDITORS with heading on 200$b 4) Create an autority of this type with a single quote in heading, ie : l'avenir 5) Index this new autority 6) Edit a biblio record and launch 210$c value builder 7) Search for new autority 8) Click on 'Choose' => Heading should be pasted in 210$c Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78865|0 |1 is obsolete| | --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80315&action=edit Bug 18655: Correct the choose link in unimarc_field_210c value builder - Link 'choose' is now a button. - It doesn't call directly javascript anymore (use of listener). - field to load stored in html on the page (less escaping needed). Test plan : 1) Use UNIMARC catalog 2) Define unimarc_field_210c value builder on 210$c 3) Define an autority type EDITORS with heading on 200$b 4) Create an autority of this type with a single quote in heading, ie : l'avenir 5) Index this new autority 6) Edit a biblio record and launch 210$c value builder 7) Search for new autority 8) Click on 'Choose' => Heading should be pasted in 210$c Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org