[Bug 20276] New: GetCourseItem is using the wrong call to get itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Bug ID: 20276 Summary: GetCourseItem is using the wrong call to get itemnumber Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In course_reserves/add_items.pl we now get the item via Objects This line: 66 my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} ); Should be: 66 my $course_item = GetCourseItem( itemnumber => $item->itemnumber ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ah corrected since 17.11 by : Bug 18276: Remove GetBiblioFromItemNumber - Course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18276 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 72110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72110&action=edit Bug 20276: Fix GetCourseItem call to get itemnumber In 17.05.x : In course_reserves/add_items.pl we now get the item via Objects. This line: 66 my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} ); Should be: 66 my $course_item = GetCourseItem( itemnumber => $item->itemnumber ); This is corrected since 17.11 by : Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Test plan : 1) Create a course reserve and add items. 2) Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. 3) Try to add a non existing barcode, you get the page with a message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72110|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72113&action=edit Bug 20276: Fix GetCourseItem call to get itemnumber In 17.05.x : In course_reserves/add_items.pl we now get the item via Objects. This line: 66 my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} ); Should be: 66 my $course_item = GetCourseItem( itemnumber => $item->itemnumber ); This is corrected since 17.11 by : Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Test plan : 1) Create a course reserve and add items. 2) Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. 3) Try to add a non existing barcode, you get the page with a message Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72113|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72186&action=edit Bug 20276: Fix GetCourseItem call to get itemnumber In 17.05.x : In course_reserves/add_items.pl we now get the item via Objects. This line: 66 my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} ); Should be: 66 my $course_item = GetCourseItem( itemnumber => $item->itemnumber ); This is corrected since 17.11 by : Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Test plan : 1) Create a course reserve and add items. 2) Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. 3) Try to add a non existing barcode, you get the page with a message Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 [Bug 20728] Remove subroutines GetLastOrder* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20728 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 [Bug 20728] Remove subroutines GetLastOrder* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20276 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org