[Bug 33395] New: Patron search results shows only overdues if patron has overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Bug ID: 33395 Summary: Patron search results shows only overdues if patron has overdues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When you search for patrons, in the results table, there is a Checkouts column. If the patron has no checkouts, it shows 0 / 0 (0 overdues / 0 total checkouts). If the patron has checkouts but no overdues, it shows, for example, 0 / 1 (0 overdues / 1 total checkout). If the patron has only overdues, it shows, for example, only 1 in red (1 overdue ?? total checkouts?). If the patron has checkouts and overdues, it shows, for example, only 1 in red also (1 overdue ?? total checkouts?) It's like if there are overdues, the number of checkouts disappear. To replicate: 1. Make sure SpecifyDueDate is enabled 2. Have 4 patrons (I used 4 patrons with B last names to see them all in one go) 3. Checkout items as follows - Checkout 1 item normally to Patron A - Checkout 1 item to Patron B, specifying a due date in the past - Checkout 1 item normally and 1 item with a past due date to Patron C - Nothing to Patron D 4. Go to Patrons and search for the patrons, making sure there are more than one results --> In the results table, the Checkouts column is like this Patron A: 0 / 1 Patron B: 1 (red) Patron C: 1 (red) Patron D: 0 / 0 For Patron B, it should be (I think?) 1 / 1 For Patron C, it should be (I think?) 1 / 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #1 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I'm fairly certain this used to display both the checkout count and the overdue count when a patron had overdue items, but I don't have access to an older version on which to confirm this. It looks like bug 30063 (22.05) changed how patron search works, so maybe this behavior changed then? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Confirmed, this is a regression. The manual for 21.11 contains a screenshot of this screen: https://koha-community.org/manual/21.11/en/html/_images/patronsearchresults.... And here's the same from the latest manual: https://koha-community.org/manual/latest/en/html/_images/patronsearchresults... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Andrew! I was pretty sure both were displayed before, but I didn't go the extra step... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | CC| |david@davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30063 Severity|normal |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 156127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156127&action=edit Bug 33395: Patron search results - show number of overdues and checkouts when patrons have overdues This fixes the display of patron search results, so that it shows the number of checkouts when a patron has overdue items. For example: 1 / 2 Bug 30063 changed the display to show only the number of overdue items in bold and red, without the total number of items checked out. Test plan: 1. Check out two items to a patron - make one overdue (click the checkout setting options and then specify a due date a month ago). 2. Check out another item to another patron. 3. Search for patrons so that the two patrons you checked out items to are listed in the results. 4. Note the display for the 'Checkouts' column: 4.1 For patrons without any checkouts: 0 / 0 4.2 For the patron from step 2 with one checkout: 0 / 1 4.3 For the patron from step 1 with one overdue and one checkout: 1 (in bold and red) 5. Apply the patch. 6. Refresh the page of results (step 3). 7. Note that for the patron from step 1, the display now shows: 1 / 2 (with the 1 in bold and red). 8. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156127|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156134&action=edit Bug 33395: Patron search results - show number of overdues and checkouts when patrons have overdues This fixes the display of patron search results, so that it shows the number of checkouts when a patron has overdue items. For example: 1 / 2 Bug 30063 changed the display to show only the number of overdue items in bold and red, without the total number of items checked out. Test plan: 1. Check out two items to a patron - make one overdue (click the checkout setting options and then specify a due date a month ago). 2. Check out another item to another patron. 3. Search for patrons so that the two patrons you checked out items to are listed in the results. 4. Note the display for the 'Checkouts' column: 4.1 For patrons without any checkouts: 0 / 0 4.2 For the patron from step 2 with one checkout: 0 / 1 4.3 For the patron from step 1 with one overdue and one checkout: 1 (in bold and red) 5. Apply the patch. 6. Refresh the page of results (step 3). 7. Note that for the patron from step 1, the display now shows: 1 / 2 (with the 1 in bold and red). 8. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156134|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156210&action=edit Bug 33395: Patron search results - show number of overdues and checkouts when patrons have overdues This fixes the display of patron search results, so that it shows the number of checkouts when a patron has overdue items. For example: 1 / 2 Bug 30063 changed the display to show only the number of overdue items in bold and red, without the total number of items checked out. Test plan: 1. Check out two items to a patron - make one overdue (click the checkout setting options and then specify a due date a month ago). 2. Check out another item to another patron. 3. Search for patrons so that the two patrons you checked out items to are listed in the results. 4. Note the display for the 'Checkouts' column: 4.1 For patrons without any checkouts: 0 / 0 4.2 For the patron from step 2 with one checkout: 0 / 1 4.3 For the patron from step 1 with one overdue and one checkout: 1 (in bold and red) 5. Apply the patch. 6. Refresh the page of results (step 3). 7. Note that for the patron from step 1, the display now shows: 1 / 2 (with the 1 in bold and red). 8. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Patch complexity|--- |Trivial patch --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org