[Bug 34891] New: View restrictions button (patrons page) doesn't link to tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Bug ID: 34891 Summary: View restrictions button (patrons page) doesn't link to tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When there are restrictions on a patron's account, the 'View restrictions' button that appears after the list of restrictions doesn't scroll you down to the restrictions tab (on either the check out or details tab). To replicate: 1. For any patron, add a restriction (Patrons > [patron] > Check out or Details tab > Add manual restriction). 2. The restriction is now listed at the top of the page, with a 'View restrictions' button. 3. Note that if you click the 'View restrictions' button: - It opens the Restrictions tab, - But doesn't scroll down the page to the actual tab 4. This is more evident on the details section of the patron account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 [Bug 33528] Use template wrapper for tabs: Patron details and circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156116&action=edit Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156116|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 156119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156119&action=edit Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156119|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 156339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156339&action=edit Bug 34891: Correct link on view restrictions button This patch updates the button which appears on the circulation page when a patron is restricted. Before this patch, clicking the button would activate the restrictions tab but wouldn't scroll the page to make the tab visible. To test, apply the patch and check out to a patron who has one or more restrictions. - There should be a message on the page, "Restricted since..." - Click the "View restrictions" button. - The page should jump down so that the tabs are visible and the restrictions tab should be active. - Test on the patron details page too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Trivial patch, nice fix, QA script is happy. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34891 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Dependency missing for 22.11.x - not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org