[Bug 13453] New: Koha.t daily quote tests assume sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Bug ID: 13453 Summary: Koha.t daily quote tests assume sample data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com This assumes that id 3 will be Abraham Lincoln. If you haven't loaded the sample data prove t/db_dependent/Koha.t failed on the daily quote tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 34360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34360&action=edit Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34360|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 34606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34606&action=edit Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should *NOT* fail the daily quote test. 5) run koha qa test tools Followed test plan 1)-4). Without patch, daily quote test failed. With patch, test passed OK. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34698&action=edit [PASSED QA] Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should *NOT* fail the daily quote test. 5) run koha qa test tools Followed test plan 1)-4). Without patch, daily quote test failed. With patch, test passed OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, leaves actual data unchanged. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Version|master |3.16 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org