[Bug 13360] New: C4::Ris considers that hashes are ordered
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Bug ID: 13360 Summary: C4::Ris considers that hashes are ordered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org If you try to export a record with several 650 fields (for instance), the KW lines won't be displayed in the fields order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12434 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34012&action=edit Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13345 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34012|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34742&action=edit Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> We really should refactor this whole thing into Koha::RIS sometime, it's a horrible module at the moment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34742|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34761&action=edit [PASSED QA] Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> We really should refactor this whole thing into Koha::RIS sometime, it's a horrible module at the moment. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org