[Bug 22537] New: Suspend all hold button appears even if the hold can no longer be suspended.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Bug ID: 22537 Summary: Suspend all hold button appears even if the hold can no longer be suspended. Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: marjorie.barry-vila@collecto.ca QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Created attachment 86742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86742&action=edit suspend_hold Hi, I understand that a hold can not be suspended when it is awaiting for pickup. This is why the Suspend column is empty in the opac user's account. However, "Suspend all holds" button still appears and causes misunderstanding. Nothing happens when you click on the button but the user thinks that his hold has been suspended. See image attached. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86747&action=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Marjorie <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 86749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86749&action=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suspend all hold button |Suspend all hold button |appears even if the hold |appears even if the hold |can no longer be suspended. |can no longer be suspended CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch does no longer apply cleanly, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86749|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 88924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88924&action=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, this works great. Can we have a similar fix for the staff side? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22793 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suspend all hold button |Don't show Suspend all |appears even if the hold |holds button when holds can |can no longer be suspended |no longer be susppended in | |OPAC --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've filed bug 22793 for staff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88924|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88985&action=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor bug which would be challenging to backport. This won't make it into 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org