[Bug 22638] New: Self checkin CSS update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Bug ID: 22638 Summary: Self checkin CSS update Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: claire_gravely@hotmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- The self-checkin page was missed in the opac css update. See bug 22274 for self-checkout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |claire_gravely@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #1 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 87708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87708&action=edit modified: koha-tmpl/opac-tmpl/bootstrap/css/sci.css modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 87710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87710&action=edit Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87708|0 |1 is obsolete| | Attachment #87708|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87767&action=edit Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87710|0 |1 is obsolete| | Attachment #87767|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87769&action=edit Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87770&action=edit Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22274 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22274 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22274 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 [Bug 22274] Self-checkout pages not covered by OPAC CSS changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver.behnke@aei.mpg.de --- Comment #6 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hi Owen, I tried to test the patches on our local test system and a number of hunks didn't apply. What's the baseline version for the patches? I'm on 18.11.04. Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Oliver, patches are always created and have to be applied against the most recent master branch (http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog;h=refs/heads/mas...) as it will be applied there and then backported into older versions if it's a bugfix or minor enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #8 from Claire Gravely <claire_gravely@hotmail.com> --- I did a first test: I forgot the CSS language bar at the bottom and the Font needs to be added in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #9 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Apart from the missing language menu (see Claire's previous comment) everything looks fine to me (tested on ByWater sandbox as most others didn't work for me). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #10 from Claire Gravely <claire_gravely@hotmail.com> --- (In reply to Claire Gravely from comment #8)
I did a first test:
I forgot the CSS language bar at the bottom and the Font needs to be added in.
Nope, it is all looking good, font and style is there! Sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #11 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Ok, so I don't know how to "Enable multiple translations" in a sandbox (the I18N admin prefs don't allow adding languages), so I'd trust Claire's assessment. What I noticed in Firefox is: 1) The "Powered by Koha" footer string is left-adjusted, instead of right-adjusted like the OPAC 2) The font size and style for the SCI top menu is different from the OPAC, which shows if you switch between the two. The SCI header uses a smaller font and has a (ugly) drop-shadow, compared to the OPAC's header (preferred!). HTH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Oliver Behnke from comment #11)
1) The "Powered by Koha" footer string is left-adjusted, instead of right-adjusted like the OPAC
Confirmed.
2) The font size and style for the SCI top menu is different from the OPAC, which shows if you switch between the two.
I don't find this to be the case. Did you clear your browser cache after rebuilding the CSS? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #13 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hm, good point. How do I rebuild the CSS (from SCSS I suppose) in a sandbox? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Oliver Behnke from comment #13)
Hm, good point. How do I rebuild the CSS (from SCSS I suppose) in a sandbox?
Sorry I didn't think about the sandbox testing process... I don't think you can use a sandbox to test a patch which requires rebuilding CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #15 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Makes sense. So that leaves Claire to sign-off if she can't reproduce the front style/size issue I mentioned. Maybe after you moved the string to the right :-) Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87770|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 88086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88086&action=edit Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87769|0 |1 is obsolete| | Attachment #88086|0 |1 is obsolete| | --- Comment #17 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88087&action=edit Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #18 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88088&action=edit Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88087|0 |1 is obsolete| | Attachment #88088|0 |1 is obsolete| | --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88110&action=edit Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88111&action=edit Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 --- Comment #21 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Thanks everyone for getting this done. Hopefully future OPAC CSS changes will include tests of the SCI/SCO modules as well :-) Cheers! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 [Bug 22772] Menu link hover color incorrect in OPAC language choosers -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org