[Bug 27398] New: Serials: Values in subscription length pull down are not translatable when defining numbering patterns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Bug ID: 27398 Summary: Serials: Values in subscription length pull down are not translatable when defining numbering patterns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Blocks: 27382 When editing or adding a numbering pattern in the serials module the pull down for subscription length shows issues, weeks, months. These always appear in English and seem to be untranslatable. Looking at the same pull down on the second page of the "new subscription" form, the values properly translate there. Figuring out the difference in the templates that makes one translatable but not the other would be good. For installing translations: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_fo... For updating the po files to test a fix, see test plan of bug 25067. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 [Bug 27382] [Omnibus] Typos in the manual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27382 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 [Bug 27382] [Omnibus] Typos in the manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14022 CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The following change should work @ koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt:182 @ <li> <label for="sublength">Subscription length:</label> <select id="subtype"> - [% FOREACH subtype IN subtypes_loop %] - <option value="[% subtype.value | html %]">[% subtype.value | html %]</option> - [% END %] + <option value="issues">issues</option> + <option value="weeks">weeks</option> + <option value="months">months</option> (I missed the Academy keyword!) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jamespfk@gmail.com Assignee|koha-bugs@lists.koha-commun |jamespfk@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jamespfk@gmail.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liav@wgc.school.nz Assignee|koha-bugs@lists.koha-commun |liav@wgc.school.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 --- Comment #2 from Ava <liav@wgc.school.nz> --- Created attachment 115475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115475&action=edit Bug 27398: Made values in number patterns subscription length translatable TEST PLAN: Check that the subscription length options when editing or adding a numbering pattern in the serials module are translatable. check that the hard coded values are gone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115475|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115631&action=edit Bug 27398: Made values in number patterns subscription length translatable TEST PLAN: Check that the subscription length options when editing or adding a numbering pattern in the serials module are translatable. check that the hard coded values are gone. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, fixing issues with translations always makes me happy! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if the link and the redirect where thought to work as some kind of non-javascript fallback? If Javascript is enabled, redirect automatically... if not, display the link. But seeing a success message is nice too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Previous comment was for another bug! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115631|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116196&action=edit Bug 27398: Made values in number patterns subscription length translatable TEST PLAN: Check that the subscription length options when editing or adding a numbering pattern in the serials module are translatable. check that the hard coded values are gone. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work, this is a great little improvement. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org