https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116700&action=edit Bug 27676: Correct finesMode ne off condition finesMode is 'off' by default (sysprefs.sql), but if you modify its value from the UI and set it to 'production' then back to 'off', the DB value becomes an empty string '', because of $YAML::Syck::ImplicitTyping This has been found when working on on removing YAML::Syck (bug 22824), so it's not perfect but the situation will be cleared in the follow-up bug report. Test plan: 0. Don't apply the patch 1. reset_all => finesMode eq 'off' in DB 2. Set the pref's value to production 3. Switch it back to 'off' 4. Value is '' in DB 5. Check an item in that should generate overdue charges => Charges are not generated 6. Apply the patch 7. Check an item in that should generate overdue charges => Charges are generated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116700|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116719&action=edit Bug 27676: Correct finesMode ne off condition finesMode is 'off' by default (sysprefs.sql), but if you modify its value from the UI and set it to 'production' then back to 'off', the DB value becomes an empty string '', because of $YAML::Syck::ImplicitTyping This has been found when working on on removing YAML::Syck (bug 22824), so it's not perfect but the situation will be cleared in the follow-up bug report. Test plan: 0. Don't apply the patch 1. reset_all => finesMode eq 'off' in DB 2. Set the pref's value to production 3. Switch it back to 'off' 4. Value is '' in DB 5. Check an item in that should generate overdue charges => Charges are not generated 6. Apply the patch 7. Check an item in that should generate overdue charges => Charges are generated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Correcting a typo in the test plan (charge behavior was backwards between 5 and 7): Test plan: 0. Don't apply the patch 1. reset_all => finesMode eq 'off' in DB 2. Set the pref's value to production 3. Switch it back to 'off' 4. Value is '' in DB 5. Check an item in that should generate overdue charges => Charges are generated 6. Apply the patch 7. Check an item in that should generate overdue charges => Charges are not generated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27676 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.