[Bug 41764] New: Missing 'issn' in the form post of 'z3950_search.tt'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Bug ID: 41764 Summary: Missing 'issn' in the form post of 'z3950_search.tt' Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: darkranger_red@hotmail.com QA Contact: testopia@bugs.koha-community.org Hello, 'issn' is missing in the following code field from 'z3950_search.tt': <form method="post" action="z3950_search.pl" id="page_form" name="page_form" class="checkboxed"> [% INCLUDE 'csrf-token.inc' %] <input type="hidden" name="op" id="op" value="cud-do_search" /> <input type="hidden" name="current_page" id="current_page" value="[% current_page | html %]" /> <input type="hidden" id="title" name="title" value="[% title | html %]" /> <input type="hidden" id="isbn" name="isbn" value="[% isbn | html %]" /> <input type="hidden" id="lccall" name="lccall" value="[% lccall | html %]" /> <input type="hidden" id="controlnumber" name="controlnumber" value="[% controlnumber | html %]" /> <input type="hidden" id="srchany" name="srchany" value="[% srchany | html %]" /> <input type="hidden" id="author" name="author" value="[% author | html %]" /> <input type="hidden" id="publicationyear" name="publicationyear" value="[% publicationyear | html %]" /> <input type="hidden" id="subject" name="subject" value="[% subject | html %]" /> <input type="hidden" id="dewey" name="dewey" value="[% dewey | html %]" /> <input type="hidden" id="stdid" name="stdid" value="[% stdid | html %]" /> <input type="hidden" name="biblionumber" value="[% biblionumber | html %]" /> <input type="hidden" name="frameworkcode" value="[% frameworkcode | html %]" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing 'issn' in the form |ISSN hidden input missing |post of 'z3950_search.tt' |from Z39.50 search form | |navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192475&action=edit Bug 41764: ISSN hidden input missing from Z39.50 search form navigation This patch modifies the Acquisitions and Cataloging Z39.50 search forms so that the pagination form includes a hidden ISSN input. This is necessary for the form to submit the same search parameters each time the user requests a new page of results. To test, apply the patch and go to Acquisitions. - Search for a vendor, and create a basket if necessary. - Add to the basket and choose "From an external source." - In the "ISSN" field, enter a partial ISSN number, e.g. 0361, and search. - At the bottom of the search results, click the "Next page" button. - The second page of results should load correctly. At the top of the table of results it should say "You searched for: ISSN: 0361" - Perform the same test in Cataloging: - Cataloging -> New from Z39.50/SRU Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Red Shen <darkranger_red@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darkranger_red@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 192577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192577&action=edit Bug 41764: ISSN hidden input missing from Z39.50 search form navigation This patch modifies the Acquisitions and Cataloging Z39.50 search forms so that the pagination form includes a hidden ISSN input. This is necessary for the form to submit the same search parameters each time the user requests a new page of results. To test, apply the patch and go to Acquisitions. - Search for a vendor, and create a basket if necessary. - Add to the basket and choose "From an external source." - In the "ISSN" field, enter a partial ISSN number, e.g. 0361, and search. - At the bottom of the search results, click the "Next page" button. - The second page of results should load correctly. At the top of the table of results it should say "You searched for: ISSN: 0361" - Perform the same test in Cataloging: - Cataloging -> New from Z39.50/SRU Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the Acquisitions release notes| |and Cataloging Z39.50 | |search forms so that the | |pagination works when | |searching using the ISSN | |input field. | | | |When you click the next | |page of results, or got to | |a specific result page, the | |search now works as | |expected - it remembers the | |ISSN you were searching | |for, with "You searched | |for: ISSN: XXXX" shown | |above the search results, | |and search results shown. | | | |Previously, the ISSN was | |not remembered, and | |"Nothing found. Try another | |search." was shown, and no | |further search results were | |shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192577|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192622&action=edit Bug 41764: ISSN hidden input missing from Z39.50 search form navigation This patch modifies the Acquisitions and Cataloging Z39.50 search forms so that the pagination form includes a hidden ISSN input. This is necessary for the form to submit the same search parameters each time the user requests a new page of results. To test, apply the patch and go to Acquisitions. - Search for a vendor, and create a basket if necessary. - Add to the basket and choose "From an external source." - In the "ISSN" field, enter a partial ISSN number, e.g. 0361, and search. - At the bottom of the search results, click the "Next page" button. - The second page of results should load correctly. At the top of the table of results it should say "You searched for: ISSN: 0361" - Perform the same test in Cataloging: - Cataloging -> New from Z39.50/SRU Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|26.05.00,25.11.03,25.05.09 |26.05.00,25.11.03,25.05.09, released in| |24.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11 for 24.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.05.00,25.11.03,25.05.09, |26.05.00,25.11.03,25.05.09, released in|24.11.15 |24.11.16 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Will instead be released in 24.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41764 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org