[Bug 35972] New: Using Course reserves module for Research table reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Bug ID: 35972 Summary: Using Course reserves module for Research table reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: mirjam.vantieghem@etf.edu QA Contact: testopia@bugs.koha-community.org Created attachment 161714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161714&action=edit Screenshot of example Research tables on OPAC Our library has research tables and lets patrons (mainly master students working on their thesis) keep items for a longer period on these tables. In order for both library staff and patrons to be able to quickly track down items, we are using the Course reserves module to set a certain research table as temporary location for a certain item. Because tables are not courses, we use a custom patch to have the research tables appear as a separate module on the OPAC. We use the authorized value category DEPARTMENT to distinguish courses from tables. The tables have a separate value "Research tables". Because some of the columns used for the course reserves are not relevant for the tables, we also change the display of these on the OPAC. The following columns are renamed: “Course #” => “Table #” “Instructors” => “Researcher” “Notes” => “Topic” And these columns are hidden: “Dept.”, “Section”, “Term”. Notes: 1) Because of possible privacy issues, we are no longer displaying the name of the researcher, so this column might also be hidden. 2) The topic is optional. Some like to see what others are doing research on. It also helps to know where to look for a book on a certain topic if it is not on the shelf, because keeping the 'table reserves' up to date is a bit of a challenge sometimes, depending on the cooperation of the patron. Ideally this should be a separate module on both the Staff client and the OPAC. It might be called 'Table reserves' if 'Research tables' is too specific. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161802&action=edit Bug 35972: Add thesis tables feature This patch adds a new 'Thesis tables' feature to Koha based on the existing 'Course reserves' system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161803&action=edit Bug 35972: Tidy for QA scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Attached are the commits as they currently exist. Some additional tidying and modernisation will need to take place before they would pass quality assurance, but I'm interested to get some testing done and guage interest before continuing with that work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tundun.folami@uwl.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using Course reserves |Add a 'Thesis tables' |module for Research table |feature, that builds upon |reserves |Course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a 'Thesis tables' |Add a 'Research tables' |feature, that builds upon |feature, that builds upon |Course reserves |Course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #4 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Wanted to see this in a sandbox, but it appears the patch failed to apply: Bug 35972 - Add a 'Research tables' feature, that builds upon Course reserves 161802 - Bug 35972: Add thesis tables feature 161803 - Bug 35972: Tidy for QA scripts Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 35972: Add thesis tables feature Using index info to reconstruct a base tree... M C4/CourseReserves.pm M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Falling back to patching base and 3-way merge... CONFLICT (add/add): Merge conflict in opac/opac-thesis-tables.pl Auto-merging opac/opac-thesis-tables.pl CONFLICT (add/add): Merge conflict in opac/opac-thesis-table-details.pl Auto-merging opac/opac-thesis-table-details.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Auto-merging C4/CourseReserves.pm CONFLICT (content): Merge conflict in C4/CourseReserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 35972: Add thesis tables feature [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-35972-Add-thesis-tables-feature-xerdsj5j.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12141 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like that this doesn't seem to duplicate a lot of the code, which is nice. It looks like the "course reserves" hits a nerve in multiple ways as there is also: Bug 12141 - On Display Module Some things/ideas from having a first look: * Terminology: Is there maybe a more general term we could use? Libraries might implement this as special shelves, carts, tables, desks, carrels, ... I think right now would be the best moment to give this some thought. * The code currently has a mix of research table in the GUI and thesis table in the code, showing a first rename I think. * If you are using course reserves, the new entry will show up in navigation right away. To avoid that, we could only show the navigation entry, if a course of that type exists. * Instead of re-using the department, could we imagine adding a "type" column driven by a new AV? We could then use the type to define displays for other use cases, like the "On display". We might even pull the description off the type... I know, translatability, but we could still have some harcoded "codes" like RT = research table in the templates to help adoption. * Should we adapt/rename the system preference (UseCourseReserves)? * Should we adapt OPAC detail view for reserve items (display text)? * Should we add to sample AV in installer? * Should we adapt permission description? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #5)
* Terminology: Is there maybe a more general term we could use? Libraries might implement this as special shelves, carts, tables, desks, carrels, ... I think right now would be the best moment to give this some thought.
I agree this could see a lot of varied use if the naming/labeling of it all is sufficiently broad or customizable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #7 from Mathieu Saby <mathsabypro@gmail.com> --- My library would be interested by this feature, I would like to test it. But from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972#c5 I understand it is better to wait for improvements before testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- There isn't any funding against this project as far as I'm aware so I'm not really sure when we might have the opportunity to further work on it. If people are keen to progress here I would suggest the first step is to formally submit a specification/proposal so we can ensure we're all working towards the same end goal and then perhaps we could split up the work between us and attract some funding. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192856&action=edit Bug 35972: Add thesis tables feature This patch adds a new 'Thesis tables' feature to Koha based on the existing 'Course reserves' system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192857&action=edit Bug 35972: Tidy for QA scripts Patch from commit bbcda38 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192858&action=edit Bug 35972: Add course_type column for flexible course displays This patch adds database infrastructure to support multiple course display types (course reserves, research tables, on display, etc.) instead of hardcoding "thesis tables" via department='TT'. Database changes: - Add course_type VARCHAR(80) column to courses table - Migrate existing department='TT' records to course_type='RESEARCH_TABLE' - Create CR_TYPE authorized value category with default values: * COURSE - Regular course reserves * RESEARCH_TABLE - Research/thesis tables * ON_DISPLAY - On display collections Schema changes: - Update kohastructure.sql with course_type column - Add CR_TYPE authorized values to sample data - Update Koha::Schema::Result::Course DBIx::Class schema This flexible architecture allows libraries to: - Customize terminology via authorized values (lib/lib_opac fields) - Add new display types without code changes - Support future features like Bug 12141 (On Display module) The course_type column uses authorized values from CR_TYPE category, with separate display text for staff interface (lib) and OPAC (lib_opac). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192859&action=edit Bug 35972: Refactor C4::CourseReserves to use course_type This patch refactors the CourseReserves module to use the new course_type column instead of hardcoded department='TT' checks. Changes to C4::CourseReserves: 1. SearchCourses(): - Now accepts course_type parameter instead of thesis_table - Added backward compatibility for thesis_table parameter - Removed hardcoded department='TT' filtering - Updated SELECT to include course_type column - Updated GROUP BY and ORDER BY to include course_type 2. GetCourses(): - Updated SELECT to include course_type column - Updated GROUP BY to include course_type 3. New function HasCoursesOfType(): - Returns true if any courses of specified type exist - Useful for conditional navigation display - Respects enabled parameter Backward compatibility: - thesis_table='yes' → course_type='RESEARCH_TABLE' - thesis_table='no' → course_type='COURSE' - Existing code using thesis_table parameter continues to work The refactoring removes all hardcoded assumptions about "thesis tables" and makes the system flexible to support any course type defined via authorized values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192860&action=edit Bug 35972: Implement dynamic course type display in OPAC This patch updates the OPAC to use dynamic display text from authorized values instead of hardcoded "Research tables" terminology. Changes to OPAC scripts: 1. opac-thesis-tables.pl: - Uses course_type='RESEARCH_TABLE' instead of thesis_table='yes' - Retrieves display text from authorised_values.lib_opac - Passes course_type_display to template 2. opac-thesis-table-details.pl: - Retrieves course type from course record - Looks up dynamic display text from authorized values - Passes course_type_display to template Changes to OPAC templates: 1. opac-thesis-tables.tt: - Replaced all hardcoded "Research tables" text - Now uses [% course_type_display | html %] variable - Displays terminology from CR_TYPE authorized values 2. opac-thesis-table-details.tt: - Updated breadcrumb to use dynamic display text 3. masthead.inc: - Moved "Research tables" link next to "Course reserves" - Removed duplicate link from suggestions section - Shows when UseCourseReserves preference is enabled - More logical navigation structure Benefits: - Libraries can customize terminology without code changes - Multilingual support via lib_opac field - Consistent with overall course type architecture - Supports future course types (On Display, etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 192861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192861&action=edit Bug 35972: Add course_type support to staff interface This patch adds course type selection and display to the staff interface for course reserves management. Changes to course scripts: 1. course.pl: - Pass course_types authorized values to template - Similar to existing departments and terms 2. mod_course.pl: - Capture course_type parameter from form submission - Default to 'COURSE' if not specified - Pass to ModCourse for database update Changes to staff templates: 1. course.tt (course creation/edit form): - Added course_type dropdown as first field (required) - Populates from CR_TYPE authorized values - Uses lib field for staff interface display text - Pre-selects current value when editing 2. course-reserves.tt (course listing): - Added "Type" column to course table - Displays course_type using AuthorisedValues.GetByCode - Positioned between "Name" and "Dept." columns 3. course-details.tt (course details view): - Added course type display in course information - Shows after course name, before term - Uses lib field from CR_TYPE authorized values Benefits for staff: - Clear indication of course type (regular, research table, on display) - Ability to filter/sort courses by type in listing - Easy selection when creating new courses - Consistent terminology via authorized values This completes the course_type implementation across both staff and OPAC interfaces, providing a unified flexible system for managing different types of course displays. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- Attempted to test. When accessing the "Research tables" link in the OPAC, I get this error: Template process failed: file error - columns_settings.inc: not found at /kohadevbox/koha/C4/Templates.pm line 146 Can successfully add different course reserve types. Testing notes so far (using KTD): 1. Go to Course reserves 2. Create a new course reserve (note that there is no current way to set a "course type") 3. Apply the patches 4. Update the database: updatedatabase 5. Update the structure: dbic (not sure if this is required - got error either way) 6. Restart everything: restart_all 7. Repeat step 2 8. Note that there is now a "Type" field with a dropdown list of options (uses authorized values from CR_TYPE category). 9. Create a new course using "Research table" as the type. 10. In the staff interface course reserves listing, there is now a "Type" column 11. In the OPAC, there is now a "Research tables" link after the "Course reserves" link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192856|0 |1 is obsolete| | Attachment #192857|0 |1 is obsolete| | Attachment #192858|0 |1 is obsolete| | Attachment #192859|0 |1 is obsolete| | Attachment #192860|0 |1 is obsolete| | Attachment #192861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198357&action=edit Bug 35972: Add thesis tables feature This patch adds a new 'Thesis tables' feature to Koha based on the existing 'Course reserves' system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198358&action=edit Bug 35972: Tidy for QA scripts Patch from commit ca0e6b8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198359&action=edit Bug 35972: Add course_type column for flexible course displays This patch adds database infrastructure to support multiple course display types (course reserves, research tables, on display, etc.) instead of hardcoding "thesis tables" via department='TT'. Database changes: - Add course_type VARCHAR(80) column to courses table - Migrate existing department='TT' records to course_type='RESEARCH_TABLE' - Create CR_TYPE authorized value category with default values: * COURSE - Regular course reserves * RESEARCH_TABLE - Research/thesis tables * ON_DISPLAY - On display collections Schema changes: - Update kohastructure.sql with course_type column - Add CR_TYPE authorized values to sample data - Update Koha::Schema::Result::Course DBIx::Class schema This flexible architecture allows libraries to: - Customize terminology via authorized values (lib/lib_opac fields) - Add new display types without code changes - Support future features like Bug 12141 (On Display module) The course_type column uses authorized values from CR_TYPE category, with separate display text for staff interface (lib) and OPAC (lib_opac). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198360&action=edit Bug 35972: Refactor C4::CourseReserves to use course_type This patch refactors the CourseReserves module to use the new course_type column instead of hardcoded department='TT' checks. Changes to C4::CourseReserves: 1. SearchCourses(): - Now accepts course_type parameter instead of thesis_table - Added backward compatibility for thesis_table parameter - Removed hardcoded department='TT' filtering - Updated SELECT to include course_type column - Updated GROUP BY and ORDER BY to include course_type 2. GetCourses(): - Updated SELECT to include course_type column - Updated GROUP BY to include course_type 3. New function HasCoursesOfType(): - Returns true if any courses of specified type exist - Useful for conditional navigation display - Respects enabled parameter Backward compatibility: - thesis_table='yes' → course_type='RESEARCH_TABLE' - thesis_table='no' → course_type='COURSE' - Existing code using thesis_table parameter continues to work The refactoring removes all hardcoded assumptions about "thesis tables" and makes the system flexible to support any course type defined via authorized values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198361&action=edit Bug 35972: Implement dynamic course type display in OPAC This patch updates the OPAC to use dynamic display text from authorized values instead of hardcoded "Research tables" terminology. Changes to OPAC scripts: 1. opac-thesis-tables.pl: - Uses course_type='RESEARCH_TABLE' instead of thesis_table='yes' - Retrieves display text from authorised_values.lib_opac - Passes course_type_display to template 2. opac-thesis-table-details.pl: - Retrieves course type from course record - Looks up dynamic display text from authorized values - Passes course_type_display to template Changes to OPAC templates: 1. opac-thesis-tables.tt: - Replaced all hardcoded "Research tables" text - Now uses [% course_type_display | html %] variable - Displays terminology from CR_TYPE authorized values 2. opac-thesis-table-details.tt: - Updated breadcrumb to use dynamic display text 3. masthead.inc: - Moved "Research tables" link next to "Course reserves" - Removed duplicate link from suggestions section - Shows when UseCourseReserves preference is enabled - More logical navigation structure Benefits: - Libraries can customize terminology without code changes - Multilingual support via lib_opac field - Consistent with overall course type architecture - Supports future course types (On Display, etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198362&action=edit Bug 35972: Add course_type support to staff interface This patch adds course type selection and display to the staff interface for course reserves management. Changes to course scripts: 1. course.pl: - Pass course_types authorized values to template - Similar to existing departments and terms 2. mod_course.pl: - Capture course_type parameter from form submission - Default to 'COURSE' if not specified - Pass to ModCourse for database update Changes to staff templates: 1. course.tt (course creation/edit form): - Added course_type dropdown as first field (required) - Populates from CR_TYPE authorized values - Uses lib field for staff interface display text - Pre-selects current value when editing 2. course-reserves.tt (course listing): - Added "Type" column to course table - Displays course_type using AuthorisedValues.GetByCode - Positioned between "Name" and "Dept." columns 3. course-details.tt (course details view): - Added course type display in course information - Shows after course name, before term - Uses lib field from CR_TYPE authorized values Benefits for staff: - Clear indication of course type (regular, research table, on display) - Ability to filter/sort courses by type in listing - Easy selection when creating new courses - Consistent terminology via authorized values This completes the course_type implementation across both staff and OPAC interfaces, providing a unified flexible system for managing different types of course displays. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 198363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198363&action=edit Bug 35972: (follow-up) QA and testing fixes Address QA warnings and feedback on the patch series: * opac-thesis-{tables,table-details}.tt: drop the staff-only columns_settings.inc include (caused "file error" in OPAC) and switch to the kohaTable + TablesSettings.GetTableSettings pattern used by opac-course-reserves.tt. Also drop the bogus Asset.css("css/datatables.css") reference and the obsolete title-string class (bug 27934), and add a dtr-control column for responsive expand. * admin/columns_settings.yml: register thesis_tables_table and thesis-table-items-table. * opac/opac-thesis-{tables,table-details}.pl: https:// for the GPL URL, drop debug => 1 and authnotrequired => 1 (bug 24663). * atomicupdate/bug_35972.pl: chmod +x for file_permissions QA. * mandatory/auth_val_cat.sql: register the CR_TYPE category so fresh installs don't fail the FK constraint when populate_db.pl loads auth_values.yml. * t/db_dependent/CourseReserves.t: use $builder->build_sample_biblio instead of AddBiblio($record, ''). Test plan: 1. Fresh ktd up succeeds, no FK errors on auth_values.yml. 2. Apply patches, updatedatabase, restart_all. 3. OPAC "Research tables" loads and the items detail page renders. 4. koha-qa.pl reports no forbidden_pattern / file_permissions hits. 5. prove t/db_dependent/CourseReserves.t -> 27/27 pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198357|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198359|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198360|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 198777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198777&action=edit Bug 35972: Add thesis tables feature This patch adds a new 'Thesis tables' feature to Koha based on the existing 'Course reserves' system. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 198778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198778&action=edit Bug 35972: Tidy for QA scripts Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 198779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198779&action=edit Bug 35972: Add course_type column for flexible course displays This patch adds database infrastructure to support multiple course display types (course reserves, research tables, on display, etc.) instead of hardcoding "thesis tables" via department='TT'. Database changes: - Add course_type VARCHAR(80) column to courses table - Migrate existing department='TT' records to course_type='RESEARCH_TABLE' - Create CR_TYPE authorized value category with default values: * COURSE - Regular course reserves * RESEARCH_TABLE - Research/thesis tables * ON_DISPLAY - On display collections Schema changes: - Update kohastructure.sql with course_type column - Add CR_TYPE authorized values to sample data - Update Koha::Schema::Result::Course DBIx::Class schema This flexible architecture allows libraries to: - Customize terminology via authorized values (lib/lib_opac fields) - Add new display types without code changes - Support future features like Bug 12141 (On Display module) The course_type column uses authorized values from CR_TYPE category, with separate display text for staff interface (lib) and OPAC (lib_opac). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 198780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198780&action=edit Bug 35972: Refactor C4::CourseReserves to use course_type This patch refactors the CourseReserves module to use the new course_type column instead of hardcoded department='TT' checks. Changes to C4::CourseReserves: 1. SearchCourses(): - Now accepts course_type parameter instead of thesis_table - Added backward compatibility for thesis_table parameter - Removed hardcoded department='TT' filtering - Updated SELECT to include course_type column - Updated GROUP BY and ORDER BY to include course_type 2. GetCourses(): - Updated SELECT to include course_type column - Updated GROUP BY to include course_type 3. New function HasCoursesOfType(): - Returns true if any courses of specified type exist - Useful for conditional navigation display - Respects enabled parameter Backward compatibility: - thesis_table='yes' → course_type='RESEARCH_TABLE' - thesis_table='no' → course_type='COURSE' - Existing code using thesis_table parameter continues to work The refactoring removes all hardcoded assumptions about "thesis tables" and makes the system flexible to support any course type defined via authorized values. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 198781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198781&action=edit Bug 35972: Implement dynamic course type display in OPAC This patch updates the OPAC to use dynamic display text from authorized values instead of hardcoded "Research tables" terminology. Changes to OPAC scripts: 1. opac-thesis-tables.pl: - Uses course_type='RESEARCH_TABLE' instead of thesis_table='yes' - Retrieves display text from authorised_values.lib_opac - Passes course_type_display to template 2. opac-thesis-table-details.pl: - Retrieves course type from course record - Looks up dynamic display text from authorized values - Passes course_type_display to template Changes to OPAC templates: 1. opac-thesis-tables.tt: - Replaced all hardcoded "Research tables" text - Now uses [% course_type_display | html %] variable - Displays terminology from CR_TYPE authorized values 2. opac-thesis-table-details.tt: - Updated breadcrumb to use dynamic display text 3. masthead.inc: - Moved "Research tables" link next to "Course reserves" - Removed duplicate link from suggestions section - Shows when UseCourseReserves preference is enabled - More logical navigation structure Benefits: - Libraries can customize terminology without code changes - Multilingual support via lib_opac field - Consistent with overall course type architecture - Supports future course types (On Display, etc.) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 198782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198782&action=edit Bug 35972: Add course_type support to staff interface This patch adds course type selection and display to the staff interface for course reserves management. Changes to course scripts: 1. course.pl: - Pass course_types authorized values to template - Similar to existing departments and terms 2. mod_course.pl: - Capture course_type parameter from form submission - Default to 'COURSE' if not specified - Pass to ModCourse for database update Changes to staff templates: 1. course.tt (course creation/edit form): - Added course_type dropdown as first field (required) - Populates from CR_TYPE authorized values - Uses lib field for staff interface display text - Pre-selects current value when editing 2. course-reserves.tt (course listing): - Added "Type" column to course table - Displays course_type using AuthorisedValues.GetByCode - Positioned between "Name" and "Dept." columns 3. course-details.tt (course details view): - Added course type display in course information - Shows after course name, before term - Uses lib field from CR_TYPE authorized values Benefits for staff: - Clear indication of course type (regular, research table, on display) - Ability to filter/sort courses by type in listing - Easy selection when creating new courses - Consistent terminology via authorized values This completes the course_type implementation across both staff and OPAC interfaces, providing a unified flexible system for managing different types of course displays. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #29 from David Nind <david@davidnind.com> --- Created attachment 198783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198783&action=edit Bug 35972: (follow-up) QA and testing fixes Address QA warnings and feedback on the patch series: * opac-thesis-{tables,table-details}.tt: drop the staff-only columns_settings.inc include (caused "file error" in OPAC) and switch to the kohaTable + TablesSettings.GetTableSettings pattern used by opac-course-reserves.tt. Also drop the bogus Asset.css("css/datatables.css") reference and the obsolete title-string class (bug 27934), and add a dtr-control column for responsive expand. * admin/columns_settings.yml: register thesis_tables_table and thesis-table-items-table. * opac/opac-thesis-{tables,table-details}.pl: https:// for the GPL URL, drop debug => 1 and authnotrequired => 1 (bug 24663). * atomicupdate/bug_35972.pl: chmod +x for file_permissions QA. * mandatory/auth_val_cat.sql: register the CR_TYPE category so fresh installs don't fail the FK constraint when populate_db.pl loads auth_values.yml. * t/db_dependent/CourseReserves.t: use $builder->build_sample_biblio instead of AddBiblio($record, ''). Test plan: 1. Fresh ktd up succeeds, no FK errors on auth_values.yml. 2. Apply patches, updatedatabase, restart_all. 3. OPAC "Research tables" loads and the items detail page renders. 4. koha-qa.pl reports no forbidden_pattern / file_permissions hits. 5. prove t/db_dependent/CourseReserves.t -> 27/27 pass. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement builds on release notes| |the course reserves feature | |to: | |- Allow categorizing course | |reserves (using a new | |CR_TYPE authorized value | |category) | |- Show the "Research | |tables" course reserves | |category type as a separate | |link after course reserves | |in the OPAC (under the | |search header) | | | |When creating course | |reserves you can now choose | |the course reserve type. | |The default course reserve | |types (from the new | |CR_TYPES authorized values | |category) are: | |- Course reserve (all | |existing course reserves | |use this category) | |- On display | |- Research table (for | |things like thesis) | | | |In the OPAC, the research | |table course reserves type | |are show under their own | |link "Research tables", | |which is shown after | |"Course reserves" under the | |OPAC search box. | | | |In the staff interface, | |there is a new column | |"Type" in the course | |reserves list, and this | |values is also shown on the | |course reserves page | |listing. --- Comment #30 from David Nind <david@davidnind.com> --- Looks good to me, and everything worked as expected. The only comment I have is adding a description for the CR_TYPE authorized value category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199117&action=edit Bug 35972: Add thesis tables feature This patch adds a new 'Thesis tables' feature to Koha based on the existing 'Course reserves' system. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199118&action=edit Bug 35972: Tidy for QA scripts Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199119&action=edit Bug 35972: Add course_type column for flexible course displays This patch adds database infrastructure to support multiple course display types (course reserves, research tables, on display, etc.) instead of hardcoding "thesis tables" via department='TT'. Database changes: - Add course_type VARCHAR(80) column to courses table - Migrate existing department='TT' records to course_type='RESEARCH_TABLE' - Create CR_TYPE authorized value category with default values: * COURSE - Regular course reserves * RESEARCH_TABLE - Research/thesis tables * ON_DISPLAY - On display collections Schema changes: - Update kohastructure.sql with course_type column - Add CR_TYPE authorized values to sample data - Update Koha::Schema::Result::Course DBIx::Class schema This flexible architecture allows libraries to: - Customize terminology via authorized values (lib/lib_opac fields) - Add new display types without code changes - Support future features like Bug 12141 (On Display module) The course_type column uses authorized values from CR_TYPE category, with separate display text for staff interface (lib) and OPAC (lib_opac). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199120&action=edit Bug 35972: Refactor C4::CourseReserves to use course_type This patch refactors the CourseReserves module to use the new course_type column instead of hardcoded department='TT' checks. Changes to C4::CourseReserves: 1. SearchCourses(): - Now accepts course_type parameter instead of thesis_table - Added backward compatibility for thesis_table parameter - Removed hardcoded department='TT' filtering - Updated SELECT to include course_type column - Updated GROUP BY and ORDER BY to include course_type 2. GetCourses(): - Updated SELECT to include course_type column - Updated GROUP BY to include course_type 3. New function HasCoursesOfType(): - Returns true if any courses of specified type exist - Useful for conditional navigation display - Respects enabled parameter Backward compatibility: - thesis_table='yes' → course_type='RESEARCH_TABLE' - thesis_table='no' → course_type='COURSE' - Existing code using thesis_table parameter continues to work The refactoring removes all hardcoded assumptions about "thesis tables" and makes the system flexible to support any course type defined via authorized values. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199121&action=edit Bug 35972: Implement dynamic course type display in OPAC This patch updates the OPAC to use dynamic display text from authorized values instead of hardcoded "Research tables" terminology. Changes to OPAC scripts: 1. opac-thesis-tables.pl: - Uses course_type='RESEARCH_TABLE' instead of thesis_table='yes' - Retrieves display text from authorised_values.lib_opac - Passes course_type_display to template 2. opac-thesis-table-details.pl: - Retrieves course type from course record - Looks up dynamic display text from authorized values - Passes course_type_display to template Changes to OPAC templates: 1. opac-thesis-tables.tt: - Replaced all hardcoded "Research tables" text - Now uses [% course_type_display | html %] variable - Displays terminology from CR_TYPE authorized values 2. opac-thesis-table-details.tt: - Updated breadcrumb to use dynamic display text 3. masthead.inc: - Moved "Research tables" link next to "Course reserves" - Removed duplicate link from suggestions section - Shows when UseCourseReserves preference is enabled - More logical navigation structure Benefits: - Libraries can customize terminology without code changes - Multilingual support via lib_opac field - Consistent with overall course type architecture - Supports future course types (On Display, etc.) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199122&action=edit Bug 35972: Add course_type support to staff interface This patch adds course type selection and display to the staff interface for course reserves management. Changes to course scripts: 1. course.pl: - Pass course_types authorized values to template - Similar to existing departments and terms 2. mod_course.pl: - Capture course_type parameter from form submission - Default to 'COURSE' if not specified - Pass to ModCourse for database update Changes to staff templates: 1. course.tt (course creation/edit form): - Added course_type dropdown as first field (required) - Populates from CR_TYPE authorized values - Uses lib field for staff interface display text - Pre-selects current value when editing 2. course-reserves.tt (course listing): - Added "Type" column to course table - Displays course_type using AuthorisedValues.GetByCode - Positioned between "Name" and "Dept." columns 3. course-details.tt (course details view): - Added course type display in course information - Shows after course name, before term - Uses lib field from CR_TYPE authorized values Benefits for staff: - Clear indication of course type (regular, research table, on display) - Ability to filter/sort courses by type in listing - Easy selection when creating new courses - Consistent terminology via authorized values This completes the course_type implementation across both staff and OPAC interfaces, providing a unified flexible system for managing different types of course displays. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199123&action=edit Bug 35972: (follow-up) QA and testing fixes Address QA warnings and feedback on the patch series: * opac-thesis-{tables,table-details}.tt: drop the staff-only columns_settings.inc include (caused "file error" in OPAC) and switch to the kohaTable + TablesSettings.GetTableSettings pattern used by opac-course-reserves.tt. Also drop the bogus Asset.css("css/datatables.css") reference and the obsolete title-string class (bug 27934), and add a dtr-control column for responsive expand. * admin/columns_settings.yml: register thesis_tables_table and thesis-table-items-table. * opac/opac-thesis-{tables,table-details}.pl: https:// for the GPL URL, drop debug => 1 and authnotrequired => 1 (bug 24663). * atomicupdate/bug_35972.pl: chmod +x for file_permissions QA. * mandatory/auth_val_cat.sql: register the CR_TYPE category so fresh installs don't fail the FK constraint when populate_db.pl loads auth_values.yml. * t/db_dependent/CourseReserves.t: use $builder->build_sample_biblio instead of AddBiblio($record, ''). Test plan: 1. Fresh ktd up succeeds, no FK errors on auth_values.yml. 2. Apply patches, updatedatabase, restart_all. 3. OPAC "Research tables" loads and the items detail page renders. 4. koha-qa.pl reports no forbidden_pattern / file_permissions hits. 5. prove t/db_dependent/CourseReserves.t -> 27/27 pass. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199124&action=edit Bug 35972: Add CR_TYPE authorised value category description Add a simple description for CR_TYPE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #39 from David Cook <dcook@prosentient.com.au> --- What's a "Research table"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #40 from Mirjam Vantieghem <mirjam.vantieghem@etf.edu> --- (In reply to David Cook from comment #39)
What's a "Research table"?
See original description (now hidden): "Our library has research tables and lets patrons (mainly master students working on their thesis) keep items for a longer period on these tables. In order for both library staff and patrons to be able to quickly track down items, we are using the Course reserves module to set a certain research table as temporary location for a certain item." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement builds on |This enhancement builds on release notes|the course reserves feature |the course reserves feature |to: |to: |- Allow categorizing course |- Allow categorizing course |reserves (using a new |reserves (using a new |CR_TYPE authorized value |CR_TYPE authorized value |category) |category) |- Show the "Research |- Show the "Research |tables" course reserves |tables" course reserves |category type as a separate |category type as a separate |link after course reserves |link after course reserves |in the OPAC (under the |in the OPAC (under the |search header) |search header) | | |When creating course |When creating course |reserves you can now choose |reserves you can now choose |the course reserve type. |the course reserve type. |The default course reserve |The default course reserve |types (from the new |types (from the new |CR_TYPES authorized values |CR_TYPES authorized values |category) are: |category) are: |- Course reserve (all |- Course reserve (all |existing course reserves |existing course reserves |use this category) |use this category) |- On display |- On display |- Research table (for |- Research table (for |things like thesis) |things like thesis) | | |In the OPAC, the research |In the OPAC, the research |table course reserves type |table course reserves type |are show under their own |is shown under its own link |link "Research tables", |"Research tables", which is |which is shown after |shown after "Course |"Course reserves" under the |reserves" under the OPAC |OPAC search box. |search box. | | |In the staff interface, |In the staff interface, |there is a new column |there is a new column |"Type" in the course |"Type" in the course |reserves list, and this |reserves list, and this |values is also shown on the |value is also shown on the |course reserves page |course reserves page |listing. |listing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #41 from David Cook <dcook@prosentient.com.au> --- (In reply to Mirjam Vantieghem from comment #40)
(In reply to David Cook from comment #39)
What's a "Research table"?
See original description (now hidden): "Our library has research tables and lets patrons (mainly master students working on their thesis) keep items for a longer period on these tables. In order for both library staff and patrons to be able to quickly track down items, we are using the Course reserves module to set a certain research table as temporary location for a certain item."
Interesting. Why expose this information on the OPAC? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #42 from Mirjam Vantieghem <mirjam.vantieghem@etf.edu> --- (In reply to David Cook from comment #41)
(In reply to Mirjam Vantieghem from comment #40)
(In reply to David Cook from comment #39)
What's a "Research table"?
See original description (now hidden): "Our library has research tables and lets patrons (mainly master students working on their thesis) keep items for a longer period on these tables. In order for both library staff and patrons to be able to quickly track down items, we are using the Course reserves module to set a certain research table as temporary location for a certain item."
Interesting. Why expose this information on the OPAC?
We don't expose the patron's name, only the table number and the items that are on this table*, in order for also other patrons (mostly other students in our case) to be able to see where these books are, so they don't loose time looking for them on the shelves. In the past we 'checked out' these books to the table, but then other patrons could not see where these books were and they were thus not available to others. Most students work at least one year on their master's thesis, so that's a long time for these books to be unavailable. Patrons are not allowed to take books from a research table, but they are allowed to consult them at the table. *in most cases we also display the research topic, so if a certain book is missing that deals with this topic, library staff and patrons know where to look for it first. And students usually find it interesting to see the topics others are working on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35972 --- Comment #43 from Mirjam Vantieghem <mirjam.vantieghem@etf.edu> --- (In reply to Mirjam Vantieghem from comment #42)
(In reply to David Cook from comment #41)
(In reply to Mirjam Vantieghem from comment #40)
(In reply to David Cook from comment #39)
What's a "Research table"?
See original description (now hidden): "Our library has research tables and lets patrons (mainly master students working on their thesis) keep items for a longer period on these tables. In order for both library staff and patrons to be able to quickly track down items, we are using the Course reserves module to set a certain research table as temporary location for a certain item."
Interesting. Why expose this information on the OPAC?
We don't expose the patron's name, only the table number and the items that are on this table*, in order for also other patrons (mostly other students in our case) to be able to see where these books are, so they don't loose time looking for them on the shelves. In the past we 'checked out' these books to the table, but then other patrons could not see where these books were and they were thus not available to others. Most students work at least one year on their master's thesis, so that's a long time for these books to be unavailable. Patrons are not allowed to take books from a research table, but they are allowed to consult them at the table.
*in most cases we also display the research topic, so if a certain book is missing that deals with this topic, library staff and patrons know where to look for it first. And students usually find it interesting to see the topics others are working on.
Extra reason I forgot to mention: in our case the registered user of the research table needs to inform us when they add to/remove books from the table so that library staff can update it in the system. The user has no access to the Staff client (and shouldn't have), so the only way for them to know what is already registered to their table is by checking the research table page on the OPAC. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org