[Bug 8915] New: Referential integrity constraints and InnoDB vs MyISAM storage engine
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Priority: P5 - low Change sponsored?: --- Bug ID: 8915 Assignee: gmcharlt@gmail.com Summary: Referential integrity constraints and InnoDB vs MyISAM storage engine Severity: enhancement Classification: Unclassified OS: All Reporter: frederic@tamil.fr Hardware: All Status: NEW Version: rel_3_10 Component: Architecture, internals, and plumbing Product: Koha An increasing number of Koha functionalities rely on database level referential integrity constraints. For example, see bug 1963, when a biblio record is deleted, it is also deleted in all the virtual shelves containing it. If you do: SHOW CREATE TABLE virtualshelfcontents you see this specific constraint: CONSTRAINT shelfcontents_ibfk_2 FOREIGN KEY biblionumber REFERENCES biblio (biblionumber) ON DELETE CASCADE ON UPDATE CASCADE, Depending on MySQL storage engine, constraints are supported or not. InnoDB support referential integrity constraints, MyISAM doesn't. Since version 5.1, MySQL default storage engine is InnoDB. Prior to this version, MyISAM was the default engine. So depending on various parameters, a Koha DB can contain MyISAM tables, therefore without integrity constraints, when those constraints are required by Koha for proper operations. Those parameters are: - Old Koha DB can have been created at first place with MyISAM engine, and never upgraded to InnoDB. - The upgrade to InnoDB can have been done later, but some constraints have been added by updatedatabase.pl when tables was still MyISAM. - The InnoDB can be silently disabled on the server: DBA choice, bad my.cnf configuration, etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1963 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 12799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12799&action=edit Script fixing missing constraints -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12799|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 12804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12804&action=edit Script fixing missing constraints -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Standalone script, does what it says it does, and needs a confirmation switch to run. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12804|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13166&action=edit Bug 8915 A script fixing missing MySQL contraints Help: fix_mysql_contraints.pl -h Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13342&action=edit Bug 8915: Followup FIX QA issues Before this patch: * misc/maintenance/fix_mysql_constraints.pl FAIL pod FAIL *** ERROR: unterminated B<...> in file misc/maintenance/fix_mysql_constraints.pl forbidden patterns OK valid OK critic FAIL "require" statement with library name as string at line 25, column 12. Use a bareword instead. + I add a die on the open statement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Chris and Frédéric, Could one of you confirm that you agree with my patch ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13342|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13355&action=edit Bug 8915: Followup FIX QA issues Before this patch: * misc/maintenance/fix_mysql_constraints.pl FAIL pod FAIL *** ERROR: unterminated B<...> in file misc/maintenance/fix_mysql_constraints.pl forbidden patterns OK valid OK critic FAIL "require" statement with library name as string at line 25, column 12. Use a bareword instead. + I add a die on the open statement Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thanks Kyle. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8915 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org