[Bug 6428] New: refered column 'items.coded_location_qualifier' does not exist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Bug #: 6428 Summary: refered column 'items.coded_location_qualifier' does not exist Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Database AssignedTo: gmcharlt@gmail.com ReportedBy: mtj@kohaaloha.com QAContact: koha-bugs@lists.koha-community.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #1 from James, Mason <mtj@kohaaloha.com> 2011-05-30 07:40:43 UTC --- missing column is referered to in 23 framework files koha.git:$ grep -irl 'coded_location_qualifier' ./* |wc -l 23 http://git.koha-community.org/cgi-bin/gitweb.cgi?p=koha.git;a=blob;f=install... and causes additem.pl to fail sometimes [Mon May 30 15:11:49 2011] additem.pl: DBD::mysql::st execute failed: Unknown column 'coded_location_qualifier' in 'field list' at /home/koha/koha.git/C4/Items.pm line 2088. [Mon May 30 15:11:49 2011] additem.pl: ERROR in _koha_modify_item UPDATE items SET restricted=?,items.cn_sort=?,wthdrawn=?,coded_location_qualifier=?,notforloan=?,replacementpricedate=?,itemnumber=?,itemnotes=?,ccode=?,location=?,itemcallnumber=?,stack=?,itemlost=?,barcode=?,uri=?,items.cn_source=?,materials=?,datelastseen=?,price=?,issues=?,homebranch=?,replacementprice=?,more_subfields_xml=?,holdingbranch=?,booksellerid=?,damaged=?,stocknumber=?,datelastborrowed=?,dateaccessioned=?,enumchron=?,copynumber=?,permanent_location=?,itype=?,paidfor=? WHERE itemnumber=?Unknown column 'coded_location_qualifier' in 'field list' at /home/koha/koha.git/C4/Items.pm line 2091. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #2 from James, Mason <mtj@kohaaloha.com> 2011-05-30 08:09:57 UTC --- i'm not sure what the fix is here... the missing column is not refered to *explicilty* in any code either. so, we either remove the rows from the framework 'marc_subfield_structure' table or, add the missing column to the items table -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #3 from James, Mason <mtj@kohaaloha.com> 2011-05-30 23:16:17 UTC --- hmm, an old email thread on the missing 'items.items.coded_location_qualifier' column hints that its something to ignore http://koha.1045719.n5.nabble.com/What-is-the-coded-location-qualifier-in-95... ------------------------------------------------- Re: What is the coded location qualifier in 952 $f Practical answer: a field to ignore entirely ;) Long answer: It's probably derived from the MARC21 definition of the 852 $f, also called "coded location qualifier", which is meant to encode a situation where most of the items in a run of a serial are held in a location (e.g., the magazine stacks) with a few held in a second location (the new magazines area). For the gory details, please see: http://www.loc.gov/marc/holdings/hd852.html Koha doesn't do anything with that subfield, and certainly makes no attempt to parse the coding. Regards, Galen ------------------------------------------------- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #4 from James, Mason <mtj@kohaaloha.com> 2011-05-30 23:33:53 UTC --- (In reply to comment #2)
i'm not sure what the fix is here...
the missing column is not refered to *explicilty* in any code either.
so, we either remove the rows from the framework 'marc_subfield_structure' table or, add the missing column to the items table
i have a better idea for this fix ;) lets leave the 952$f defined in the frameworks (as it is in the LOC specs) but remove the buggy reference to the 'items.coded_location_qualifier' column patch attached.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #5 from James, Mason <mtj@kohaaloha.com> 2011-05-30 23:36:15 UTC --- Created attachment 4310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4310 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 James, Mason <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4310|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-15 08:28:29 UTC --- Created attachment 4474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4474 [SIGNED-OFF] bug 6428: remove mapping to non-existent field in frameworks To test: - add a new title and an item with coded location qualifier and barcode - save item - ! 952$f will not be saved, but item and barcode will be created - edit item, fill 952$f and change barcode, save - ! changes will not be saved Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-06-15 08:31:46 UTC --- This patch will only work for new installations. Do we need a follow-up with a database update for existing installations? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #8 from James, Mason <mtj@kohaaloha.com> 2011-07-20 15:30:08 UTC --- (In reply to comment #7)
This patch will only work for new installations. Do we need a follow-up with a database update for existing installations?
indeed, i'll add a patch to fix existing systems too... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #9 from James, Mason <mtj@kohaaloha.com> 2011-07-20 15:34:44 UTC --- Created attachment 4678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4678 patch for existing Kohas applied to 6e2e58107f2347ec87281414fb0e5e12bf7806bf -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 James, Mason <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 M. James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_4 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4678|0 |1 is obsolete| | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-04 08:56:12 UTC --- Created attachment 4835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4835 Signed follow up patch (db rev) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|rel_3_4 |master Patch Status|Needs Signoff |Signed Off Severity|major |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com AssignedTo|gmcharlt@gmail.com |mtj@kohaaloha.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 12:09:54 UTC --- Mason, could you sent an updated patch please, this one doesn't apply anymore. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #12 from Mason James <mtj@kohaaloha.com> 2011-10-08 11:15:07 UTC --- Created attachment 5793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5793 pix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #13 from Mason James <mtj@kohaaloha.com> 2011-10-08 12:02:58 UTC --- (In reply to comment #11)
Mason, could you sent an updated patch please, this one doesn't apply anymore.
yes, no problem my new patch combines both of my old patches (4835, 4474), and is applied to commit cfe8b6bd9a4f1921cb728d784083300344bcf2b1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4474|0 |1 is obsolete| | Attachment #4835|0 |1 is obsolete| | Attachment #5793|0 |1 is obsolete| | --- Comment #14 from Mason James <mtj@kohaaloha.com> 2011-10-08 12:04:46 UTC --- Created attachment 5795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5795 patch ps, ignore that pix attachment, its for a different bug ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Does not apply |Pushed For QA Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-13 13:04:49 UTC --- Mason, you've updated the status to "pushed for QA". Shouldn't it be "needs signoff" -or "signed-off"(needs QA) ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Pushed For QA |Signed Off --- Comment #16 from Mason James <mtj@kohaaloha.com> 2011-10-13 17:25:39 UTC --- (In reply to comment #15)
Mason, you've updated the status to "pushed for QA". Shouldn't it be "needs signoff" -or "signed-off"(needs QA) ?
oops! good spotting Paul :) yep, i've corrected the status to 'signed-off' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-14 09:50:33 UTC --- QA comments: There are a few references to the coded_location_qualifier field: installer/data/Pg/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'BKS', '', '', NULL), installer/data/Pg/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'CF', '', '', NULL), installer/data/Pg/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'SR', '', '', NULL), installer/data/Pg/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'VR', '', '', NULL), installer/data/Pg/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'AR', '', '', NULL), installer/data/Pg/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'KT', '', '', NULL), installer/data/Pg/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'IR', '', '', NULL), installer/data/Pg/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'SER', '', '', NULL), installer/data/Pg/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 1, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, '', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_fastadd_framework.sql: ('952','f','Coded location qualifier','Coded location qualifier',0,0,'items.coded_location_qualifier',10,'','','',NULL,0,'FA','',NULL,NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'BKS', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'CF', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'SR', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'VR', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'AR', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'KT', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'IR', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, 'SER', '', '', NULL), installer/data/mysql/es-ES/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql: ('952', 'f', 'Coded location qualifier', 'Coded location qualifier', 0, 0, 'items.coded_location_qualifier', 10, '', '', '', NULL, 0, '', '', '', NULL), Could you remove them as well ? The updatedatabase SQL says : installer/data/mysql/updatedatabase.pl: $dbh->do("UPDATE marc_subfield_structure SET kohafield = NULL WHERE tagfield = 952 AND tagsubfield = 'f' AND kohafield = 'items.coded_location_qualifier'"); That won't fix the bug with someone having moved this reference in another field. I think this can happend only in theory and wouldn't have marked failed QA just for this, but as you'll have to add some forgotten references, you can also update the SQL (or object/argue if you think i'm wrong) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Nuño López Ansótegui <nunyo@masmedios.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion CC| |nunyo@masmedios.com --- Comment #18 from Nuño López Ansótegui <nunyo@masmedios.com> --- This bug is yet active, the solution would so easy as add the column 'items.coded_location_qualifier'. Where is the problem? I don´t understand -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #18)
This bug is yet active, the solution would so easy as add the column 'items.coded_location_qualifier'. Where is the problem? I don´t understand
Nuno, The problem is that I made some comments about mistakes in the patch, and No-one (hey, mason, are you here ?) took care of my comments. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Nuño López Ansótegui <nunyo@masmedios.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5795|0 |1 is obsolete| | Status|In Discussion |Needs Signoff Assignee|mtj@kohaaloha.com |nunyo@masmedios.com --- Comment #20 from Nuño López Ansótegui <nunyo@masmedios.com> --- Created attachment 13005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13005&action=edit proposed patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Nuño López Ansótegui <nunyo@masmedios.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Nuño López Ansótegui <nunyo@masmedios.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13005|0 |1 is obsolete| | --- Comment #21 from Nuño López Ansótegui <nunyo@masmedios.com> --- Created attachment 13008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13008&action=edit fixed patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Nuño López Ansótegui <nunyo@masmedios.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13222&action=edit [SIGNED-OFF] Bug 6428 - refered column 'items.coded_location_qualifier' does not exist Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13008|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | --- Comment #23 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #22)
Created attachment 13222 [details] [SIGNED-OFF] Bug 6428 - refered column 'items.coded_location_qualifier' does not exist
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
tested OK, passing QA... thanks for the patch Nuño! :) $ koha-qa.pl -c 1 testing 1 commit(s) (applied to 9ace63b 'Bug 9001: Remove Zebraqueue_daemon ') 7bcc447 Bug 6428 - refered column 'items.coded_location_qualifier' does not exist - C4/Items.pm - installer/data/mysql/kohastructure.sql - installer/data/mysql/updatedatabase.pl * C4/Items.pm OK * installer/data/mysql/updatedatabase.pl OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #24 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think there is a bigger problem with this patch - only the table items is altered, but deleteditems is not. Removing 'pushed to master' - I think we need another patch here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|critical |blocker --- Comment #26 from Chris Cormack <chris@bigballofwax.co.nz> --- I agree this needs to be reverted or fixed before the release, with mismatched tables deleted items are not copied. This results in data loss, updating to blocker. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #27 from Nuño López Ansótegui <nunyo@masmedios.com> --- Created attachment 13387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13387&action=edit affix to patch Added coded_´location_qualifier´ column to `deleteitems`. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Nuño López Ansótegui <nunyo@masmedios.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13387|0 |1 is obsolete| | --- Comment #28 from Nuño López Ansótegui <nunyo@masmedios.com> --- Created attachment 13388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13388&action=edit affix to patch 644 instead of 755 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you for your follow-up! Can you please also it do updatedatabase as well? As it's already pushed I am not sure if we can just change the original one or better do a new database update statement, maybe we can get some other opinion on this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Nuño López Ansótegui <nunyo@masmedios.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13388|0 |1 is obsolete| | --- Comment #30 from Nuño López Ansótegui <nunyo@masmedios.com> --- Created attachment 13391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13391&action=edit affix to patch updatedatabase added -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #31 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- It must be a new database revision. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #32 from Paul Poulain <paul.poulain@biblibre.com> --- The follow-up need signoff (I haven't tested it myself yet) waiting for the follow-up to be pushed to master before pushing the main patch to 3.10.x branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13391|0 |1 is obsolete| | --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13401&action=edit [SIGNED-OFF] Bug 6428 [Follow-up] refered column 'items.coded_location_qualifier' does not exist - affix Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Same as previous patch. Normally the new column has to be positionned in the table after another field in order to have the same structure as in kohastructure.pl The first patch has been pushed like this so I supposed this one could be pushed like this too. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Nuño López Ansótegui <nunyo@masmedios.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13401|0 |1 is obsolete| | --- Comment #35 from Nuño López Ansótegui <nunyo@masmedios.com> --- Created attachment 13419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13419&action=edit Bug 6428 [Follow-up] refered column 'items.coded_location_qualifier' does not exist You're right, I uploaded the new patch with this change, thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13222|0 |1 is obsolete| | Attachment #13419|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13420&action=edit Bug 6428 [Follow-up] refered column 'items.coded_location_qualifier' does not exist Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #37 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 --- Comment #38 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #39 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org