[Bug 30837] New: The 'Print summary' feature defaults to very wide tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Bug ID: 30837 Summary: The 'Print summary' feature defaults to very wide tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The tables present on the 'Print summary' option are incredibly wide and unwieldy. This leads to prints getting truncated or defaulting to landscape and a tiny zoom level. We should be able to make these tables fit more manageable onto the print page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- It looks to me like the table gets a fixed width when the page is rendered, and that width is kept both when you resize the browser window, and when the page is printed. When the browser window is at full width, I see this in the "developer tools" view of the page: <table id="print-summary-checkouts" class="dataTable" role="grid" style="width: 1923px;"> <thead> <tr role="row"> <th class="sorting_asc" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-sort="ascending" aria-label="Title: activate to sort column descending" style="width: 740.5px;">Title</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Author: activate to sort column ascending" style="width: 211.5px;">Author</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Call number: activate to sort column ascending" style="width: 192.5px;">Call number</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Item type: activate to sort column ascending" style="width: 280.5px;">Item type</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Date due: activate to sort column ascending" style="width: 148.5px;">Date due</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Barcode: activate to sort column ascending" style="width: 190.5px;">Barcode</th> </tr> If i resize the window, the numbers are different: <table id="print-summary-checkouts" class="dataTable" role="grid" style="width: 1152px;"> <thead> <tr role="row"><th class="sorting_asc" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-sort="ascending" aria-label="Title: activate to sort column descending" style="width: 432.5px;">Title</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Author: activate to sort column ascending" style="width: 116.5px;">Author</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Call number: activate to sort column ascending" style="width: 104.5px;">Call number</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Item type: activate to sort column ascending" style="width: 157.5px;">Item type</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Date due: activate to sort column ascending" style="width: 78.5px;">Date due</th> <th class="sorting" tabindex="0" aria-controls="print-summary-checkouts" rowspan="1" colspan="1" aria-label="Barcode: activate to sort column ascending" style="width: 103.5px;">Barcode</th> </tr> I checked a site running 21.05.05 and it looks better there. The table looks like a "regular" table, without the "Columns" link next to the title, and without sortable columns. Maybe related to bug 28450? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The 'Print summary' feature |Fix table width on 'Print |defaults to very wide |summary' |tables | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 135300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135300&action=edit Bug 30837 - Fix table width on 'Print summary' To reproduce: - Make sure you have a patron with at least one checkout, one hold and one fine - On the detail page for that patron, go to Print > Print summary - Observe the tables are too wide to fit on a printed page To test: - Apply this patch - Repeat the steps above - Observe the table now fits on the page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Thanks to Owen for suggesting the fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|cnighswonger@foundations.ed |oleonard@myacpl.org |u | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135300|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135301&action=edit Bug 30837 - Fix table width on 'Print summary' To reproduce: - Make sure you have a patron with at least one checkout, one hold and one fine - On the detail page for that patron, go to Print > Print summary - Observe the tables are too wide to fit on a printed page To test: - Apply this patch - Repeat the steps above - Observe the table now fits on the page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Wow, I was trying to get way too clever with this.. nice one Magnus! Straight PQA, trivial and effective fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the width of the release notes| |table for the print summary | |so that it fits the width | |of the page. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Dont forget to format commit message not like Bug report : https://wiki.koha-community.org/wiki/Commit_messages#Subject_line Should be : Bug 30837: Fix table width on 'Print summary' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Magnus, If you'd like this one in 22.05.x I'm happy to backport it. Could you fix the commit title first? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Please backport until 21.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- Created attachment 139044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139044&action=edit Bug 30837: Fix table width on 'Print summary' To reproduce: - Make sure you have a patron with at least one checkout, one hold and one fine - On the detail page for that patron, go to Print > Print summary - Observe the tables are too wide to fit on a printed page To test: - Apply this patch - Repeat the steps above - Observe the table now fits on the page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135301|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- Lucas, the title should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Arthur Suzuki from comment #13)
pushed to 21.11.x for 21.11.11
Great thanks Arthur. It will make happy librarians ^^ -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org