[Bug 27293] New: Refactor C4::Templates and C4::Languages to not use CGI objects directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 Bug ID: 27293 Summary: Refactor C4::Templates and C4::Languages to not use CGI objects directly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org If you look through C4::Templates and C4::Languages, you'll see CGI objects being passed around a lot. In the end, all that C4::Templates::gettemplate() and C4::Languages::getlanguage need are the "language" param and the "KohaOpacLanguage" cookie. We should be fetching these appropriately from the CGI or PSGI or whatever context at a higher level and passing back the data rather than the objects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26791 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- We could also remove the following warnings since they're not actually useful: [2020/12/22 07:00:36] [WARN] no query in gettemplate at /kohadevbox/koha/C4/Templates.pm line 206. [2020/12/22 07:00:36] [WARN] no query in themelanguage at /kohadevbox/koha/C4/Templates.pm line 266. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Architecture, internals, | |and plumbing Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26791 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31380 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31380 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org