[Bug 13919] New: Renewal possible with item level hold on item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Bug ID: 13919 Summary: Renewal possible with item level hold on item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Tested in 3.18.5.1: - item is checked out to patron A - patron B places an item level hold on the item - patron A renews all - item is renewed :( Can someone confirm? I think there is no configuration option that should allow this, but maybe I am missing something. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This also affects the staff interface: when checking out the item again to another user, I get a warning that there is a hold. I override that and check it out anyway - and I am offfered the option to renew it. Soemthing is seriously going wrong here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In my setup it's AllowRenewalIfOtherItemsAvailable that makes the difference. Switching that makes the difference between seeing the checkbox in the OPAC and the 'on hold' message in the staff client. I understood it should only allow renewal if items are available to fill the hold - so I think this is a bug, as the other existing item can't fill the hold here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37376&action=edit Bug 13919 - Unit Test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37377&action=edit Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- The "renew all" button appears (same as intranet), should not we remove it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- I had 2 items, 1 with an hold (not renewable). I clicked on "renew all" and got "Please note: Your loan renewal failed because of the following reason(s): This item is on hold for another patron." 1 has been renewed (Renewed!) not the other. Could we get another tester on this one please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, but only the item without the hold was renewed? Or was the item with the hold renewed? I think the confusing message stems is what I noticed on bug 13913 - it just lists without telling you how many or which item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37377|0 |1 is obsolete| | --- Comment #8 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 37721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37721&action=edit Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37721|0 |1 is obsolete| | --- Comment #9 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 37722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37722&action=edit Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |nicolas.legrand@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
Hm, but only the item without the hold was renewed?
Yes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37729&action=edit Bug 13919: Make the tests pass fixing the number of tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 38307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38307&action=edit [Signed-off] Bug 13919 - Unit Test Tested both unit test patches together. Without main patch applied: do not pass as expected / with main patch pass OK as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 38308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38308&action=edit [Signed-off] Bug 13919: Make the tests pass fixing the number of tests Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 38315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38315&action=edit [Signed-off] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38377&action=edit [PASSED QA] Bug 13919 - Unit Test Tested both unit test patches together. Without main patch applied: do not pass as expected / with main patch pass OK as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38378&action=edit [PASSED QA] Bug 13919: Make the tests pass fixing the number of tests Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38379&action=edit [PASSED QA] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38308|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested with various combinations of item level/record level holds and syspref settings - no problems found! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 14104 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org