[Bug 10752] New: Impossible to add 2 identical suggestions, but without any explanation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Bug ID: 10752 Summary: Impossible to add 2 identical suggestions, but without any explanation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To reproduce: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. It won't save and there is no error message or explanation given. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 13086 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Still valid on 3.19.00.012 Seems to be by design See: suggestion/suggestion.pl around line 132 ###FIXME:Search here if suggestion already exists. my $suggestions_loop = SearchSuggestion( $suggestion_only ); if (@$suggestions_loop>=1){ #some suggestion are answering the request Donot Add } else { ## Adding some informations related to suggestion &NewSuggestion($suggestion_only); } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37967&action=edit Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Patch complexity|--- |Trivial patch --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA: I already used the message trick in some other bugs: bug 10363, bug 10855, bug 11023 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37967|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37991&action=edit Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Love the simplicity and ability to expand. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works really nicely, but there are 2 small problems: 1) I notice is that the link is not visible as a link - the font is all red and hiding away that you can click on the text in the parenthesis. - wondering, do we have another style we could use here? 2) Enter the first as "Test" then another as "Test " - you can save it without any complaint. Now create another "Test" - the error message is appearing twice? 3) The other problem... is that this also appears in the OPAC where the user is left with questionmarks why his/her suggestion didn't save. :( Not a blocker, but would be great to see it fixed! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38159&action=edit Bug 10752: Remove the specific css for links in an error dialog Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489 Date: Tue Mar 20 15:20:25 2012 +0100 Bug 6209 [Revised] Standardize on one plugin for client-side form validation It did not find how it could be useful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38160&action=edit Bug 10752: Alert if the suggestion has not been added - OPAC Same as previous patches for the OPAC. Test plan is the same. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
This works really nicely, but there are 2 small problems:
1) I notice is that the link is not visible as a link - the font is all red and hiding away that you can click on the text in the parenthesis. - wondering, do we have another style we could use here?
Ok fixed, I have deleted few css lines. I think they were not used.
2) Enter the first as "Test" then another as "Test " - you can save it without any complaint. Now create another "Test" - the error message is appearing twice?
Yes, it's caused by the way the search is done. To know if a suggestion exists, a LIKE "%$term%" is done, so if one exists with "Test" in the same, it won't be inserted. I prefer to show all results rather than choose 1 of them.
3) The other problem... is that this also appears in the OPAC where the user is left with questionmarks why his/her suggestion didn't save. :( Not a blocker, but would be great to see it fixed!
Done in the last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 38204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38204&action=edit [Signed-off] Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Love the simplicity and ability to expand. :) Tested with all pateches applied. Wors as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 38205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38205&action=edit [Signed-off] Bug 10752: Remove the specific css for links in an error dialog Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489 Date: Tue Mar 20 15:20:25 2012 +0100 Bug 6209 [Revised] Standardize on one plugin for client-side form validation It did not find how it could be useful. --- Tested with all pateches applied. Wors as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 38206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38206&action=edit [Signed-off] Bug 10752: Alert if the suggestion has not been added - OPAC Same as previous patches for the OPAC. Test plan is the same. Tested with all patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38204|0 |1 is obsolete| | Attachment #38205|0 |1 is obsolete| | Attachment #38206|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38213&action=edit [PASSED QA] Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Love the simplicity and ability to expand. :) Tested with all pateches applied. Wors as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38214&action=edit [PASSED QA] Bug 10752: Remove the specific css for links in an error dialog Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489 Date: Tue Mar 20 15:20:25 2012 +0100 Bug 6209 [Revised] Standardize on one plugin for client-side form validation It did not find how it could be useful. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38215&action=edit [PASSED QA] Bug 10752: Alert if the suggestion has not been added - OPAC Same as previous patches for the OPAC. Test plan is the same. Tested with all patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38216&action=edit Bug 14022: Follow-up - rephrase erorr messages a little Rephrased error messages a little and changed the link to look like it does on other pages, for example when looking at an order created from a suggestion. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #16)
Created attachment 38216 [details] [review] Bug 14022: Follow-up - rephrase erorr messages a little
Rephrased error messages a little and changed the link to look like it does on other pages, for example when looking at an order created from a suggestion.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Katrin, is the bug number on the patch subject wrong and this really belongs here? (it seems so, just over-checking) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No idea where i got the number from... can you please fix? The patch at least belongs here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org